From: Thomas Gleixner <tglx@linutronix.de>
To: "Matthew Wilcox" <willy@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>
Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
linux-mm@kvack.org
Subject: Re: Futexes & Folios
Date: Sat, 13 May 2023 21:56:56 +0200 [thread overview]
Message-ID: <87cz349f93.ffs@tglx> (raw)
In-Reply-To: <ZF+3xpmouwur4sVE@casper.infradead.org>
On Sat, May 13 2023 at 17:16, Matthew Wilcox wrote:
> Here's a patch which converts the futex code from using pages to using
> folios. I do have some questions.
>
> - I assume we really do want to base the key on the page offset of the
> futex in the file. That is, it's not good enough to base the key
> on the folio's index because the folio can be split after setting up
> the key, and if it is we'd then fail to find the futex later.
Correct.
> - In hugetlbfs, it doesn't matter whether the pgoff is based on base
> pages or huge page size -- as long as it's consistent between
> invocations, everything will work
Yes.
The patch looks sane, but I need to have a look with brain more awake
Thanks,
tglx
next prev parent reply other threads:[~2023-05-13 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-13 16:16 Matthew Wilcox
2023-05-13 19:56 ` Thomas Gleixner [this message]
2023-05-13 20:10 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz349f93.ffs@tglx \
--to=tglx@linutronix.de \
--cc=andrealmeid@igalia.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox