From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F20C77B7A for ; Wed, 24 May 2023 12:49:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14708900004; Wed, 24 May 2023 08:49:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F71D900002; Wed, 24 May 2023 08:49:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F00D4900004; Wed, 24 May 2023 08:49:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DEAB8900002 for ; Wed, 24 May 2023 08:49:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B1DAA1C7843 for ; Wed, 24 May 2023 12:49:30 +0000 (UTC) X-FDA: 80825129700.25.1349CE5 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf25.hostedemail.com (Postfix) with ESMTP id F2E9AA000A for ; Wed, 24 May 2023 12:49:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=3C27isGL; dkim=pass header.d=linutronix.de header.s=2020e header.b=Cz2Cme6Q; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf25.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684932569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v46tVIy0QFs7wWGJaUqHl4Lg4KOSNgImqOQFOByhcDU=; b=GSgCtZJMt0NIAbA7kp4JGzJnghz65S6YRA+aOGnYTpArTxYlneqG6Ux8bnQ8Jzdm+fG4s4 kPtT6Aqbsr0C1AF3OYzK7XdFTMFCPzCL6Fmhs2sIpM3fI7tusRpWtC+4oA1unCkT6nUYvh c9kDDNBaGxoK7jPZYjamRa4dwSfufKM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=3C27isGL; dkim=pass header.d=linutronix.de header.s=2020e header.b=Cz2Cme6Q; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf25.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684932569; a=rsa-sha256; cv=none; b=kwA6d/PFc2ezATk3/19vyYr+z8Ft8tQifBrvscMcPz+pLzdEoqXtQZcI4qHPDYGDSfiEFp dfU1x3BOi9OMSaEoLqeTYD47czqYfkvdnyoOISTNxDdN5OU5HsZ3S6xsuBk2lMsgOIoOnn 0WTY+/2d20FEFNJDR1nIe8I0sx7Zs+k= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684932567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v46tVIy0QFs7wWGJaUqHl4Lg4KOSNgImqOQFOByhcDU=; b=3C27isGLISmNcx7B3NFVkLcJRz71BkbTtnnuSClDjUdn3bWOVGm0ghpni7P5F4VVjAvXlm N/NKS4q1fI3qdV48NiiZVOhB7Z+IIGvHpbL3hJbwelorfGa9REGzd2kE2jdkmo5/tIr6bw SOtCTTn+vro0d9e/gJLmSFQ9Gxlz4QRWALBxwwkYLiD452Z9BNz3GNlEQIBNYgR0opPPIw JLjUiAGxwVTTPeHuYjrf+vWdtSIgLI86cTWThtOKPaJOLuBOvrad0nXynF8/bUiyhIiqYX j1JKX5bw5kawwog6FjuMRojmq2Ro0HmRZfKmo941yHnDBlwULmHeA9ukvzx3RA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684932567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v46tVIy0QFs7wWGJaUqHl4Lg4KOSNgImqOQFOByhcDU=; b=Cz2Cme6QUbY1W6gnMGrXf9KOHZb+FtqZ/d41ulvSe1gFS/SDJmnEGVFji4sZwxMrOOrS1q 2JRwVCcHBCnJNYAw== To: Uladzislau Rezki , Baoquan He Cc: linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra Subject: Re: [patch 1/6] mm/vmalloc: Prevent stale TLBs in fully utilized blocks In-Reply-To: References: <20230523135902.517032811@linutronix.de> <20230523140002.575854344@linutronix.de> <87mt1um508.ffs@tglx> Date: Wed, 24 May 2023 14:49:26 +0200 Message-ID: <87cz2pnbc9.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F2E9AA000A X-Stat-Signature: pbtrdppum6gue4euoagemtyuknposbey X-HE-Tag: 1684932568-189482 X-HE-Meta: U2FsdGVkX18Rzjum/oBeQHUPsUxlnFtTzFzq4Hf3QMgY+VcrC0HpfTLCSGIRjeMC+qzehXdgYnVBxM+CRjaTTjuUcrLnaUXoO+B4p5VuBNgtXKLHvWdXWD3mq9c8/ltQ60WAeVuhjsxSJIW3WqB3LfIE9Uhdu0MzRsdpwoTTz6kQxMVIqWclP4iscilfjxMz4z6AatlDGYa1TB/pnjYhfRMt1tzA1gxMEF4TK4nbpRiL1xI+4aAPs+EPneTJ6WVffl6ywP0bIyilYlJA59q7w0NDxApO27Hcxr5jjA26rekm0Fasr+WD549ycypJmScKz3UDg1YWxFGWle78IWtKEktwkFIa4NHIgeDIC0SGw+/KlCpvalm96acWRkkegGkpaQd6IvndLjabvJzaNqRNgI3qi+yMc4oXfyqECLR6pUKF4VBes44Fw9+MyOmGYp5/Uw96SLUjTyUV/0Ovufw/sUwiDNRWYG/MM/jPAHJgaWyQIsv96rKv+Zp/CaYejvey65zq544y0R0+Td9igMKChHb7Ask6JhrpkzrVMTe28bRFfvPxIFE0x5URKZOV9xAEjSkBnA2yE37w5SSEkvI5PaJKNbp0AaOcfJos9uhd+o9T6IGhy4EC6CaGnpSaiqhrIlhv8aw0z9MExyfnbDjHQpximoNgkfZK4XiOTpBwR2qGJLkcU2bdvfTyAeI0k7zCnwjkKCUVsh5KIY5vbDei/RXwTVR1g2Iw9o5slcJShPzUHFdzvPIgNNrSyuTlJc8tDb3Uvfg2ZKjx+Lg6YZDusMoDUtOy3VWIpwxf+iniUImxbAl3MGXbPbzdO9pBiinxBtWr0xQ+Mt9WqMeQwUF9KQUHAxdVbKKnbyOARaZAZiC90Bzvu5k9O23tMkluj+VX1fyKrdYC4PCMFQKtJ9NcjVVlVZJJca2Sq+ddyTJYW5HE+hHLyBoyoHenZDBXZEcQesOAsHuXn66YRGsh+13 xQvxPuVU P5YA1TD14Mk6NDsUWqVupWd70FSGWN4Gka6y4Bypiy+JXLqA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 24 2023 at 13:36, Uladzislau Rezki wrote: > On Wed, May 24, 2023 at 07:24:43PM +0800, Baoquan He wrote: >> Yeah, because $X is not yet unmapped, the block could have unmapped part >> flushed, or unflushed. For unflushed part, it's got flushed with $X >> altogether in the purge list. >> > If we gurantee that vb is fully flushed, then just do not add it it > purge list: There is no such guarantee today and there wont be one even with patch 3/6 applied because: unmap_aliases() flush(dirty_min/max) reset(dirty_min/max) vb_free(lastmapping) vunmap_range_noflush(); vb->dirty += order; if (vb->dirty == VMAP_BBMAP_BITS) free_block(vb); <-- the TLBs related to @lastmapping are _NOT_ yet flushed. Thanks, tglx