From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412BDC00528 for ; Mon, 31 Jul 2023 20:52:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC8D22800A7; Mon, 31 Jul 2023 16:52:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C798728007A; Mon, 31 Jul 2023 16:52:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B67ED2800A7; Mon, 31 Jul 2023 16:52:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A6A4A28007A for ; Mon, 31 Jul 2023 16:52:32 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7357112012F for ; Mon, 31 Jul 2023 20:52:32 +0000 (UTC) X-FDA: 81073105344.05.2F70386 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf27.hostedemail.com (Postfix) with ESMTP id A2ECD40013 for ; Mon, 31 Jul 2023 20:52:30 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="nLxjrl/F"; dkim=pass header.d=linutronix.de header.s=2020e header.b=yY7ufkgt; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf27.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690836750; a=rsa-sha256; cv=none; b=lmWEQdhCS9TxGhEB7yoOZHZ5cY0epeALpn0IuVDZshHpUhuxuEKEMTWSxirt43mSM4Z6qB haMXkndtvI1QnSKZnrQc319iNu+gDgCdeTH4M7uW+Dx3ao1NY/k9eAfGKLwRXiFXXNCfTN e+xTu1FEzHaukM9O2D0CBdLdojruybU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="nLxjrl/F"; dkim=pass header.d=linutronix.de header.s=2020e header.b=yY7ufkgt; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf27.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690836750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=buYJKjQ237JCo+lND5Be2oqIGKiZxmUkCcs0tnZIjrA=; b=1ZzU+Fu3swcf9PO9E4PP0rlJVuRFNLisxDpeUObVspiBWv1M43WWhYaXOVF97SWUqj+yra J1HbGx6n0vcNK1Kc6H5OXA1BRTHp2fuXb8dE5URtT0geGCnbq+guJC3CWCepf8sXOJ5C9+ 1rZwQZfgw0RSPT3ke2lCbduk60/c+Yk= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690836748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=buYJKjQ237JCo+lND5Be2oqIGKiZxmUkCcs0tnZIjrA=; b=nLxjrl/FgW7S5RAri34yJK3Fps7e3JoJprljai7RwaoDmY+XLlkIWCsJAWaHFrbEh8cOZa kc82sC5ZUoxnTxPyQ3ZjZORcYpjlAjTE1Sutd5dff2HoHm5WQrb291oFq3LkyxH3lh3c5C DS/BUlUb5YVNmdAF5IbOHufqlyo76BEx2OXrh7f3j1qs8CojtQL8dsuhq5EInC22NFuFas 5p6HnQmIPVS9nbe7vmDs+FnD+1j9Y+89QRdLk0Jmir61FVRe0KSRQxYix3Py1fzA+51Yw7 Yy4oNDR+7Y8rKN3nOeFpPSP64iK/UeEbrP5ONDh1XikPJZ6LACJfdPhm/SdiLA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690836748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=buYJKjQ237JCo+lND5Be2oqIGKiZxmUkCcs0tnZIjrA=; b=yY7ufkgtHNjU8gf3lLYpYl69LwEFgE9y4qgu3u0WHPPKKI0piKmkBxl8ghoz+vka0QjIgr 0AnxLUi+55/ZG3Dw== To: Peter Zijlstra Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 02/14] futex: Extend the FUTEX2 flags In-Reply-To: <20230731173515.GP29590@hirez.programming.kicks-ass.net> References: <20230721102237.268073801@infradead.org> <20230721105743.819362688@infradead.org> <87edkonjrk.ffs@tglx> <87v8e0m26q.ffs@tglx> <20230731173515.GP29590@hirez.programming.kicks-ass.net> Date: Mon, 31 Jul 2023 22:52:27 +0200 Message-ID: <87cz07n6r8.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A2ECD40013 X-Stat-Signature: 135btdahm9md9dkfr1upew4ret5s9a8s X-HE-Tag: 1690836750-586349 X-HE-Meta: U2FsdGVkX1/vFd68GhXAr27oxzJUVMSzoJdthVshgyE499Qtg8lbdDdtPLcIRAgOjAVQq/cnWMvX/5CalhjsvueOD6a+40fhyIfvbJa4H5I0110B3GeNs7MbEu4Xu1SNwz1jCCVYes0oJMxSBIDfQJKtIDMwJzdH6MClGn25Sh5J/nblqzdwy/svxcN7q6oSGLtGoyn7XEfG3rkzCTMHK0OZPxlhc1MTw2C3FgTKj8M9M15FaMxkh6lE9UBxjOCc3DbYxmh63oTP8AfVQuNc4bZEjc/C2F+Jl1vQjJUPdeexSgoD+/30naezvjg9EGyFjAWcnB9t7FkWTZV+8k0iMGIgP1Wr6z2MznDddMU5SojDjZOoMOJ1URx+BkEbKjJddvvi/AAHdqLOE0A1hjTgBy7Wpn81/R2DtwJPjuF2HqgIRkDd31qZKTzMKo7vmVboFPqHZkecMLzBXPcx472bvoLqtRjNdugZlvLltRIb4PoBnDWHDfBc/eYeaFZEtV+5LCUlzlcCRc6NkRkaRWOx2+0mly2vZaOLkCWsGWbPpl0bIxgTnJxmhwiH0FRb5rifHGNTPgq8YjKBbqUn4La+BNCh5zCr8rqp8/v1tmI7GYaJ0fg8YE0syaUODGXytN257lpqXk0XrMXox9zAJypcMZME1XejX0SaF+p0G9rWnnpEVJT5BjloUmASSAiA88xb9sXzvgxxQ09E2lKKukpSdMAsYXtcBxRpWuCNdy9NPBbvcmsQO/4ml3bHU22CIpZTRkJX6Q04zoA4oV+07Wc6J8SmCEmsuc5tzh3eG1LISn4A6aOjDdX/1CKOCnLhKJW2s8M563qCjhnXXIXaZXFTqeg89MBiTUUyd/d8zW/h4S1n/mZOJqwpp2k5tZLFInw+Og7gEQTX27A/j/hOVGEAGGUCPuCGXPSnOi+VwXrv4dhfsdhK+8CoCm5daZqK2qTdx+jvZP8J9S8j4/TCNKz 7mc4V9II WSBJdIfhs76r/u3zujodPOfnR1l0FEVkMowZGrwlzOWGKp5g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31 2023 at 19:35, Peter Zijlstra wrote: > On Mon, Jul 31, 2023 at 07:16:29PM +0200, Thomas Gleixner wrote: >> On Mon, Jul 31 2023 at 18:11, Thomas Gleixner wrote: >> > On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: >> >> -#define FUTEX2_MASK (FUTEX2_32 | FUTEX2_PRIVATE) >> >> +#define FUTEX2_MASK (FUTEX2_64 | FUTEX2_PRIVATE) >> >> >> >> /** >> >> * futex_parse_waitv - Parse a waitv array from userspace >> >> @@ -207,7 +207,12 @@ static int futex_parse_waitv(struct fute >> >> if ((aux.flags & ~FUTEX2_MASK) || aux.__reserved) >> >> return -EINVAL; >> > >> > With the above aux.flags with FUTEX2_32 set will result in -EINVAL. I >> > don't think that's intentional. >> >> Also if you allow 64bit wide futexes, how is that supposed to work with >> the existing code, which clearly expects a 32bit uval throughout the >> place? > > Not allowed yet, these patches only allow 8,16,32. I still need to audit > the whole futex core and do 'u32 -> unsigned long' (and everything else > that follows from that), and only when that's done can the futex2 > syscalls allow FUTEX2_64 on 64bit archs. > > So for now, these patches: > > - add the FUTEX2_64 flag, > - add 'unsigned long' interface such that > 64bit can potentiall use it, > - explicitly disallow having it set. I figured that out very late. This flags having a size fields which claims to be flags had confused the hell out of me.