From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6D5C27C53 for ; Thu, 20 Jun 2024 01:25:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C61568D0096; Wed, 19 Jun 2024 21:25:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C10D28D0066; Wed, 19 Jun 2024 21:25:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD9008D0096; Wed, 19 Jun 2024 21:25:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8FEC08D0066 for ; Wed, 19 Jun 2024 21:25:41 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 33E78C169A for ; Thu, 20 Jun 2024 01:25:41 +0000 (UTC) X-FDA: 82249524882.20.6EE5AE3 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf30.hostedemail.com (Postfix) with ESMTP id AF3F38000A for ; Thu, 20 Jun 2024 01:25:37 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=b96kJsQJ; spf=pass (imf30.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718846734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fL10f3JiFhEmxwMNOf9Co8+rjtk1Zks/dQB14PrKWU8=; b=Ge25Y4esRh7Gckwd0qDbSTBJ/xk+eOZKQbD/OYiuQZHpyoRhdh2+on1UMDfvMcR95qI2wS RfHhzIV8HboLb+tiGdlDapEslhrclmmI+MvjViHX814Sgd1FkuYttMJQUZHQ8HWGyRZ02y qtBt4CJB5SODTlmkT812jJEbL4wC/gU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=b96kJsQJ; spf=pass (imf30.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718846734; a=rsa-sha256; cv=none; b=YzU0RBlnGwO7X7I7x02Y2OUDYjJpHhufUenyhgHwVcea4ljIaNIJIhv1oj5t06q5OLrXex birJmtyflROk5grokj5gEK+R3oQXVoOPOAh9C3PnG+B9SmoKTagAB+85zRXqpVuw9cw/Qv HmcpbbvAwmu457j+jLhbQKrY/DTs/AY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718846738; x=1750382738; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=UcBVFMZSJqd2jYOVzXRQ44DWDio1IXQh/wpSEqyH9Ow=; b=b96kJsQJ2cd3DLKc3sF7L1JrzUfNX86yOimHTa2ZNZ2r/+2vTHpn3u6W m29+J4SF50I92ZIbRW7hLZ8UU4bwt+1o0x6T/9PhBqWwsXy1JEwTiC/9c +Y3AUEzy2JWwMRlpx/73fm9Lb9ITZoE7KllPwVNH8+vZHvzX23RhOAw9w PtIss/LUPH4H+XXKW14B5H9ddjQjdy/X/oqIWt8PWmY9w0xgs6k63nTO7 mA/WkHHOwfATouRHRwOurK1xsFlpmOLwPPbr6qpgYncSJKpZzcw8JommZ g+VrZ9emSrYvEHpajRjtijtUCQ2fn3S4ou3rPUBHmilgaPh44qbdUPSZN Q==; X-CSE-ConnectionGUID: sAbQ+P8DS+6stTLZIvzvWA== X-CSE-MsgGUID: 8L0SVD8NQvmiwCsNEDXu7A== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="15944755" X-IronPort-AV: E=Sophos;i="6.08,251,1712646000"; d="scan'208";a="15944755" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 18:25:36 -0700 X-CSE-ConnectionGUID: /q/ponmQTBStiVBH+ujPZQ== X-CSE-MsgGUID: kgNcYnp/TGCxtcljvJcHrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,251,1712646000"; d="scan'208";a="42772346" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 18:25:34 -0700 From: "Huang, Ying" To: Zi Yan Cc: Andrew Morton , Hugh Dickins , , "Matthew Wilcox (Oracle)" , Yang Shi , David Hildenbrand , Yin Fengwei , Subject: Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent. In-Reply-To: <9D1249AF-CBF9-4283-B1E4-6AF7890C23E0@nvidia.com> (Zi Yan's message of "Wed, 19 Jun 2024 14:13:02 -0400") References: <20240618134151.29214-1-zi.yan@sent.com> <87plsd4co5.fsf@yhuang6-desk2.ccr.corp.intel.com> <9D1249AF-CBF9-4283-B1E4-6AF7890C23E0@nvidia.com> Date: Thu, 20 Jun 2024 09:23:42 +0800 Message-ID: <87cyoc4db5.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: AF3F38000A X-Stat-Signature: kexphjoxykjza4mixibxwq1oncp9836p X-HE-Tag: 1718846737-913910 X-HE-Meta: U2FsdGVkX1+vTBkOluFHmimV2KEkCynsXLPOKp0wqvt55C+tXtTC+C6sJ8D5UfpR16s2Ruc49wh3QNj4r7mOS+PPK/zETidUoBeu+lr+cdt/pWNumiX92Ejzdlyz5U/l5mM6Mo09zr0U2KSDBiXdZ+Q1XOgIAiHSG6gO2p2SSDkJDxcV1xy5f/xHnaNfCS7DZiHeapO0Z92+fp1tCfCkXdc80v4azNuP3WHVyq7Bx9oKokKZAvYnU8GZtVLxxeyBiBieX2QIgZoILC5y68mwhDMewyAUOZkV6tmyR84ProMzV8Uc9WFmY16UjMbA6R2IHu3ataOq6sVCWrI1MvzWlXZp0YIvFTX1spNfa+pdjT6ZE0xdircUHXk7ihauN8fNUR9KmzeNJAujQDmGJE60cjuq3Dm/6mCjN1QxsOvtBP8lbssmkPv+R3NbSh3JaGYmip0ykDrDiNJ2jdAaxwyto30VgQUN6mEsp46KNzDdIj5gd6OeyCLElsCa6tz0ELH/R5+lKSW8xFAS/g91ye63mvhX6ec710TWS11FR2kxiNb2RxhgxFHqkd9fcRaRD09db6gUVWUJcuQNR0LyDkANiFMeecAsHCc0EFErGd+rBqX4ZB+tAHUEAS/Sa5JNYCvfX0AnI9C6/RyPx+xBfpMDwPfrq3B+9cDvGq+juOR+Uyd8RTOUwsFPLYvEIsFsGibnjbca2w2q4rGfwPoK/gUkcfhnqU2fQZSILkpZa7O6JsvwOseP5rn9fAyre767njQpP68H0Q4JsOtu8WiYiLLwE13l2gvm8O1Nfwa0zGjTFl/N949GPI3N9egKHll7eOLDaTfXvctlCabTsgNa4ZgLjnniXzO+mtM8jcOZXfiO0koYcWQ+HZ/si7xZcNawvKOiKH3tHzyr+hFLpXkaurqWYb51NCCaOBJADwC9HKbHTvXXHqiQY6bsgXNlMKAvtQOJkCxh/y3ioB57PGrB9C8 RhrCMzH0 kmG8nFMhC+tI8ZHbpb87+XHlPy4tptdqOkdmdHKJiMyylAhbV5aMjCUNBTMH2bOs8pJJaQvykUv+T2uDMMlJZWG/M+z3f/5Z/8BwQiro5pGRRhxWuZLFoLn9Y678gw705XrxOFS9z56ARD8Hcq7pbuFs6wGt2F2S9ZICUBeZYg5EB6dwynxfbUFRXyJ3mkgoI3tG+7i9+6Pl6NjmGAtEDkkh83JLLWMZWzHeIyqqyMEIcLgF+XJeLoRgjQqVcGzLGyNA0TA/SPVp3eo51Zdiqn2o0a8hyjYxytxK3aXGp6kakt/2bWyoRxtEuONXubLt7F08tVymLMTMOr2XDT52RatOIFbEQtXcjdMgDJcVkf3EYweXtKK9z0y4KSd6n0inun2/X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zi Yan writes: > On 19 Jun 2024, at 3:25, Huang, Ying wrote: > >> Zi Yan writes: >> >>> From: Zi Yan >>> >>> As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to >>> avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when >>> calling migrate_pages_batch(). > > Because if not, when migrate_pages_batch() is called via > migrate_pages(MIGRATE_ASYNC), nr_thp_failed will not be increased and > when migrate_pages_batch() is called via migrate_pages(MIGRATE_SYNC*), > nr_thp_failed will be increase in migrate_pages_sync() by > stats->nr_thp_failed += astats.nr_thp_split. > >>> >>> [1] https://lore.kernel.org/linux-mm/87msnq7key.fsf@yhuang6-desk2.ccr.corp.intel.com/ >> >> IMHO, we shouldn't ask people to use link to understand the patch >> description or commit message. If so, we can make the link less >> outstanding and maybe add more words about the issue. > > I summarized your explanation from the link. You think the summary is not > enough? I can add more text. Let me know if the above text looks > good to you, then I can resend the patch. Thanks. It looks good to me, Thanks! -- Best Regards, Huang, Ying