From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC0BC36008 for ; Wed, 26 Mar 2025 08:12:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9E65280061; Wed, 26 Mar 2025 04:12:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A49A2280056; Wed, 26 Mar 2025 04:12:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EB56280061; Wed, 26 Mar 2025 04:12:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6FC4F280056 for ; Wed, 26 Mar 2025 04:12:47 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1BA0FBB737 for ; Wed, 26 Mar 2025 08:12:48 +0000 (UTC) X-FDA: 83262986016.04.073EE88 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 75A5240007 for ; Wed, 26 Mar 2025 08:12:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AjCDEGNY; spf=pass (imf01.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742976765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MiWbr4c29SdRI1UNKMIY7QEPFv55J1r0dBdY+fmk80M=; b=2dHB2PS0zHoolKpnWXRSjc+YokSp/lKKBvPO3W8/KyGT23DglZw3ELpshGMXTyVcUvdOzR k3dUH2d35Xa3xdjU+nVw0NbWJz1mZtV5TnxrzKo/aDspIzHcijrGBWS/mZKQUraUlOJ9kh oQQv1UD5wXdiTD8jhK9HYBuG6rfxVJ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742976765; a=rsa-sha256; cv=none; b=KSJZaop5mnfWH7b18TG9sNRccilUAQl2Pwg096LcuPVziWvVxDvZhi4g9vy/64z6xXjPqi 5jynYETlxIwc3GgJ38SFZx+i0iL7uGYN4foroi58kV0f8786e+bqLozW6FodH7vLNbLq0Z tmEgR1uxQuaB7WtidHNJNNrhGwyZpl8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AjCDEGNY; spf=pass (imf01.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742976764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MiWbr4c29SdRI1UNKMIY7QEPFv55J1r0dBdY+fmk80M=; b=AjCDEGNYl8S2Ax540fgKL53lQTzJKQsI2Jyr3vTSMRxc1H5IhSZJnHdjM0ZZUN9A6Q8LkT dYDTkT6mu50Xs7Raf0igejxYlbJ+jwIgTFmvkvupZVBQOouyVJWD6cd4fO0+KLlGrcKHHV 8X9RaxQFe5QWL19FIC6bNGjRLuoiN7c= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-xxbbHXgROdK5yo6ttKzjtQ-1; Wed, 26 Mar 2025 04:12:42 -0400 X-MC-Unique: xxbbHXgROdK5yo6ttKzjtQ-1 X-Mimecast-MFC-AGG-ID: xxbbHXgROdK5yo6ttKzjtQ_1742976762 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-ac2aa3513ccso505305966b.0 for ; Wed, 26 Mar 2025 01:12:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742976761; x=1743581561; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/i5+/BRMZy/oWIkpPBk5bPU1qjbR62bTRHV5eQdywzI=; b=f+FSJ/lAVZ8ls7oXfpnM3ji2C5RPuzeEjZli1povqlmmtvGGkf+ZMgrhIUtToBEZiX qm0q1czKCpzcvyp+AKJlXbjSmy+PHyJuQ8gvJ/8R/lkwStIPD+Gud3bP+o0c/jl9oMM4 Tmf8XDmV79X6GlRArdDZgMjHaCDD1HE1mSLNDeIFX5MltrF0A+9+Rhl+dmeeTM6mjr+X mc5qEpStBpQB4h/dgyEYNETHw7Qkz9tZAUVkdkTZHGYUlCNSWcocgIxsM1BiGFqMrBoP wM7gIDNQP73X7SX8bt6Sa47o3GFhd+jikTxrxFmsYpDB2xV8B1lx+LAM1G3p2n9Fo/a/ oTMA== X-Forwarded-Encrypted: i=1; AJvYcCUHfCCEPnivmrE7egciyNG2PJhM/TMpwo4jBglp1gewQIq2fhBuErWox449DYePJq1FBBbTeytnYQ==@kvack.org X-Gm-Message-State: AOJu0YwIsjK5b/0cEZ0hD0f82d4UCxAY+W1lpajvkABWII24Msd4R1Il NPeGyTLtZ+VRwrnsaD5XTr39Eo9034BVrr3A6cyCge8wke4Iy9TsBiizha/237Mzqu3weLDh6Cq EJry/guh0ShKWINuEJtOtGCc2Y6WlaYNOER6pFAsSXXxq1uBl X-Gm-Gg: ASbGncuy1vSTYKd2W7DKJyFENs5YSbQgLpbIhMulLjec578n6I8A0A86hGJiSUKHvuU BU+qaAyrgY4rweQsvP8igPEDXXn7GcT6fY6mJVfvjFc+k8hTZ9sWBLORZdvH7x3iC0BTa4jGXB8 nFQqK9BVffEqZKERho848PRQ623rRHM09zCrZ1l28F8FRp2NpbX/zYaPW6W8nZSTB9yGSfEL2g5 oE+TgjS0cAD5UZzNA84sY1SWN1jqoUSmQRwq2iXEQmxjZbtOmPomxgU7LISHmiHD5qyG6mnOHzj uCix8nD+awNqN33PHuUt0rf6GS7UwFQ/ZOTrkcne X-Received: by 2002:a17:907:e84c:b0:ac4:751:5f16 with SMTP id a640c23a62f3a-ac407515fefmr1710095566b.30.1742976761513; Wed, 26 Mar 2025 01:12:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7tYXUyRnYRid7WXsc4ocXyKGAEp70GrWLAvLlsK1V4El27+8QO6/yVgb6O5atgR4hk9tmqw== X-Received: by 2002:a17:907:e84c:b0:ac4:751:5f16 with SMTP id a640c23a62f3a-ac407515fefmr1710092166b.30.1742976761087; Wed, 26 Mar 2025 01:12:41 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3efda474bsm988606066b.183.2025.03.26.01.12.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 01:12:40 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 305D018FC9C4; Wed, 26 Mar 2025 09:12:34 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jakub Kicinski Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v2 2/3] page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap In-Reply-To: <20250325151743.7ae425c3@kernel.org> References: <20250325-page-pool-track-dma-v2-0-113ebc1946f3@redhat.com> <20250325-page-pool-track-dma-v2-2-113ebc1946f3@redhat.com> <20250325151743.7ae425c3@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 26 Mar 2025 09:12:34 +0100 Message-ID: <87cye4qkgd.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XAwIKOwiNSLHC2Y6BvVkNKFVTWcAC6PBILDcadzEhAA_1742976762 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: b51rgjxrudzbfmod9zr9jsgrtggnyenu X-Rspam-User: X-Rspamd-Queue-Id: 75A5240007 X-Rspamd-Server: rspam08 X-HE-Tag: 1742976765-887153 X-HE-Meta: U2FsdGVkX185xer1qzzB4Oy3IVI2U0afZMvi+IeNoIopN4iK28DSNTRy7lSAkMZb7mNV3IGYeu4+q59fvZdPNij9V6AzRYiSUjcQhgTiBBDiGnFvO122Hbe8RMtN9TrpkhIFSHtdTLK8cism5X/KR4gCbhXj+N7iTqyWYLIM+KlRI1gUwDIBSJM1e7skG8PrKwjUu1pMZ0lIVyxvlmzyVezUIbI7ulUXZl9tkoMvN/1D7Rl/vWBnOeJ1LfIjbCixviw4Lt9ZaKC7vxgbzD6Cc0M/Bqsa7640JxNmmd1IK4cLFM1IfXZc8NYfuWqKK3HvRBq3iJl4ykwxXXZk6tH0JCfX1hfxhr+hpEYL+XAWzh/GViLyGa+cXdkdO8JT1WuN1PE3qoxyVGTNDamSU8KQPSLJviQy4nR5sLQws4iPYfjYgoOFdo1ascSxkFQY6PwGg+XXCSt4ALJqK8OeL99JMRS6OZlOF692QFuLR04J2dx9aIqEzaAenyfj/y0tQOYMeUXMXzuB345GsHcbBvqMDud3h4AM5Ly21VPXJRnnnW0mRTMUNfwgqTuwQS2dHWac2yqLo9vWo42lJzoucqqQOvMJGdicrFf8vFYHsLHIV9WKPjOsSCM4mz+uOMgXJ4mUoIzRHiRKCMKoeQvUKtZmx2ANN66T/OqPdmwHYpDI1q0gTILjeXcD86b0Q6Ymq1k9zatTSbqdwiONaY09hIdIHEPeM3iGciWcm2fNK9kz6yICqIrjyMbzC+yuJF/VDSBz/6fCk5YGLAwa1/eHpXUFcdImz2KW0z3rYF5jVF2tridKbSORUXccjbkugk4xGkKo5S04En04nBYy7PJD/QenyNFHSQ8rgJCHCO3ez+3tL3XurKeq5a6aIIkZ4nZwy3mxw2KCRFlUMshz4HOUrfOjrYNc4s8sVTJFMCZ8x5pegYcE95cYGU4LlevdM0IeUXTSHi8Hquq99E1o4TR9RAn DbAG1kBQ w7xJTAOpQKVdE/C/k27J+OyMirmGWW+N7kORZ5+yxWg0Gaku8GItiXtAfpSMyNHiqZcptg7qXDm/9IQPMCgrO7a7LK/kFelIr/KoN0D1Vhx6Vz3aAWxkRC+eP09kMlj8z5EkK3v15pKSEoMSLRUJUzgefrGH36gecjibcrOXY6qCW6NqFf9xDyxPS04T2VKVckxG+gIdJHgDJ1dP6uyOy6xOQMSN4Tn+Rz/Mow/divOtVotd4n0isJwjFS9mcyGutKPHnEDje8atwMvBfLBJocodzuPQM0bxZZ7/YO9fvlOtoCjf/zfItoq4b5Xz48mNu0SKab39zdZjxVwVY5AX0DWEXJRCKRrbG2Te079ubkQiw3aheRuj+4HeiQgi86diA0qFCEPOMgBiC/mn7RzoIAhY50QwdnpPcYh4A0rGicIwAX/D4oTyKTG+8qqmo2szsE2BL+nL910lApYdP6dL0MjfCKKs0Fstzv0I9hFMFJGTSlIshZtcqVZD4dMZoGLo4Dk2OA6FKRCZfVXQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jakub Kicinski writes: > On Tue, 25 Mar 2025 16:45:43 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >> Change the single-bit booleans for dma_sync into an unsigned long with >> BIT() definitions so that a subsequent patch can write them both with a >> singe WRITE_ONCE() on teardown. Also move the check for the sync_cpu >> side into __page_pool_dma_sync_for_cpu() so it can be disabled for >> non-netmem providers as well. > > Can we make them just bools without the bit width? > Less churn and actually fewer bytes. Ah! Didn't realise that was possible, excellent solution :) > I don't see why we'd need to wipe them atomically. > In fact I don't see why we're touching dma_sync_cpu, at all, > it's driver-facing and the driver is gone in the problematic > scenario. No you're right, but it felt weird to change just one of them, so figured I'd go with both. But keeping them both as bool, and just making dma_sync a full-width bool works, so I'll respin with that and leave dma_sync_cpu as-is.