From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 12 Sep 2006 13:05:15 +1000 Message-ID: <87bqplaiok.wl%peterc@quokka.chubb.wattle.id.au> From: Peter Chubb In-Reply-To: References: <45061F16.202@yahoo.com.au> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Subject: Re: A solution for more GFP_xx flags? Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Nick Piggin , linux-mm@kvack.org List-ID: >>>>> "Christoph" == Christoph Lameter writes: Christoph> On Tue, 12 Sep 2006, Nick Piggin wrote: >> This seems like a decent approach to make a nice general >> interface. I guess existing APIs can be easily implemented by >> filling in the structure. If you took this approach I don't think >> there should be any objections. >> >> A minor point: would we prefer a struct argument to the allocator, >> or more function arguments? It is an API that we need to get >> right... Christoph> If you look at my allocator API (see the latest slab Christoph> patchset), one could add all the allocator methods into the Christoph> struct in order to objectivize the page alloator. Dunno about you, but the thought of passing structs around on the stack gives me the heebie jeebies, especially if they're going to be more than a word or so big. Either pass by reference, or separate out the args, so it's explicit how much info's being copied around. -- Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au http://www.ertos.nicta.com.au ERTOS within National ICT Australia -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org