From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx105.postini.com [74.125.245.105]) by kanga.kvack.org (Postfix) with SMTP id 69D2A6B007D for ; Tue, 18 Sep 2012 07:41:59 -0400 (EDT) From: Rusty Russell Subject: Re: [PATCH v10 0/5] make balloon pages movable by compaction In-Reply-To: <20120917151531.e9ac59f2.akpm@linux-foundation.org> References: <20120917151531.e9ac59f2.akpm@linux-foundation.org> Date: Tue, 18 Sep 2012 10:15:59 +0930 Message-ID: <87boh4qhtk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton , Rafael Aquini Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Rik van Riel , Mel Gorman , Andi Kleen , Konrad Rzeszutek Wilk , Minchan Kim , Peter Zijlstra , "Paul E. McKenney" Andrew Morton writes: > On Mon, 17 Sep 2012 13:38:15 -0300 > Rafael Aquini wrote: >> Results for STRESS-HIGHALLOC benchmark, from Mel Gorman's mmtests suite, >> running on a 4gB RAM KVM guest which was ballooning 1gB RAM in 256mB chunks, >> at every minute (inflating/deflating), while test was running: > > How can a patchset reach v10 and have zero Reviewed-by's? The virtio_balloon changes are fairly trivial compared to the mm parts, and Michael Tsirkin provided feedback on the last round. However, the real trick is figuring out what the locking rules are when the mm core calls in to ask us about a page. And that requires someone who really knows the mm stuff. > The patchset looks reasonable to me and your empirical results look > good. But I don't feel that I'm in a position to decide on its overall > desirability, either in a standalone sense or in comparison to any > alternative schemes which anyone has proposed. It's definitely nice to have, though it's far more complicated than I would have thought. Cheers, Rusty. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org