From: Andi Kleen <andi@firstfloor.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: optimize copy_page_to/from_iter_iovec
Date: Sat, 23 Jul 2016 13:59:13 -0700 [thread overview]
Message-ID: <87bn1onk9q.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1607221711410.4818@file01.intranet.prod.int.rdu2.redhat.com> (Mikulas Patocka's message of "Fri, 22 Jul 2016 17:12:46 -0400 (EDT)")
Mikulas Patocka <mpatocka@redhat.com> writes:
> copy = min(bytes, iov->iov_len - skip);
>
> +#ifdef CONFIG_HIGHMEM
> if (!fault_in_pages_writeable(buf, copy)) {
If you use IS_ENABLED in the if here ...
> kunmap(page);
> +
> +#ifdef CONFIG_HIGHMEM
> done:
> +#endif
... you don't need this ifdef.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-07-23 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 21:10 [PATCH 0/2] mm patches Mikulas Patocka
2016-07-22 21:11 ` [PATCH 1/2] mm: add cond_resched to generic_swapfile_activate Mikulas Patocka
2016-07-25 7:26 ` Michal Hocko
2016-07-22 21:12 ` [PATCH 2/2] mm: optimize copy_page_to/from_iter_iovec Mikulas Patocka
2016-07-23 20:59 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn1onk9q.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mpatocka@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox