From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68209C54FCB for ; Mon, 20 Apr 2020 01:41:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32FBB2087E for ; Mon, 20 Apr 2020 01:41:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32FBB2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBFF68E0005; Sun, 19 Apr 2020 21:41:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6FC38E0003; Sun, 19 Apr 2020 21:41:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A84FD8E0005; Sun, 19 Apr 2020 21:41:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 8DB1D8E0003 for ; Sun, 19 Apr 2020 21:41:50 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 31DAD52BB for ; Mon, 20 Apr 2020 01:41:50 +0000 (UTC) X-FDA: 76726531980.15.legs47_845ccd3cf1a5a X-HE-Tag: legs47_845ccd3cf1a5a X-Filterd-Recvd-Size: 2754 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 01:41:49 +0000 (UTC) IronPort-SDR: ZDSHnLqBiLghxmuNviNdZ/jdiCXKBgPq6uGW237SBVj/gglj7wYOsERNHpNAU1dmcHDHXDxfYq WuqjzNVeU/Rw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2020 18:41:45 -0700 IronPort-SDR: cQywvut7KlsssAmI6HgQ7kpCWGMEr1J7+8bZivrKwjlPT0m2qEsYrcVay35ImJ9Ich05Z+vfMv /YXBPe0W1wlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,405,1580803200"; d="scan'208";a="455470756" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.159.23]) by fmsmga005.fm.intel.com with ESMTP; 19 Apr 2020 18:41:44 -0700 From: "Huang\, Ying" To: Wei Yang Cc: , , , Subject: Re: [PATCH 4/4] mm/swapfile.c: move new_cluster to check free_clusters directly References: <20200419013921.14390-1-richard.weiyang@gmail.com> <20200419013921.14390-4-richard.weiyang@gmail.com> Date: Mon, 20 Apr 2020 09:41:43 +0800 In-Reply-To: <20200419013921.14390-4-richard.weiyang@gmail.com> (Wei Yang's message of "Sun, 19 Apr 2020 01:39:21 +0000") Message-ID: <87blnnszl4.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Wei Yang writes: > Each time it needs jump to new_cluster, it is sure current > percpu_cluster is null. > > Move the new_cluster to check free_clusters directly. > > Signed-off-by: Wei Yang > --- > mm/swapfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 07b0bc095411..78e92ff14c79 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -603,9 +603,9 @@ static bool scan_swap_map_try_ssd_cluster(struct swap_info_struct *si, > struct swap_cluster_info *ci; > unsigned long tmp, max; > > -new_cluster: > cluster = this_cpu_ptr(si->percpu_cluster); > if (cluster_is_null(&cluster->index)) { > +new_cluster: > if (!cluster_list_empty(&si->free_clusters)) { > cluster->index = si->free_clusters.head; > cluster->next = cluster_next(&cluster->index) * In swap_do_scheduled_discard(), we will unlock si->lock, so the percpu_cluster may be changed after we releasing the lock. Or the current thread may be moved to a different CPU. Best Regards, Huang, Ying