From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 297C2C433F5 for ; Mon, 7 Mar 2022 02:01:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A5318D0002; Sun, 6 Mar 2022 21:01:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 653E28D0001; Sun, 6 Mar 2022 21:01:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F50A8D0002; Sun, 6 Mar 2022 21:01:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 3FB038D0001 for ; Sun, 6 Mar 2022 21:01:01 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BA11618194D70 for ; Mon, 7 Mar 2022 02:01:00 +0000 (UTC) X-FDA: 79215937080.29.203917F Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf08.hostedemail.com (Postfix) with ESMTP id 53561160002 for ; Mon, 7 Mar 2022 02:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646618459; x=1678154459; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=jVs09bTLbXhsTTwGzakM/Z2R4eSw3z2LVMnMqDFhc1E=; b=XrVuH8Tc0vV7SwZq3x4dbPgKMN53KeOUT3ggBmTnrT3VcHMCzsqWlt9F 8SVq2KmdsbMZtyr/Ap903domN8V0F310aeGqtdbO8WvwmJeQsfd97yrdQ iZhSLgfICsbgmcTo6ApzgqamifuWwPSZzUFi8Rf++BPzYZMNgldNqw60G 7evlSbRcNmfMzZaU/14m8SFlloNKPEe/cPdeAn8udlQDGKAfuULFGoEQs 7YKD7yFVnZVzYxFZRQvBrLIjlyRjf7dZ7ebSvnCI9xIk5MprQX2hxlpVc LtulBEc6ukyXa9O5WTcLEe6XDUKCMOeL91CWZZKQdGu10R2UkeTZC9zYC A==; X-IronPort-AV: E=McAfee;i="6200,9189,10278"; a="251854718" X-IronPort-AV: E=Sophos;i="5.90,160,1643702400"; d="scan'208";a="251854718" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2022 18:00:54 -0800 X-IronPort-AV: E=Sophos;i="5.90,160,1643702400"; d="scan'208";a="536920364" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.13.94]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2022 18:00:50 -0800 From: "Huang, Ying" To: Miaohe Lin Cc: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 01/16] mm/migration: remove unneeded local variable mapping_locked References: <20220304093409.25829-1-linmiaohe@huawei.com> <20220304093409.25829-2-linmiaohe@huawei.com> Date: Mon, 07 Mar 2022 10:00:48 +0800 In-Reply-To: <20220304093409.25829-2-linmiaohe@huawei.com> (Miaohe Lin's message of "Fri, 4 Mar 2022 17:33:54 +0800") Message-ID: <87bkyi7c8f.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 53561160002 X-Stat-Signature: 191gb7r9fepxfhebtiewz9f7og9ssb4z X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XrVuH8Tc; spf=none (imf08.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam07 X-HE-Tag: 1646618459-107034 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miaohe Lin writes: > When mapping_locked is true, TTU_RMAP_LOCKED is always set to ttu. We can > check ttu instead so mapping_locked can be removed. And ttu is either 0 > or TTU_RMAP_LOCKED now. Change '|=' to '=' to reflect this. > > Signed-off-by: Miaohe Lin > --- > mm/migrate.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 42e3a944f35c..50bc62d85eaf 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1230,7 +1230,6 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, > goto put_anon; > > if (page_mapped(hpage)) { > - bool mapping_locked = false; > enum ttu_flags ttu = 0; > > if (!PageAnon(hpage)) { > @@ -1244,14 +1243,13 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, > if (unlikely(!mapping)) > goto unlock_put_anon; > > - mapping_locked = true; > - ttu |= TTU_RMAP_LOCKED; > + ttu = TTU_RMAP_LOCKED; > } > > try_to_migrate(src, ttu); > page_was_mapped = 1; > > - if (mapping_locked) > + if (ttu & TTU_RMAP_LOCKED) > i_mmap_unlock_write(mapping); > } I think this is a code style issue. The original code looks more readable for me. Best Regards, Huang, Ying