From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD513C43334 for ; Fri, 24 Jun 2022 02:45:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A54E8E01BC; Thu, 23 Jun 2022 22:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1521D8E01B9; Thu, 23 Jun 2022 22:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0422B8E01BC; Thu, 23 Jun 2022 22:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E9D428E01B9 for ; Thu, 23 Jun 2022 22:45:33 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B444720CB8 for ; Fri, 24 Jun 2022 02:45:33 +0000 (UTC) X-FDA: 79611588546.02.7B5C013 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf31.hostedemail.com (Postfix) with ESMTP id B8C5420027 for ; Fri, 24 Jun 2022 02:45:32 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4LThLd09Mpz4xDK; Fri, 24 Jun 2022 12:45:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1656038729; bh=FsNPhLyLQp+amgbFWjLHPt/TWXWo4hOyqccddO50Dxg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WyfAml4Niz8W3LAIUYtA3TTVSHHKZOsJJJu5kLv4FtmDCD1eYxS+W4sEcCet1QKHj 0IMrTzdYHLZGaCGCRZRTzn4pxrV4fV/3/6M1lVzlJdYTu+jjalxzCTY+2i3+eWKUzV xO+/aq/1RKTo5wBveuVudeVekc1sx7NizVAbYz2xtDCU/0KcHwrtKcEqQ31ZNxLcCS jRsbzVNbIrDEAfOsy2MeQCb+/ZYsb3EBxlGdItXwiAKTMjRQ7iBJLsc16ATQxaogMb u+JKXyXS8U6W6ahPkXtSkanQFfcRa6CQ0yT3iPv/0C/AnD+wGZG35hkyPYQ9Pc0Xot 36vN0bG94jESA== From: Michael Ellerman To: "Aneesh Kumar K.V" , linuxppc-dev@lists.ozlabs.org Cc: linux-mm@kvack.org, Michal Hocko , "Aneesh Kumar K.V" , Kefeng Wang , Christophe Leroy Subject: Re: [PATCH 3/3] powerpc/mm: Use VMALLOC_START to validate addr In-Reply-To: <20220623122922.640980-3-aneesh.kumar@linux.ibm.com> References: <20220623122922.640980-1-aneesh.kumar@linux.ibm.com> <20220623122922.640980-3-aneesh.kumar@linux.ibm.com> Date: Fri, 24 Jun 2022 12:45:24 +1000 Message-ID: <87bkui6apn.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656038733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FsNPhLyLQp+amgbFWjLHPt/TWXWo4hOyqccddO50Dxg=; b=Z61w30L0E4cbzswH8Wee/C3Ln31BXu2hqmN9+QZkRESg3WU+oYdrxkbUUDuGPL+kD38eqA EL6Am26zUYM3tRYEmaI/eVQrFtiXYJhF8y6fqtnN9NCVOyYv64TP1DU+Lig0XDYuyuuGXH 7rDAsBUgwY9TB8KmHJHQ54MTdTC/f30= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=WyfAml4N; dmarc=none; spf=pass (imf31.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656038733; a=rsa-sha256; cv=none; b=eUqUp7N38SDgYj++aRLVw51tdTWmZlaow15l6AEtg5vQ2PJmz2JelfVwS6aaZJ2kSI4BYj 9pB/p9tZYiRmmaf06thscR2kDsj1YBDtvRcAnQqVwHxIVX5BBWlnwnrOsoq1gufuxksPze /Vi6zAn4KKEhyo0AsXNLiRQRgUrIjCc= X-Rspamd-Queue-Id: B8C5420027 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=WyfAml4N; dmarc=none; spf=pass (imf31.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xqku9qq14uickzhbgpt4qso8whsnpeyu X-HE-Tag: 1656038732-789068 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Aneesh Kumar K.V" writes: > Instead of high_memory use VMALLOC_START to validate that the address is > not in the vmalloc range. > > Cc: Kefeng Wang > Cc: Christophe Leroy > Signed-off-by: Aneesh Kumar K.V Isn't this really the fix for ffa0b64e3be5 ("powerpc: Fix virt_addr_valid() for 64-bit Book3E & 32-bit") ? cheers > diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h > index e5f75c70eda8..256cad69e42e 100644 > --- a/arch/powerpc/include/asm/page.h > +++ b/arch/powerpc/include/asm/page.h > @@ -134,7 +134,7 @@ static inline bool pfn_valid(unsigned long pfn) > > #define virt_addr_valid(vaddr) ({ \ > unsigned long _addr = (unsigned long)vaddr; \ > - _addr >= PAGE_OFFSET && _addr < (unsigned long)high_memory && \ > + _addr >= PAGE_OFFSET && _addr < (unsigned long)VMALLOC_START && \ > pfn_valid(virt_to_pfn(_addr)); \ > }) > > -- > 2.36.1