From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A86C77B75 for ; Fri, 12 May 2023 18:08:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 314C76B0087; Fri, 12 May 2023 14:08:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C5226B0088; Fri, 12 May 2023 14:08:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18D606B0089; Fri, 12 May 2023 14:08:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 079A86B0087 for ; Fri, 12 May 2023 14:08:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D0AFB140C33 for ; Fri, 12 May 2023 18:08:01 +0000 (UTC) X-FDA: 80782386762.05.46269F3 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf01.hostedemail.com (Postfix) with ESMTP id 2B2B140002 for ; Fri, 12 May 2023 18:07:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=fmEnlP+G; dkim=pass header.d=linutronix.de header.s=2020e header.b="KP3WEVY/"; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf01.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683914879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nxedla5WIOuVTxDfzDbD5hmB6vdEj1u0Wyu1rqHtvfs=; b=nKl6erIxAcYlpd3/pGDrDzDeOO1tHAkppchKTCmgBsRm6qgIr6O/ww3e+mx0P0wJAKlCDy E9FoEFIZyUHRaruR36PUneGI62k0EzR5I318tTpmbbXGxvHA5IOw0QpOeqNHA4zdbjfTK4 BWhZxBR3ur4/dC1stjQmyQjcGym6Xz8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=fmEnlP+G; dkim=pass header.d=linutronix.de header.s=2020e header.b="KP3WEVY/"; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf01.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683914879; a=rsa-sha256; cv=none; b=JAa7bk5CO4wMchItmfOVnnO7dPhxPrVqrax60KK3BA39c6mZ10W2tbcUc9ILcxhbH3RzAf Qy/sOa93xLFei++grYmMAbl6Lqglthk96J4HrPSFBoDJ97pDTgpIP3LMJO4RcILavjZzA0 C/fMbcCw1XSw9jZLm7XoK7e6zQrZ3os= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683914876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nxedla5WIOuVTxDfzDbD5hmB6vdEj1u0Wyu1rqHtvfs=; b=fmEnlP+GLRn3um3cql8aaV+i5MQmtHc0dMsuiC0uglKDo2qCdf6EtEF/viioXyadX9eM8p lz4iOAAoKjDt04Osljgk0/SeVzibUBRLcCBgfcKHL0ApU0oIskFwusZlX8kd63MGBA+Ink u84pSBAGm/SVoi1+6QSVz3y2xhKYazRW6W0OLsKYrE9eI71Xyv8TQunMHEdnIQK+olfGXe 0oKHRguXDHp/XiyVhvdVmvMF3bkGZeBOHITN+PcxgyCJUlMuIeuDR49+mQPG3WDmj+RjmX pyuPRsrfHd3osWEvFdSqlxOOMCI23TzBXyU9M8je9BSzL/ekbaqD+bDANU0kJg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683914876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nxedla5WIOuVTxDfzDbD5hmB6vdEj1u0Wyu1rqHtvfs=; b=KP3WEVY/OXcnilm3hs2r59d5+WyKUVR8uAWXxi25sJlhfFlMlLKlvFjGLZYjJ0kHt7n5qL wqMCjXOE6niCLDBA== To: Tetsuo Handa , Andrew Morton Cc: syzbot , syzkaller-bugs@googlegroups.com, Ingo Molnar , linux-kernel@vger.kernel.org, linux-mm Subject: Re: [PATCH] debugobject: don't wake up kswapd from fill_pool() In-Reply-To: <39c79d27-73ea-06a8-62fe-2b64d0fd8db5@I-love.SAKURA.ne.jp> References: <000000000000008ddb05fb5e2576@google.com> <6577e1fa-b6ee-f2be-2414-a2b51b1c5e30@I-love.SAKURA.ne.jp> <20230511204458.819f9009d2ef8b46cc163191@linux-foundation.org> <87v8gxbthf.ffs@tglx> <39c79d27-73ea-06a8-62fe-2b64d0fd8db5@I-love.SAKURA.ne.jp> Date: Fri, 12 May 2023 20:07:56 +0200 Message-ID: <87bkipbeyr.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: q75ud5rmkju5cwg1n6qget9gtccd55gm X-Rspam-User: X-Rspamd-Queue-Id: 2B2B140002 X-Rspamd-Server: rspam07 X-HE-Tag: 1683914878-961973 X-HE-Meta: U2FsdGVkX19iFnjFHjhIPy+mLXTXW/MnIvjMb+0VNAmQjEZ2hraMzAHpneA2yl0hx7k3K1b0yAIJi13IMkxAkjq0istcdcZsAM4a6mLY3NoIBnjmQW/66jSXDcK/D8x2OYynObZaPmb/bgdTlMyghvYCJmKtRnW2DD8L15AxlD6g/5HDIm9BhUM2KpV9W5uh1uhpHzq18o0KNo+HwjT5dk8jI7mmuoBg4OwlaWvxRIXF5lqhdn7R4+Uc1JkD4KaVd2FHvYhAHhZxykdGjJUQaPjqTJihrZnoEPlECqykchiNnsPF9/cw0gO0zrpAwoakZQt54coIxMoaCMFCEyJEVrJYvKr9tvk9HeaplvIJemrwBUNnzT+FJK/xxh8TJ2Rc7Im4/gsCv2xT4Qo0G8fEYdgQBqUVMLWAv5c5XgM/uRrSlIrrwHmLWbroSQOQPuv8Yhr79GRm9QkB6UUvh5APfowv661b0qGf1OxkjVkDAsN6xMrgtZtftUy32Vas727l7F56WykIU6o09DbtNDYoyQsUrT93kS3ckpRJGKL3EoP8mYGWU7npuHA+LWlPjiIMeo3q4Kp+xEg0lKgflhwNwlgF5UyvAVD+R023oK3jrTyUUYnzkpn/6BCqaqgwArAFR3YAdhq21r7b1LhPSQtbwsieflUI7wk+25YF9yAA9r+dAiRkpiJ2b8kfdsDeimuToAt3fGhOz7UcbLxa0dRs+a9YoRPCjUZuUbf6frqGve85tmtxAH3/sw+Nv/uFhqueESwMDQA12a/g0Y/YDo7jL5/vCC3tomDSOczq1DaKGXcLk6P3CUvSK/ZhrYjs1vovryR8u9+DcEp+isuT3V0MFvqeFKd+9Gbpyr/Uhndxst5A04PFXZpiFKj6cUS6DKQlBDdyrrLoYHDQ5IQ40ujmkwTJl7o8Chq7uUOiOvjtUC+LIM15IkPd85UBoaCTROJXWcAKn48oepwOY6MxaEU 5Lo4U2ej I7z7As+qtqqWX3twZpeWmuGpSs0w9nwc2nRQ01OMCs7Q6x7ZDFCOFxjU8pue+hEwBFrrZyXYXUhYo/9ElYESvoO7MRFdSBWEGPC38PXwZ1RQBK7DNlvip8WJe3v+1a/acHaeUUCR5fQ8daoFv6U2fPGfVqBca25x2pbyHrfdscg0CnzRy7EGr/T1n6WzEyTThqPbkHTwxq1jUDj4rbdVymdUlnGlwa5x4japF5h5v8HATle56SdNjJcKyww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 12 2023 at 22:09, Tetsuo Handa wrote: > On 2023/05/12 21:54, Thomas Gleixner wrote: >> On Fri, May 12 2023 at 19:57, Tetsuo Handa wrote: >>> On 2023/05/12 12:44, Andrew Morton wrote: >>>> On Thu, 11 May 2023 22:47:32 +0900 Tetsuo Handa wrote: >>>> >>>>> syzbot is reporting lockdep warning in fill_pool(), for GFP_ATOMIC is >>>>> (__GFP_HIGH | __GFP_KSWAPD_RECLAIM) which wakes up kswapd. >>>>> Since fill_pool() might be called with arbitrary locks held, >>>>> fill_pool() should not assume that holding pgdat->kswapd_wait is safe. >> >> https://lore.kernel.org/lkml/871qjldbes.ffs@tglx/ > > .config says IS_ENABLED(CONFIG_PREEMPT_RT) == false, and lockdep says about > base->lock => pgdat->kswapd_wait => p->pi_lock => rq->__lock => base->lock > dependency but does not say about db->lock. > > How can your patch fix this problem? It's described in the changelog, no? The main change is to make the refill invocation conditional when the lookup fails. That's how that code has been from day one. The patch which closed the race recently wreckaged those refill oportunities and the fix for that introduced this problem. Thanks, tglx