From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E04EB64D7 for ; Wed, 21 Jun 2023 04:08:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 008128D0002; Wed, 21 Jun 2023 00:08:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFB5D8D0001; Wed, 21 Jun 2023 00:08:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC2118D0002; Wed, 21 Jun 2023 00:08:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C9CAD8D0001 for ; Wed, 21 Jun 2023 00:08:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8E51B1C7E20 for ; Wed, 21 Jun 2023 04:08:32 +0000 (UTC) X-FDA: 80925423264.21.32592C9 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf05.hostedemail.com (Postfix) with ESMTP id 3EE6D100009 for ; Wed, 21 Jun 2023 04:08:29 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=aDwb3nvs; spf=pass (imf05.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687320510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NybcyVrJyjzc4xEipGmIejKULu0vywTwDgXE//RRvK8=; b=vbb/n4IAKvcYOAvEyIjdpZYVkTwjJMP9T8siXQdjgmSkuUR9JsCki8vZD2D60ql8R2HfFU Jspnb0KLOxfyocF41x72Yp28YiuUXdrmR+zrAKiagRNdtNTPW6sLsjUi1MKomlbclBMmlg +5ItmayV9jTEsmmi1JQWO6ZL5H1fAM0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687320510; a=rsa-sha256; cv=none; b=VRDJ712rgeSGd5AYb7tzUgyx2mdRnTqoFZzv57QEmUyIlM5d8FUvBdBgYfmwPG01VwGAYB Gx78sUoxNBcgZRAhMbJAc2TlZ9ZxqdCOLYjkykUb6ie7ytQqJmNP98iDTZMhI6wAcs91lN gc7znB020xeLjwTzGxfwVrAApxN2Xuw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=aDwb3nvs; spf=pass (imf05.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Qm93F3VZzz4wgC; Wed, 21 Jun 2023 14:08:25 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1687320506; bh=NybcyVrJyjzc4xEipGmIejKULu0vywTwDgXE//RRvK8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aDwb3nvsA+fYCbuhxXjY00uryHvszL1qvenMQeNojxF7hvt2oaN4l6cJRxs5igRCo Eqk8Fkyi/XzkVcbh+C3k7HUIQJEh54bXY/3rSBNMLzS2Q5erBQVxqPUuwN9xnK0wGm SqSZvXodPQU62ybWhnN8jhIhFV/a0ao5wdHkEhiOIg5z5OMz5Xo13HLBaAWQvrYigC rP5ulk1Zv7JJJ8MCBLZz8Wphp9tReITcMe+foR47y2TH79vHHped6atD/LxWG3OblE H3kTW6Z9R8g8fNLRheW87W+/k3RWW5xDXr1wtvE8H37HkI/iFBN+RxYs7+kiUZqRmM BRF75qE5brPZQ== From: Michael Ellerman To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: linuxppc-dev@lists.ozlabs.org, Oscar Salvador , Mike Kravetz , Dan Williams , Joao Martins , Catalin Marinas , Muchun Song , Will Deacon , "Aneesh Kumar K.V" Subject: Re: [PATCH 02/16] powerpc/book3s64/mm: mmu_vmemmap_psize is used by radix In-Reply-To: <20230606045608.55127-3-aneesh.kumar@linux.ibm.com> References: <20230606045608.55127-1-aneesh.kumar@linux.ibm.com> <20230606045608.55127-3-aneesh.kumar@linux.ibm.com> Date: Wed, 21 Jun 2023 14:08:25 +1000 Message-ID: <87bkh9pidi.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3EE6D100009 X-Rspam-User: X-Stat-Signature: 9gjz5xtuwrm1c9h31syq4ioi371ujboe X-Rspamd-Server: rspam03 X-HE-Tag: 1687320509-932398 X-HE-Meta: U2FsdGVkX1+BDuI32odgcyWc+kqUD87blHIVZDXOMuGR9GbwKY2BDeeDUe/rGvTCQ1Dk2tTYBf8jkMXgdh18Yx2Urd4v+u7ct1f9ZGQN0iK8CPCu7X9WJGCL8z8+yehtSupjM0Y20HNsH9k3TXM9tN3+tN6B94pRvVmY6OSn978osYc5ClTn9q6iFKACdLuc/IBeksRkiPyd5nR3mr+WShvWJ1fURC8DnrGYWcHDLMiWPUazZb9dXgOWpF8bOtQGmn5CkVc96vzDla8R6wJOIgIhfjk35ObY8ep4LWvMYK9/J8+l769CnGvAeOcfgJj28j4ObzsqcIa4hHGB26Kn7mMHyJbpmAXZvnAoyojIYXIDwqA05nWnDyq11uChn0vPFt+Hp70m0wMuO23Xj7UzTgE/7SzCx6jPd1qieHLvIKN1ydm4SFrlxBu0f2Q1f36mDXDPyXSlaDtnpAV5Rx1N4AViErC+blpDc4OLnrSPqnWlZuhVQvx6ZqEg/S8c8c8bztsGz8v9kt44KKn8aOznDHintlD5W3AWhHowNCszYbb49lp36HKGd3+WTbc5lINfJh4t+0orPXHd0KlrbbxM82JZchhMN3YnssZ4lhWt/3d2zubi7F4po+UnAeBzhrfdZCS1YlUBd7+4qo5FmNgT6Y+tmhQ9baCmOfzC7JwwhYFHxh5lpSiDvrenAlmCClCQf1xOvO49Cue8C53q0kNCjxoT4nKH0K3xkCnP/erm5bPPwwSzjhzxLlt4VWQ78g95bkcrJh1YguxuUdn2J5SqP9X30MsVEwIMzNeLuWeXJbxNMgFaIcF3VHqRUM66IOZyeytOLXJ4UtdazfXuns3P5XRGJNnF3xT97PPEf1ET/PD2uiTuGI9IojvZ4yDBJ+GSER48uVUdGxwZ/glvXpcKFKwj3/1m7LF14ScI/ULiNLaDuKWJZ/sXuEynMrWIHlEQsPA74Mxk+eAFv4QnXmI 62lF3uS9 OoucMgGvaTsZnG+1e5P1q+QYgifGGlD5foi5CQ7K3W+x6jRe7IQib1sV91fQLD8qi/41YwII44BxUEVyf82IukvypVgWNjEz1AdpBWU55iCvzFiEQ+fj5LGaMvsvKEOrwmdvly4b7U/D79KUPTDTr8XeRiT/HirbquIo7MHW5MchoMInE1rb9Wzo6iPEvsoH+BAqfuytrTNSg7WPV+jSvXTWHiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Aneesh Kumar K.V" writes: > This should not be within CONFIG_PPC_64S_HASHS_MMU. We use mmu_vmemmap_ps= ize > on radix while mapping the vmemmap area. > > Signed-off-by: Aneesh Kumar K.V > --- > arch/powerpc/mm/book3s64/radix_pgtable.c | 2 -- > 1 file changed, 2 deletions(-) This breaks microwatt_defconfig, which does not enable CONFIG_PPC_64S_HASH_= MMU: ../arch/powerpc/mm/book3s64/radix_pgtable.c: In function =E2=80=98radix__= early_init_mmu=E2=80=99: ../arch/powerpc/mm/book3s64/radix_pgtable.c:601:27: error: lvalue require= d as left operand of assignment 601 | mmu_virtual_psize =3D MMU_PAGE_4K; | ^ make[5]: *** [../scripts/Makefile.build:252: arch/powerpc/mm/book3s64/rad= ix_pgtable.o] Error 1 make[4]: *** [../scripts/Makefile.build:494: arch/powerpc/mm/book3s64] Er= ror 2 make[3]: *** [../scripts/Makefile.build:494: arch/powerpc/mm] Error 2 make[2]: *** [../scripts/Makefile.build:494: arch/powerpc] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/home/michael/linux/Makefile:2026: .] Error 2 make: *** [Makefile:226: __sub-make] Error 2 Because mmu_virtual_psize is defined in hash_utils.c, which isn't built. cheers