From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51812EB64DA for ; Sat, 24 Jun 2023 14:54:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98C688D0003; Sat, 24 Jun 2023 10:54:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93E7F8D0001; Sat, 24 Jun 2023 10:54:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 804698D0003; Sat, 24 Jun 2023 10:54:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7163A8D0001 for ; Sat, 24 Jun 2023 10:54:11 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 325D2803AC for ; Sat, 24 Jun 2023 14:54:11 +0000 (UTC) X-FDA: 80937936702.21.CEA41FE Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf04.hostedemail.com (Postfix) with ESMTP id EE5B240009 for ; Sat, 24 Jun 2023 14:54:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UgKmAECe; spf=pass (imf04.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687618449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D7g+FRDaeAI8ixLCzmuXVRHwm1AglsaMUJzJfx6Wt2Y=; b=CmOYr3u21XoZkN17GLAJgSwpFmtaSNODmAWc9l0FoH52jTTcFrrBrmXr3/sYCI/PvUD6KR /N7/F8K5+fuZvCNzXqTWHTMjS5LpnpNE3QwLr16kDcvDBNh8tunQxUbhQF1V+R6gfiewZA XTbbD4Sn9nLNtGjBhw9/TOOJZOUZMPY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687618449; a=rsa-sha256; cv=none; b=xaI9eJzoRTyokeVwy0nMZ67Q4HYS4MJzbMz3/7P724SFx1QE0jrJuZO9E/QdI//UaPAzQq dRDBiCq49LIsqmUJOeL9Yw4enVUGW8Yj/bCF69h/tLHQ7yQrCafl7AjebYEYqcEpxY6Lkg zbaNhV5ugC/i+pGqbUPd1nU7Z+ZGnww= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UgKmAECe; spf=pass (imf04.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35ODkYa9003767; Sat, 24 Jun 2023 14:54:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=D7g+FRDaeAI8ixLCzmuXVRHwm1AglsaMUJzJfx6Wt2Y=; b=UgKmAECet0kykicl12wlvPy1gTdm0rx6XTshuR1chkE9OtJb2isC86jWdfMzFPQrx4OU OmJeBvtjlBQ5TMlNDXRljWc7mWzQpscaog1R9uFvSQkQSlohyVQ88UfRjN1AWRpz6xFn nIgYfZDVAvkLx+bSAWgU0pwwV7H2c1tWHuL7Ie6k9jF77lmihGpfV6IezkYeWlpJQz8a TOOkIte1w1ZYJMXlalNxGpdxt6MhQyMkOdREJe+aedMO5VEMXE1X4StY1TTv1dimV31g 3f+Ao8R207ZPNWdI0DyAg+CgdOQ3l4LYHpvGbQ2PZvb36q5gszaYQl3/Alv8GZnyAJhF RA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3re1nr0tew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 24 Jun 2023 14:54:07 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35OEs7ee031053; Sat, 24 Jun 2023 14:54:07 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3re1nr0ter-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 24 Jun 2023 14:54:07 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35OEAE6n027941; Sat, 24 Jun 2023 14:54:06 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([9.208.129.120]) by ppma03wdc.us.ibm.com (PPS) with ESMTPS id 3rdr45255j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 24 Jun 2023 14:54:06 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35OEs58Y63635966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Jun 2023 14:54:05 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9AB8D5805C; Sat, 24 Jun 2023 14:54:05 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A5C858059; Sat, 24 Jun 2023 14:54:03 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.43.67.238]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sat, 24 Jun 2023 14:54:02 +0000 (GMT) X-Mailer: emacs 29.0.91 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: linux-mm@kvack.org, akpm@linux-foundation.org Cc: Yu Zhao , "T . J . Alumbaugh" Subject: Re: [PATCH 3/3] mm/lru_gen: Don't build multi-gen LRU page table walk code on architecture not supported In-Reply-To: <20230613120047.149573-3-aneesh.kumar@linux.ibm.com> References: <20230613120047.149573-1-aneesh.kumar@linux.ibm.com> <20230613120047.149573-3-aneesh.kumar@linux.ibm.com> Date: Sat, 24 Jun 2023 20:23:58 +0530 Message-ID: <87bkh4x661.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: kg3HHhc-9g6j57KimBoijtoX5N0vmcPa X-Proofpoint-ORIG-GUID: SxOeqCgfrfb1D7c1iwtVdLcQtZT-ryp- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-24_10,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 phishscore=0 adultscore=0 clxscore=1015 mlxlogscore=771 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306240137 X-Rspamd-Queue-Id: EE5B240009 X-Rspam-User: X-Stat-Signature: d9fb4xenjxt3d3jom1t7qoy64hei7x46 X-Rspamd-Server: rspam03 X-HE-Tag: 1687618448-25827 X-HE-Meta: U2FsdGVkX198bpPsKWLnh9h6K1xHgdKaDqKieQmUrGKoeQJVK5Qk5zpl3rHja5h0k0nwTvT0e5LxS40SXAgojIwiJXIr23O6/mgmbLzv4FrNVse4ZkcwyTHs8g3XtlPBK43XLHeVUGJXVxM3uuufhD278KRAEaY5PMyy50qyER7aw8sYT2A+SYJTmmr5mEc1FNq4pt5HWjxsSeQz5l1TWOI4VZBSEW8bym+OUKJ0bdROgH1WlqhC21RHJw+gXMEGqiwkqnOmrKCj2NAnYCdf60dPRdMIe3t9qzpfOvmTpTUvnTlhp7hwsuLQCOelQiXoiTrGAS8xNLzzILUG9wsyvAnCYMrVe6o9O9zLUDi835r5U9HOA5CuhKFlmEXzMHxEIItCErkCw2Yz0cpT0apTQDrIFwY3V8AVKU/IMYJ8l0MtNI+A7e7DHfTHUC3f6sB9cQsgVQaZpezJWXvBCTOlv2i1sDyYigJm3DuVrzvOx9/fpQQkFb3EBm08mMdSW6HiGDKOlCsJEnDN3fkKSaTyjNLdeVGFr6r/3+v9uK46Ek55nLyrrODTMmoNCzlryxeqjcrkDbVQSd0laaiE7QNZiUaTFCp2RDTYKHP1VjeUmGKNJpAKAfJRTKRHUkVnR5aUUE/sT8AYMJtnV0JpYMdEJKwi/viysbkmb2pMRax4LXAThPdyv+Z/H3e8Yi6epkVZ2Ya+9gs7AYuOYwWB4d4O3rpwI3mgdsH6kNdqhLBkFiI6ONGKvDBqWLInELdQ8UyPDl6R2xuOblp5U83hC5XpK7ZCfIEPkGTlZGoD5Qic1nb+lKKprcnZySHW1irKhe0VK5uITWlnskZejmbgvQy5l5LTC7Ye5z8eyc3Avw4P3YAKT1E/qBAFHLksRd/aSWhVviJuHpK8WzCU99KJVTaNW+wSBqCh6HhwvojQfcNj+K/nS3IjMVpJqKrkmsaMC9IGsaWHn3KMluh9I0cTvid QjdO9NNm MLLg62FEEzqRHbk3VSQXnx2CuWteQqiEGzUiqfYavySB6EeAQeNNt/mlHr9ArPapHZMPctOJF875Z5qBwbbvsSiP25PJZrX00P9aBSJlZT0U4zhRiZZkzolYMnro6MuikDXn563C/YLto6c9zdXo+0r8x8ZrfGFEtN0iK8POf22pr2D4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yu Zhao, "Aneesh Kumar K.V" writes: > Not all architecture supports hardware atomic updates of access bits. On > such an arch, we don't use page table walk to classify pages into > generations. Add a kernel config option and remove adding all the page > table walk code on such architecture. > > No preformance change observed with mongodb ycsb test: > > Patch details Throughput(Ops/sec) > without patch 93278 > With patch 93400 > > Without patch: > $ size mm/vmscan.o > text data bss dec hex filename > 112102 42721 40 154863 25cef mm/vmscan.o > > With patch > > $ size mm/vmscan.o > text data bss dec hex filename > 105430 41333 24 146787 23d63 mm/vmscan.o > Any feedback on this patch? Can we look at merging this change? -aneesh