From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2807C001DC for ; Mon, 31 Jul 2023 16:04:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 627566B00D9; Mon, 31 Jul 2023 12:04:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D7726B00DA; Mon, 31 Jul 2023 12:04:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C6986B00DB; Mon, 31 Jul 2023 12:04:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 386CC6B00D9 for ; Mon, 31 Jul 2023 12:04:03 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D6A04C02B8 for ; Mon, 31 Jul 2023 16:04:02 +0000 (UTC) X-FDA: 81072378324.13.CA7BBCB Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by imf02.hostedemail.com (Postfix) with ESMTP id E26A980114 for ; Mon, 31 Jul 2023 16:03:44 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=Drrxwcs9; dmarc=none; spf=pass (imf02.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690819425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t76V9ls2c8xjoyYF1+jcwVKxcijch8MBGbQhBn9hxGw=; b=Qy/SrBjdBHOP/D8/+kXTEdAxdFiSuX+eikte8JYJyigN206PislVdOowrAXnfri/QbbWyW mA+H/70MPFyKf+SSjvY9ad9Nlb4ZWuIVMLh+baWsvTQzE6gSh5xd0GWdwReWexPWqTu91m 1xa5g0m4oMLiVfr5HYTQV6tlEGKHMcQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=Drrxwcs9; dmarc=none; spf=pass (imf02.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690819425; a=rsa-sha256; cv=none; b=EagM/aUun8VrqcBrx5VdPVmZFg9Xvto1fnIUED8rIabgqBB6A03nhdy2RHex+hiNxx2eAw LlsyQpR03Ni6HQGz9jmm2e7aynZnh7WHFJ9kQpA0Qj3MQNtbz4uNG2VuhlXiOIo2C04D9M vP/haNRE1/V6sHMkEAGZ2i7ZWPg9CaU= Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id C174E2B0; Mon, 31 Jul 2023 16:03:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net C174E2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1690819423; bh=t76V9ls2c8xjoyYF1+jcwVKxcijch8MBGbQhBn9hxGw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Drrxwcs9FW/rnfjzA2yYZS/QeTp9EeVUwtl1BDfo5uoEujoZJwIr+021ktZGUFEby AkxPt3Mh2L3jP5yS3rJh79rTd5BK2NkUJ3EdtePWQ6i9UkquULjhSMFZjz99Y4LzB8 8s4kZH8gZOhAMJwGvEgmAK7kK37ujBxfpqN+IRURceR6q5JPv94l045bK884PKo2U+ TOmeeWa3cZ3zoCUHrKKyz3e43kTI3dVMPP/xhG4OXbxG4McKzjRG5tqHTK5bCbzyi5 0RUAuUju49NSgqhZhaOPKzGtTAMs10UYh57oeahbpr3Tcmj7Jj5ewAYB5Xn2L9mC5e Cj3qjeoIjLUeA== From: Jonathan Corbet To: Mike Rapoport , Usama Arif Cc: songmuchun@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com Subject: Re: [External] Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB In-Reply-To: References: <20230207114456.2304801-1-usama.arif@bytedance.com> <463c960e-1d3b-edc0-edbb-d5ecbf7fc3b1@bytedance.com> Date: Mon, 31 Jul 2023 10:03:42 -0600 Message-ID: <87bkfsdq5d.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E26A980114 X-Stat-Signature: kr436eduyr7qdyxsjxu5wnenqzhofsey X-Rspam-User: X-HE-Tag: 1690819424-253538 X-HE-Meta: U2FsdGVkX1+eq3IIUVUYZBd03f052vDPZqFSOWataIdi+ji4sfnTrb96IMINGijvLS2lVeePRWPCmheQSUWV5uBN6sgHxT0wYzKbRHfa+EpvTgVudDE7NZiKZ/QZ+RDBkgAVGMjWtn6wkHVZIiUpfQODpWvo/ZOJoIJZFatQIzvOf5I5j2Sh3eyoWznRKSTAwRSdOAKTElUKAngvKKEKdmHDM8qEGWQ6mC31w7KHmavPV06cdlbVTLtUtgln2kzRdyh3zr9rqcTAAlxItFPbu5WuJ/kUnBCPIHNaux3segoBig5SbcX9FMHbGxQytzIv7ZUOry0dMjmVXePfvw6xwSgoYVO5ttmWXTbhdITdIYH+2qAD2m8fc4nlHuaNZ4YTeU5p6jolGw1AJtsDt/tQUD2xW9YWRIUTjtx9cb8ufVta7W7SvOk40dCSyz7twtdK5xGAi80DSKQpeHKIbR54oODLX2/y5+cTu12xXDkz4qE6uKsb3TpeH2JpYsBCG5pSTGU44ppGk6PLPkmuSDXxw697lCDeNE5XIpiPAVS4/jmEn/DjVEd6XlzkF2kVrvUD88ESu2t9Lhw5uY/gZxNLIF3kF+BFeG65TJJERoE1BBzFO+XO+JOR9RBeNDvkLJx1oLHO9Tm+V54IGuCzdntmg/XB+GzAVHUxFU4RtWdlMN4jC850zYIWfL8L3orM6YpplgDNQdSvFc9ZBTpkoIIFqgK2RuJTbhLQtdd9cbeHbXmId6/o5tYEjr6Fdef175d9eSPV4g8Tkd7LQuXkhQ1XNfKrevMynu1STqPnHG4mvTYljRLC5aCDxfqJUCEYuNZtELdgWb26LwD5Hg00aP5NzACQXAuGIPHRpdyAsfBTZUN0Z0KbhlHQGSqkPFDTwjYsHeBg3t10emQ3ULg5nE0+kjL5qpLgyQdUlCP3OizfrzcCLr+NrTIDKuI9MxUFJGqIxq8nwYvHlbUHRLt/U6/ Uat7wyKx c4fOyO/pyuLGr3pHaQmhFnTRD88p8Gncvt3zclmA6m2C6Puk34JMJUm8rYXNg5iWHh1gt0zuZ4kiss31nbMoYn2P+SmfgyvJtiFtTdV/J9L5FdxzOL0ATFSiy3AlKybThnE7zw7ILt6hSeHSZzw2b604SQzw+S2awz4o367/WrCGUvm6v2OSLYRb1xl9mwlqmlsxihpfduk4KBDaor39re7su5j+hg5Xch6vsQqbbu+KG3Gpv562mhnBH+2KnDFTgIlFFNTKXfS/8pbSeANu0VIO5P0jgyJuH/8Ui8dELvuXGeQ4QdUpILKmf6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Mike Rapoport writes: > (adding Jon) > > On Mon, Jul 24, 2023 at 03:05:29PM +0100, Usama Arif wrote: >> >> >> On 08/02/2023 09:51, Mike Rapoport wrote: >> > On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: >> > > 1GB HugeTLB page consists of 262144 base pages. >> > > >> > > Signed-off-by: Usama Arif >> > >> > Acked-by: Mike Rapoport (IBM) >> > >> > > --- >> > > Documentation/mm/vmemmap_dedup.rst | 3 ++- >> > > 1 file changed, 2 insertions(+), 1 deletion(-) >> > > >> > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst >> > > index a4b12ff906c4..689a6907c70b 100644 >> > > --- a/Documentation/mm/vmemmap_dedup.rst >> > > +++ b/Documentation/mm/vmemmap_dedup.rst >> > > @@ -1,3 +1,4 @@ >> > > + >> > > .. SPDX-License-Identifier: GPL-2.0 >> > > ========================================= >> > > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many >> > > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more >> > > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are >> > > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page >> > > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. >> > > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. >> > > For each base page, there is a corresponding ``struct page``. >> > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to >> > > -- >> > > 2.25.1 >> > > >> > >> >> Hi, >> >> Was just reading vmemmap_dedup.rst for something and realized that its still >> 4096 pages for 1G, maybe this patch got missed? Dug out of the archives and applied, thanks. jon