From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B322CE7A89 for ; Sun, 24 Sep 2023 00:10:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 665436B0297; Sat, 23 Sep 2023 20:10:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EE956B0298; Sat, 23 Sep 2023 20:10:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48F146B0299; Sat, 23 Sep 2023 20:10:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 366D76B0297 for ; Sat, 23 Sep 2023 20:10:18 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 05ABF1404C4 for ; Sun, 24 Sep 2023 00:10:18 +0000 (UTC) X-FDA: 81269558916.11.3782635 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 56CBE180016 for ; Sun, 24 Sep 2023 00:10:16 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=N6FKUZ+R; dkim=pass header.d=linutronix.de header.s=2020e header.b=cCkfwObG; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf06.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695514216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=44ZfN8hP0QQtdpjF0Zc3c5fCB9l6TSMIkTAqwLspWJI=; b=HEo+CQS1WOXsaacU3tbhjkMPLVDB3dQ0qfcX5xIRK3xIqb6c/s+uLEWuwLgXGLiAIzpYDN i3F7g4kldNSNqym1KEqA5IZvkV8bdf+BraG4q0tTEBqbzJz8qJMzjCtVThlu+mrunrTYFi +mIvrgtZnRRgRpbxdZ7Lq4OqKUZv+fo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=N6FKUZ+R; dkim=pass header.d=linutronix.de header.s=2020e header.b=cCkfwObG; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf06.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695514216; a=rsa-sha256; cv=none; b=W1rTRlYBmJ+jNo01J3MOgoj698JOdbeY/S2WDjkzW/oXER7OomKc6ulUoxjrseb3Av6jeZ IfcmtbUsv+jsN33CvqPrEY+TO8ILRjz3QdPylaJwqBZ3U+rT4Ss8TkLmhgdNFTirVZ8AVg 7H7GLU8QR5oQnnS3s6It2x5WpKNuk4U= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1695514213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=44ZfN8hP0QQtdpjF0Zc3c5fCB9l6TSMIkTAqwLspWJI=; b=N6FKUZ+RXWbmWn4kurOuqfbKCsockcm4uIIYqu1EjGyzaHKzGVs1Qvt3F0D0wCFZ2+1We6 eYTCXK/9zRMCf2ri8uHAWrwLsQJhUeIsfUfoulL3NUK6cp5LRHuOoBW4NrhBSo+pRjLph+ hKNgEdzbJj8fRg5AoO43panmWiJaNFVKXSU8/FVISVLHY4LCy5GuHg7IGjgZGgddBQLoXi B9jINd4NPF53tELMzze3Udxt+G53x40N54THU9TjFRTNVFT/0aEENKytBO2OBJjG+sUuD1 v891yCL8w0AUa/JbA+yKqA6+6PEDPuhNbMN5ZoUjmnTxptfoqVuQYU7Yn2zpYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1695514213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=44ZfN8hP0QQtdpjF0Zc3c5fCB9l6TSMIkTAqwLspWJI=; b=cCkfwObGO6HxiffPrS9eGP21T+wj0v1EqCpCfgioWpayKQJh2nutRo46DfHO66bME5o73A 8ZmzqjjhX3sso2Bw== To: Linus Torvalds Cc: Peter Zijlstra , Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, rostedt@goodmis.org, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v2 7/9] sched: define TIF_ALLOW_RESCHED In-Reply-To: <87h6nkh5bw.ffs@tglx> References: <20230830184958.2333078-8-ankur.a.arora@oracle.com> <20230908070258.GA19320@noisy.programming.kicks-ass.net> <87zg1v3xxh.fsf@oracle.com> <87edj64rj1.fsf@oracle.com> <87zg1u1h5t.fsf@oracle.com> <20230911150410.GC9098@noisy.programming.kicks-ass.net> <87h6o01w1a.fsf@oracle.com> <20230912082606.GB35261@noisy.programming.kicks-ass.net> <87cyyfxd4k.ffs@tglx> <87led2wdj0.ffs@tglx> <87h6nkh5bw.ffs@tglx> Date: Sun, 24 Sep 2023 02:10:12 +0200 Message-ID: <87bkdsh1nf.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Stat-Signature: kfr8r9ukr1mzz6ozhta3kp8kp3wk6ojn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 56CBE180016 X-HE-Tag: 1695514216-279667 X-HE-Meta: U2FsdGVkX1/3nRY/RTY6fBduXzN/ucLQLuuYIJ4grHycFrz7XeAeh9GNRIO2Fo+8XfjVjnM3PdV6ghKtrQAoI4EuUQhbhEo+XM7ToT7JxXTdnaKc0lAy7abRMC/kH7w5bFiRUANRt+jIYDpqFPleQ4hdA6gNfQBuhFuYix+oAOBxbotJBUer5QFz1iG209ma1ni1S4Nq+VD08N2kU1nSxHC5KyMKz1uyl8xOCDPvF2Y8O4z8lhUw9YHfWB9miz5swUE5laJrgtcA5usRmN54fIW87vPFBHx+G9/GBqE9eAdDH0S1poYOq/NM9AQSHdQzbANodbTxO1KyNXmGNxQgH2H1kY8yUu1+lOu5u238fNpreV3OsB0ig67+Vyt4kwYs9Qm+RcHYWZ977M1UJxdTVXgULyU7ece4LqEIOXBGnftUhmYo5docl7ZjhEFmvQ9UqYJFIoFotH1/mFiB+aFvUUtan98Tkw7XkPbFUm3kJfesmmXNT/ZhkF8Fc6Kx1ON44xAxHKprB0LxTXE3Ktuwd9Wjo+7BMb7Fhi237vesM2WoxKdmJy7P02857MILXyH+Qu4a3hFMbe0pBkTNr00GOraKp5mZabEJNGcpH4Rb5gP2fOGY+HAPm5zvoal8KHIr94t14T1Rt+Vx5HiSLn6omPnByqN5ru6Ki/N3ktik9cVF4FJu9YP7bcRKDnCB0BT1KX1v9laNlej1k8c+JiwMs/H/mFtvwjqQs7gPJhav/S7OhhwcfPgQ65kweGtSQR+/ljNRIXAVrYm5fb4Tx/QqoeQ3EhmzojGdLAE8cIGwRIVVg5kzXcokFTZVGVCMoYh/YIdbhT0LelUgg28yfLMl/x277zJ+35wLPuhCY67TIfHLsGQqF7O7toUkHieewE7q79I5H4s9PVyrJBasYQaDjYfzBGxeyZwVZ6Rs9HmuN4Jjh9a1irQ7HLRZEihvLrsm5pv5Oy6s3nnaFtP/Q6r U0IopjT8 TFCDa5/OiWH9sGPgHjgKdQRsNgKr+nYwsnE2EQD8uAFZi8D+CDZ1pHJMOsfXy9xU/vmsAo/s9J0CBh9FASdOr4XtjnVA7yiXn665z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 24 2023 at 00:50, Thomas Gleixner wrote: > On Tue, Sep 19 2023 at 14:30, Thomas Gleixner wrote: > That's way better because it describes the scope and the task will > either schedule out in lock() on contention or provide a sensible lazy > preemption point in preempt_lazy_enable(). It also nests properly: > > preempt_lazy_disable(); > lock(A); > do_stuff() > preempt_lazy_disable(); > lock(B); > do_other_stuff(); > unlock(B); > preempt_lazy_enable(); > unlock(A); > preempt_lazy_enable(); > > So in this case it does not matter wheter do_stuff() is invoked from a > lock held section or not. The scope which defines the throughput > relevant hint to the scheduler is correct in any case. Which also means that automatically injecting it into lock primitives makes suddenly sense in the same way as the implicit preempt_disable() in the rw/spinlock primitives does. Thanks, tglx