From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D52CDB474 for ; Fri, 20 Oct 2023 07:07:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14E888D01C1; Fri, 20 Oct 2023 03:07:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FEB68D001D; Fri, 20 Oct 2023 03:07:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F304E8D01C1; Fri, 20 Oct 2023 03:07:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DA81A8D001D for ; Fri, 20 Oct 2023 03:07:15 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A2FFCB58A7 for ; Fri, 20 Oct 2023 07:07:15 +0000 (UTC) X-FDA: 81364958430.16.4D7E6D2 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by imf18.hostedemail.com (Postfix) with ESMTP id 2DC0C1C000A for ; Fri, 20 Oct 2023 07:07:12 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JYdnM3XQ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf18.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697785633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lr4GEYt4f58WqbVFhPAgBQkEcpzmvaI+h/TBB8rJpQ0=; b=c5WMJ1us+JWiEtyfSqsLyvUCNC2Q1AdE/1yaAS2SStNvjRCQiZWnzJtNf8fArERAAJo55n fElUUozhCY/zmghQJbPMf4d3xvaLsXh1YI65KARpfitLCXBTdR4qcLeIv5E1vzTe49o61P mE8zsgNSRx60s4s96T4rtxxDRJrAArI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JYdnM3XQ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf18.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697785633; a=rsa-sha256; cv=none; b=kuX9ouy3vG0wJ44aaPHV4E6I5B1KWCmtZs+QIXFpI7zRxBw96f6G1q6FN7yG45PP8+8MlY numqrurLVB8zs5L9XtGhhvMcvJJX3K7Oj8fqu29wX2OwaQGGdlNyfDDa6bDjDNc5G1MlOU HcWwICSFj1hWc+s6EIkEMDYjOTVtyZ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697785633; x=1729321633; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=CCFoTDB8ylKFfO05W29LpXk6BHd4nA1Vr+D31rPLVVw=; b=JYdnM3XQwtoInoQRBk+GFVDRb74MQQTf6zUfFVbo8/isHO4zGwjCW7k7 IIvREkRM2V90raxjw9epck2UmWLJ5vDPuSfr1+Ujb1Lj+Dcta6wlOemT6 w6A4s/7FOSTewOZlYjbnuPaqFTKaPekVle2ZCaxqiyQuY+Dav/qFzOwp5 HP9D1dXEHNmkXZJ6viQRgrRqS0XCVdcjFM+a5a9JLoJZSWi5pjIP4Lv+x AYg+VCp4WdbZQGdelqiutJI3dyG+FhW46GEuOezIBnid7FjHp2ZKcq2YH qg0LUdsBt2E/41C4Mqvx2iSMKDPug6t38j8T49ABksNaITK2qEFJK/jbO A==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="385320330" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="385320330" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 00:07:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="760951128" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="760951128" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 00:07:07 -0700 From: "Huang, Ying" To: Qi Zheng Cc: akpm@linux-foundation.org, rppt@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, willy@infradead.org, mgorman@techsingularity.net, mingo@kernel.org, aneesh.kumar@linux.ibm.com, hannes@cmpxchg.org, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 2/2] mm: memory_hotplug: drop memoryless node from fallback lists In-Reply-To: <9f1dbe7ee1301c7163b2770e32954ff5e3ecf2c4.1697711415.git.zhengqi.arch@bytedance.com> (Qi Zheng's message of "Thu, 19 Oct 2023 18:43:55 +0800") References: <9f1dbe7ee1301c7163b2770e32954ff5e3ecf2c4.1697711415.git.zhengqi.arch@bytedance.com> Date: Fri, 20 Oct 2023 15:05:03 +0800 Message-ID: <87bkctg4f4.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 2DC0C1C000A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: djk5acft943h56gpmoypnxqw5f4nbppo X-HE-Tag: 1697785632-698727 X-HE-Meta: U2FsdGVkX18/RJkJhi/X31XrfCZ3xe9r11K8XOmF8R9Q8+qeHxjHejUqDllOVCuOLJ8Ci5lhYm3gehlbIuCx1AKs2Qxr7XblJg/kL4u8V/MFzUYPQyYFUuaiOLAy8Ps/IV0SsTnzVc2D0g9+0Rfn/ewM7z2zoGHR6eqdHeAOmurMg/QQjiFqZKuKDyWVnRkAr5WKrPyyaMrNllAzBO9f/NEHM6AMRf0Lml+G/6dJfekR1h5E+vt4UBtlZszDxh0uWevsQ5DIszO0f5MDpyuSlWGcO6BPcdsLrp9ACx3pYpfbNu9ohwbH+xunSeSzGSbFmA0px2z8mSlJb4yAWb9Nc13lEyYWpH9EpQwyoofGSgammP7xUsECV/sZgK1VanowepVkqzU5pxeWgdqYBL01Lkvgk2H5ylf+nxqt5Llu2VHx3BlXAmApwr8+OGhoAufds/zWleqG0gbrcmHRfVUv0jcOuFN3Hee0aRkz68CJNrOXcUhwaXcK/vTSuMooRo5xxUqoVS3xOqtf9++4zpO6Y96MUVMVEcBsqTqIiCQN8bSXK4X78DsE3AMIjvQwjUli6Sir6H/h+bYCQ94g8WF8EmWGPEo9VgJme5pQkckPJCbb5QMFsz1wPi6stKEyP7dleZO1fcfrNS2b5o4gJIa+cM+OgDK72ZZMQAkqQRARE2AmkeNI4ng3sXQJVDYO4pKn/kY5WtPs5CJtPPy5kFdrT1ODjDIhCCcTyVa4/0MKP7qRZZvNOG60AlgCl5mff27aGQFx8jpHPwVc9U6vQb+o+ktPAL9wMEDpBInbXMKYkMogwhfrnuLIqKKpKKoBKFvzkwELdmuiD59ll+e8Gf6PY2tM02mGds4wGtsH5qmFD5FY3jqJuzsSlom1rk0SK0Pl8youW5S+rUj9taVkCIdiV5M5GTKTFpkZ5xRVeC6YwNGVIZGUAkfuMLCOwP5T8ftPyzoZQQYu47g4920ATOX I2b+cLdd kS4TXFDciqgX7X0ulMx1y5EmtnMTMSODVNv/mZjRulHvbFXG2BOGWGd2y23C7xI0cCPhWLvtFBCsfUIIwHXYwKRduZA+7OE01uxQbIAOBvbJ/xLmXCPyHZ26DH01FCcvDMBuCIyYXo+LA5eY5t3jvh4BMsFrR9/qq6UBrFZkx0DoIf9ZcfkLqTXceK140YVEi3LtgY3rfM/+c9WAPCeHaUK/yzkcXy7EmdYx0ALruFFq5QtSaYUWXhf0y6jpdmPpJmsvBBriJy8YdZCQPOXn2jdYVTg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Qi Zheng writes: > In offline_pages(), if a node becomes memoryless, we > will clear its N_MEMORY state by calling node_states_clear_node(). > But we do this after rebuilding the zonelists by calling > build_all_zonelists(), which will cause this memoryless node to > still be in the fallback list of other nodes. For fallback list, do you mean pgdat->node_zonelists[]? If so, in build_all_zonelists __build_all_zonelists build_zonelists build_zonelists_in_node_order build_zonerefs_node populated_zone() will be checked before adding zone into zonelist. So, IIUC, we will not try to allocate from the memory less node. -- Best Regards, Huang, Ying > This will incur > some runtime overhead. > > To drop memoryless node from fallback lists in this case, just > call node_states_clear_node() before calling build_all_zonelists(). > > Signed-off-by: Qi Zheng > Acked-by: David Hildenbrand [snip] -- Best Regards, Huang, Ying