From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B31C30653 for ; Fri, 28 Jun 2024 03:14:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D47BF6B00C1; Thu, 27 Jun 2024 23:14:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF6CF6B00C2; Thu, 27 Jun 2024 23:14:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE5756B00C3; Thu, 27 Jun 2024 23:14:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A10916B00C1 for ; Thu, 27 Jun 2024 23:14:40 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 521791C10DE for ; Fri, 28 Jun 2024 03:14:40 +0000 (UTC) X-FDA: 82278829920.04.972782B Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf07.hostedemail.com (Postfix) with ESMTP id C63914000B for ; Fri, 28 Jun 2024 03:14:37 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jhkOQIy5; spf=pass (imf07.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719544460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MvFXViV85rPnLRzVEE1iw4nTYDh7apPTUx0Er/7fwbk=; b=jGldgpCEd4yoplXrhTKTitHJhK7rSxeCZnsniXcJiqrhjLTmqrPwr3ACfO7+5FiX5kv4b3 Y6hlzdg+f65hrjLhMayhy7E4FmF3AH/LVF0M5OgoBYAsDe9QqkxEuErTQZa/ruF0xxoYSE /9GCFHFsX6+d97foTOmUQlspDVsSNWk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719544460; a=rsa-sha256; cv=none; b=YQOMoizzllMTMJBF4BrJvwBuzkke6sn7xQHhIgLUeMEZNNtdJ8lcbGpT+xUmwVKUYrzp/2 lCwzZuAid1O/7+cSv/uQ0i5Cg5OtbQxb6f4ogoUGmT/92+fzrwiL5BhnN4HqFALRSlVE1L 6CLeAMR5XIS3DMVFH7agQYtXkYewy94= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jhkOQIy5; spf=pass (imf07.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719544478; x=1751080478; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Bzq47XhevB6u5PJXXfvJm5NF4hcYGfBkxsvTtTkm0s4=; b=jhkOQIy5ixbQVIXyP+fN2XtypSshRG1Ue5vadU2EvkjnchtJAVQt4hfc GdeqNlGl1TY9qnR9rxIjgqPET3bW7E16KVQEd6H0Oa2ravZ4jImLGIje9 H7HLDeebnx5HrLnk+cKrweSFmJd1rh4hAxPOAdM0WcJ5pMfHZOZZHNfkf PV0PILfZTp5BTb3Ru/R9kFmmR/bN++4ocev7NSZ2h7im5jjVRYzfUtTf7 RpnxvOY7MIXbTh0H/OcaTLlBe8TuRrP4ztZKhZ8wgDA7Gbzdmy4cP55iW v+JX+Ps63CkXQDZBskwwuDd5IoZUyal0m70cd/svvgxfiuf2+hAGTpQbj g==; X-CSE-ConnectionGUID: BTio1b6RQzuHmGPLFR1VcA== X-CSE-MsgGUID: C9FPbGxIS9KWOIuoxYsXcA== X-IronPort-AV: E=McAfee;i="6700,10204,11116"; a="20586203" X-IronPort-AV: E=Sophos;i="6.09,167,1716274800"; d="scan'208";a="20586203" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2024 20:14:36 -0700 X-CSE-ConnectionGUID: C5ITdqycQzubiTvSB+KJKA== X-CSE-MsgGUID: nj28SOedSDuH1xIg37Yopg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,167,1716274800"; d="scan'208";a="67799095" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2024 20:14:33 -0700 From: "Huang, Ying" To: Matthew Wilcox Cc: Tvrtko Ursulin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, Tvrtko Ursulin , Mel Gorman , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes Subject: Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode In-Reply-To: (Matthew Wilcox's message of "Thu, 27 Jun 2024 22:47:49 +0100") References: <20240625132605.38428-1-tursulin@igalia.com> Date: Fri, 28 Jun 2024 11:12:42 +0800 Message-ID: <87bk3lpxp1.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: eocwh1gqmbgnc7pyq6na6dcycpcs3kcf X-Rspamd-Queue-Id: C63914000B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719544477-234755 X-HE-Meta: U2FsdGVkX184nGBHe7zRAAoQ+JhCH6gYPwwKN0qJ91b7Bpdv0TLkhoSDeLxL5G3kvBn2mpnNyQZmPJYYpxjbxU4eylvFvHYGe3U6TukGA2Za+3xai34DkMIYiRh2Wiw+SZM3eW6UWojVwxSa0uKt3Pghku+trazHAiNzdEW2Xz9m6Afd1avdUgyl2PRrMtGzT9HksmROlQlVLuOBGy3DAzvOOCDKKl2Cqc2ro533Sxor9Mu87HN/z8grjs07Qk29/MqI4xccD3Q/+xCGJNPxB6hsISVj69hgh3wX8VjDXZMXfNqNHFrB9vdqKxqWLv0P/fTEgVG4ag13EeDg7AgG9FddGMzf3e+te1gIfWEJxl5dfe1HmMWrnw6qCza6e/rkjbr3ICjZpCivGk4udZahkVo/m+FuAbpnC+xLElciVpRtbVB6wCd6FYP1q5N4ysebCc9W3Nvxdn0tJ5AgJUvuD/lWjZZCrDLZlNBnEba5wOsEspMe02XcdFByqino/F0qc3IyoGH+PuKSm+R8QYHIpaC2zfqXDEueW3rpQn3yX9hsmn9/dPBZygoHf91C7bshko4yZwCLSGP9EkiOSnbO9zae9Es9w/CWtoLH0K7S6/V3OjpA43xyZfa9aPexkpwC3Yc0wbV8t7vZINyEeZ6Q77PHvXLNkkAIOspEtuBd/Hxzt89kMqM1kfmXJ1Gqnu9FAAQ7Jx/KEM93+cVXsadWwulXVWL/ZyWsu7OvYWxc/UzA5SIyGhPw/djT/Lf8ULj7EJKaXsydiKuJDcyL1FudaiDlFsryfxpYe221taMbXOKA4EI0iHNLAZQ2NhmwJcbk9o8qdxlKclZw7FOzsyvuMg6kr7jviykgxgEFW5129ykoORa555GnmJCxdFVowFPUV1D+41Htc+nG7eDWpNv2QH7J1Q3foIqFQcNudZLn2KrlmUE/UdBUiEzzcvU4x6yUl34qk6rI7kWF+8av3RH NSZqe2B8 r3Tk0bGYEHWNNFGSlH/Ppk0YpBRKbbemzjFdEEJa+swv6MjIYEmBOOriKFAZKAkJwM5NFiwhRfIOemwgFzTLJt1cTuy/iVcObFKzpRslul8TlI5v13Z4JKmOGhq/aj5ahGAFAzLoQuMuEpsW0cjetuNa11kP/PeB6QA/02op+dzEncCc4D1mjgUy261KUpXayLCsJ+WBhUWgA9e2DalzvoiP3li0+KjH1JBkMJVOWEFKHxv153GSeYsPnNDabjOG/a1s4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Matthew, Matthew Wilcox writes: > On Tue, Jun 25, 2024 at 02:26:05PM +0100, Tvrtko Ursulin wrote: >> /* >> - * Currently, the only defined flags are mutually exclusive >> + * The below two flags are mutually exclusive: >> */ >> if (flags & MPOL_F_STATIC_NODES) >> p += snprintf(p, buffer + maxlen - p, "static"); >> else if (flags & MPOL_F_RELATIVE_NODES) >> p += snprintf(p, buffer + maxlen - p, "relative"); >> + >> + if (flags & MPOL_F_NUMA_BALANCING) >> + p += snprintf(p, buffer + maxlen - p, "balancing"); >> } > > So if MPOL_F_STATIC_NODES and MPOL_F_NUMA_BALANCING are set, then we > get a string "staticbalancing"? Is that intended? > > Or are these three all mutually exclusive and that should have been > as "else if"? Yes, this is an issue! Dig the git history, in commit 2291990ab36b ("mempolicy: clean-up mpol-to-str() mempolicy formatting"), the support for multiple flags are removed. I think that we need to restore it. Done some basic testing. It was found that when MPOL_F_NUMA_BALANCING is set, /proc/PID/numa_maps always display "default". That is wrong. This make me think that this patch has never been tested! The "default" displaying is introduced in commit 8790c71a18e5 ("mm/mempolicy.c: fix mempolicy printing in numa_maps"). We need to fix it firstly for MPOL_F_NUMA_BALANCING with more accurate filtering. The fix needs to be backported to -stable kernel. -- Best Regards, Huang, Ying