From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09140C52D6F for ; Tue, 27 Aug 2024 05:47:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90BD96B0083; Tue, 27 Aug 2024 01:47:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8949C6B0085; Tue, 27 Aug 2024 01:47:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E77D6B0088; Tue, 27 Aug 2024 01:47:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4CED96B0083 for ; Tue, 27 Aug 2024 01:47:21 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 94E2041656 for ; Tue, 27 Aug 2024 05:47:20 +0000 (UTC) X-FDA: 82496942640.04.AFBB087 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2068.outbound.protection.outlook.com [40.107.212.68]) by imf21.hostedemail.com (Postfix) with ESMTP id E7D5D1C0006 for ; Tue, 27 Aug 2024 05:47:17 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Ckbbs1M4; spf=pass (imf21.hostedemail.com: domain of apopple@nvidia.com designates 40.107.212.68 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1724737594; a=rsa-sha256; cv=pass; b=2kBimbXURl1d5YNrSEZexw97TMpv1nhrNH8IGSN5fiVpVth8aZmrsqEgccCXPz5iv7onpW M6bMaR+SPv28SNKsaNdzAcBzts9HWa9os1H4w3uih3Ulf6U+a2AsF7x0u1FqJiOm88l0Ok tjWpm+jnySfi/+Z2sIsMjZHrdcIVfsM= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Ckbbs1M4; spf=pass (imf21.hostedemail.com: domain of apopple@nvidia.com designates 40.107.212.68 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724737594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=POqbZT2w7tUHnLp3Cn9n3EyIMZYWy9hTVejA9ybUotk=; b=iFsE/gvwmDCrogLmJxvx2aOOMYmKQBzacxTLac+6YJbhD0YDjf/EOieLbRfXjuAki0dZ8U efFg0bggkQKG0mEYjVeNCpdB7B/HN/Aj4HbGC1nh8olSoQQTrjQIQiFNkyHjN4Ewb9pFxY nVt/Ip+YHmo7Ywol5f8E2jftRtIglqk= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z/4Yb/Y9xwPq+WCFVkJNM9wiif1X/vrPkfrQIszfXfXaGYDOlHlEqo2q2+dS/0PNs+OQFXB+kZ+0u+vbIacwRLEB3HTrqKtAIEguXIY1bSzu2yCnsNlrP5nCU4eNpesNk2SkPwsn80tZLjC80ddpVuhcmf/ufrWm/1EYOTXVxDUfvyigg5oLJA8zgON0x4Wy2PFjz+Hfb9kR8l2NVVYNgl91wLv+ttIEs5lItnK+wPqKpBnDLeF5ZQwQP9GMW5Fx53CBtaQOxw/+7tQgmuLvN0JaGlEmx8+KHrUm+yxzaVYiwsl2QVOHuDpcZd60v+gbWCcT9b1FNiQSJxA/Vhhn6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=POqbZT2w7tUHnLp3Cn9n3EyIMZYWy9hTVejA9ybUotk=; b=HkF5MbFQhODotSfhJvCzagKguwmucQxhiW5jjh8DqGaiWqkhMwcOf2MN8aUMp2cSZ22ENRAHuto4gxrBA149sqY0q3sBOl+uEFAv7OrT+8xr+5MB0mNgo9dUCnEH24PIuKUzRV/V8dXQRFKKquZ7o6+OXX9U2pMELqGs/V6v4g/2djOlNpmxhiIqwnXgrv1bTzmc6tpucR1aTXQAFfYl6Qd+ef3iAdgBPPedpCUZ1eCS9Z1/naGrMCwHaALf2ik8lqePr2ygSyuz7AOfxLC7UOEuuNZV4NIPnY5LZP12q3IFhKQoEP8KRo0R1iB+wE9fuaIXbKo/ZcNztkBkoChBOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=POqbZT2w7tUHnLp3Cn9n3EyIMZYWy9hTVejA9ybUotk=; b=Ckbbs1M4mLFMyt/5d9NxX6yRBnDbNKGXm1Hv0GORjm2IQ6wOsiVncfiLQk+ClUdYsJaFaqb/o/dCzwnK58oFZG1xEIG7WCwGdBI9q5nWQMBFuaqnG5bTfc+7xWCdtiHPftfuCE1kN6qMYFo0FlOa9A0CTPxoBTTtr5ynVDKQ6NWcEDEgXanq8YYM9RI1a7A9qe7B8F5Ix3nVYsBKw1lQ+Afh/0Y0yhZXBYUWACEk5DGarunAuIT3qNBEo/7UEn+5B6VXAODN/GbnOZ4bIx6t61UjBUEgug5vqevOOhklSm2LagkC+0PTbvrcHDbhBfTlrpxhEN4Lsf/rCRMgN0oa/g== Received: from CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) by MN0PR12MB6272.namprd12.prod.outlook.com (2603:10b6:208:3c0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.26; Tue, 27 Aug 2024 05:47:14 +0000 Received: from CY8PR12MB7705.namprd12.prod.outlook.com ([fe80::4b06:5351:3db4:95f6]) by CY8PR12MB7705.namprd12.prod.outlook.com ([fe80::4b06:5351:3db4:95f6%4]) with mapi id 15.20.7897.021; Tue, 27 Aug 2024 05:47:14 +0000 References: <20240826065814.1336616-1-wangkefeng.wang@huawei.com> <20240826065814.1336616-3-wangkefeng.wang@huawei.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Alistair Popple To: Kefeng Wang Cc: Andrew Morton , David Hildenbrand , Matthew Wilcox , Baolin Wang , Zi Yan , Jonathan Corbet , linux-mm@kvack.org Subject: Re: [PATCH 2/6] mm: migrate_device: use a folio in migrate_device_range() Date: Tue, 27 Aug 2024 15:46:56 +1000 In-reply-to: <20240826065814.1336616-3-wangkefeng.wang@huawei.com> Message-ID: <87bk1ejz4x.fsf@nvdebian.thelocal> Content-Type: text/plain X-ClientProxiedBy: SY5PR01CA0034.ausprd01.prod.outlook.com (2603:10c6:10:1f8::19) To CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB7705:EE_|MN0PR12MB6272:EE_ X-MS-Office365-Filtering-Correlation-Id: 5497fe21-e6d7-46b6-dfed-08dcc65bb435 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FmeAzj4evgcvmz4KRx1/gYxcuSOE0ZOxuNqhthE4DKIyCqk5jTEXMM+o3xjM?= =?us-ascii?Q?ab10KE7ECN5lwKtd5FjA9IbzP5YeluUo4tmRL5yex3Xu3H0SvEJkMOWyvFP6?= =?us-ascii?Q?F0pQbxhOh6fesZYl129E1GZf8vikZR2S2vk7oGvWlSeqVtO+xz1gv5M3Sxyj?= =?us-ascii?Q?L27cbwW2+G9Rl5OG092q8OTEkXdSyjuCt47EQ1xnlQ7vMBw22LXfSzoNrZYm?= =?us-ascii?Q?UayOOY/TG+jQoCiE2Z0BW0ksqGvrl+/ofNA8T1FBlBTT/ESOC0gkFAvBfi5n?= =?us-ascii?Q?erwWZFWJi5SjJbSSiRqYxdrx90Zh+fYcJ2N4m9w93BDXh1kGqtliQjH3zymT?= =?us-ascii?Q?URJc1skeMFFAeVQASgwCibODU1zZ2tGidNKeR33hNB82lI8/cWY1funnkyVY?= =?us-ascii?Q?OCTI4/zSKZSDPv7PPiJPeIPqdaLCsmv7btCK7et2DusqGoEMwZjq9giaaj9O?= =?us-ascii?Q?Xh6VTPhRHYIfgNbRqbjKrDKRjTIRenAqzfGwxnWlcc3YLz8qWsfUWSz5ERx0?= =?us-ascii?Q?+10MRrMgzBUSh1GWs1xkdt/EejwhPk8WbEIQ9Pt8aY8lzwJg3UYu5haJBGtB?= =?us-ascii?Q?bYy4/oeJqsA0Y/8aw1kK7H9nr/gygE2FKMBUeW+cpVf5Wv+QAwo2Xb8pf81w?= =?us-ascii?Q?S24/9/JtmOaZRYq+XJBrAOKMnZtzXjrsV1o3gSFmWkUcyGEhg4iBMh6Zv3lZ?= =?us-ascii?Q?r6JO5eyzCcj0iasbCrhsWDqrtlHBAKJ9y/I/VGMSVxl52i9E6UXKkHcnwfNX?= =?us-ascii?Q?ItCK18Axq73lJqF0twBythR2uzukx/ubPxSK8psvaIZ/d5yyWeASe006hUbl?= =?us-ascii?Q?q9y5fB3pn1k8vLGIgq6fpiz/8emg3VWICW/kfpsa94NWb1aowuZS4L8Vq6Q5?= =?us-ascii?Q?FMYVa96p0izZh5NzKqqRtjt+7hnpglZAoKP59btxPETJ0ipqfz2KkA34rfw4?= =?us-ascii?Q?CtIfUO3ahaYkLbNv/VMH34LKsN56/cD5CF48YgdRWH7BofgB+SY4/pEgzRvL?= =?us-ascii?Q?n8JSXeQxBkU1HtmY0/vmptRu1KIMw42uJwGLePIZ2Zdrpn2tgMkHi0o+sr4R?= =?us-ascii?Q?9eqbeX5omo3Aew1TlEn6D/D4o7tZnfVkGPm/NZ2KKQANtbOXYMDd1/MIDJxM?= =?us-ascii?Q?pRnfmFuQPv8IvrbbBQq6difZWPA1Bm3pNDLO4fI2Ul15H82gu17fWjJMiVxf?= =?us-ascii?Q?LS4h6Y7DJLI7j8pExbL2MwFqlmKZxLf8OB+L5i9llVBV5fEAqYTtU2b4azJf?= =?us-ascii?Q?yhOIVwkIEFnxhXuGruHaJjCjaBeGvj4ra6FSPeNyIN3AqBT7i7hprT+UjWeK?= =?us-ascii?Q?46gYjSapsZizFtZtM1tNrH8bXTAV2DcbdqxL2+YGbaR8aw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB7705.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8TOdCtlBoSPA6Mk/L0u9S66UxgTDvpONo4VcZt22TN/1VXmQoK3k8x7p5I/G?= =?us-ascii?Q?Dv2gVmwqjk5vFFRWAyN5koMgydkEZpD46+qDaskBXxBKlJ9zET/y0l906DYU?= =?us-ascii?Q?nwy7GQgose2VvRBxwr+qP4QPnOiTCh/eWAgnAVSiAuI4pCoTpGMHg9rMwlLd?= =?us-ascii?Q?683EY8YkZeac2DJckpsxnsoMXSw4X2E7bHo6EerAXLl+1V5NM8soWMiTAr6g?= =?us-ascii?Q?tzzgRNFeJZmY4XLNv9K6Y0wKvql/IjmZ7jTVx5XPO0IGPMnojBQZclsRInq6?= =?us-ascii?Q?IL6IUJ2WeQCgryn98abYrWGWTMmtpGYkrhftWX9/1ZqZPOXrkrBMMvcvmyVG?= =?us-ascii?Q?mbv3oOVMZJqeE3o/kMM12215x0HWCfZ57rXzYk7DtH5Hlh/AnFuAouWOpd6G?= =?us-ascii?Q?F738UKStSqwIHEBIs52JxTAEWuoYO7feVRR+9Q6OEt/EGiFKYsyn2EFX0sUS?= =?us-ascii?Q?bl2srlpedp7wG1h6W3TuRFrK8YZgSbUPpW0Oj92D4hg8TgZzTQV+JuijE3Y6?= =?us-ascii?Q?wsnzWJGAfgF/Aj2v8EfLS6JoZeeKObz5Cxgdc0jJ4F7G20nE1QEV3iwayHzV?= =?us-ascii?Q?n9OEm9bUbK7qBy6o5AbPu3dtMy2VPS8E8FmmnxursEb4dnWfNoK+nhnVrqtN?= =?us-ascii?Q?nKtnyI00DPjvdxPf61R/u/XeZa8VFV5cZbyuVaotz2z0nAukp22d5pfkymze?= =?us-ascii?Q?tM9RSP6hWPMOym4pl4nLIPC0bDG+7IR5vH0eHBV/z7ggrpxNcrgiKQkFIsjX?= =?us-ascii?Q?wp663N6dlJcgGRrTUX/6JJD89JJkGmJgOh/QOSbSgo/syBs/1viJGrb8oIlJ?= =?us-ascii?Q?OXDEG2d4Rx2aCkPwyDNdcr5HAywoWmBtJtnypc1u4pmjqrErqFhwIA4Tm+JQ?= =?us-ascii?Q?Z/plXPu7ANI8fE2g/7ruEBnIMwxrP8zm5+4BaZBza/fcWZmMw1Wum3zgrRWY?= =?us-ascii?Q?iQyylTogKH3lYUrFVfc0GpjCCIbUH+OAgU+31Iu6MfcwMqPP/A1SCgcgdoCK?= =?us-ascii?Q?x+QWUq42FW72qXmvTuBgZR1R0Q5ePNFFa7dNkbPt10eq+nH4fQydvV9cT4fY?= =?us-ascii?Q?i1L8YfAkKjuwRhHGwZvtLw6J3ohkPsE+d61g3tCw0uE3DEsUXefQdoZvC1Hn?= =?us-ascii?Q?ZpT+WoXIBP1wVq8Izlb4WFWA3KeWG/FquqI9mw5RYg5mUoMXZARZVMyIYt2p?= =?us-ascii?Q?t8Dg0rpuPlF08AIaORnYTdqugAoXICAA2F5tVj71ah27P6wfEEha7qR+O2ZD?= =?us-ascii?Q?uqVedOru0/0201AbLKt+0hvorvqNfUA7jkf2H5BkpYrbSYsi8WZ3X+Qib5g0?= =?us-ascii?Q?KuU2xT0DR1tj+eEH6YpDUNhM63AMgFiz41IgO50kWmIggORkkwRgNbU5+PoE?= =?us-ascii?Q?gCXaKOn0KZixV+lxmzv/f6qZw7xRCULlc7/r/o57Hqh99E1v9aNT5S+JIDIW?= =?us-ascii?Q?6pNaIxLBfonxubrO1ux+Z9IkCet+3JRWrwfhSOfRST73D7VTFd5Bwff5UMNy?= =?us-ascii?Q?DkPl5/WKDCwhLB56R51ElfqTuWrWRREjCFlWXgWzUu0F9jL6RwBjEHlEARkr?= =?us-ascii?Q?RPKeX1eHNf/cvCOIJOHhrjVqxIAuPKLGotAWLbdz?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5497fe21-e6d7-46b6-dfed-08dcc65bb435 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB7705.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2024 05:47:14.8354 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XoozuvTY/uKc4nbbtHyjpbrW2qpLO3mX4REu1BMW9dnqZHWH0++m2nxEM2f4CPykn+OwT4+9Jm4BN8Zv5Re9KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6272 X-Stat-Signature: ybnttjwp1sb7prq6mtk4tj5docgtch4y X-Rspamd-Queue-Id: E7D5D1C0006 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724737637-9925 X-HE-Meta: U2FsdGVkX19Tngk8do1CFo1bRPZ3XpCL2fUjTa7lX6fljZgHnbw5pM82fAbBJYeH67Z8AZ3za3VFyZbc1ul3xU/iKyMXmnzUHGoPVYcsRsoqCmJATkwomdCDmgP6MOwdD2H1Ml7dXSLbbtw4oNF0sTm/hreQcdwiHIM1jqg+Q+8ShlGksKG71Ki2372YqmjTOOO1XbCPuuw721MLmtc48gJLaF031munRmEi9R3zQNgkUbTgKHI3B+RIXHzv8Hxlx7W1o1q4Z48tEw27r+Ov0FZYWtOhxdh8j1z3aewOBEWMxEkuvOTHbbQfM9I+C2Qr1eMU5Quhhuo5Tvux/gnEaK9OmQqeiszArPpogKEyMKpjTG9/lSrqpdJRv4n/GEAQ99hPVWPpCVJMsnEbApLar1Sai88CjvKwoXuDCdIWim1gy2zgVENGXNaCP4XyTryLLsBbQFt7JqcB4fpnf3jMKcPELD2p+MoDFa4zfM22MAFbBLGE87Ac6jTqQOWOo74zSt+0q+sZ6q20d7XpdvQ93WXlOaJoOKD0lRD+z4EK8fEUKxQGHchjMw9fMV6lXYP/pew4E60ALNZkSHEIgqSJHUVv4Q8z5O1AxGHcEZA+Hxvf+rtnJxncBEn2dnPO7lUREtIQENeIXYDmcHXk/1XwSv69XzCPu3BQAUF8S0qJlEGkJbYwRrnw6hnDuOEiOAcqmMPT9B9RuFeHMqyG/1hQXSNKn70zhbHbI4C9QfwAelpWxnlJcV8HetXp9PclLWTOZce0CEO2pl6br9xOzdLAZDZl4swzrU3mbZXaonDDmE3BsjIa+nGr6Z1BumK1EO7s5jBMXbG01i5uP5K6lyWArfGogQmmuQD2kJoXwd/knNgRM+QOJ4ioOac4AGFtC0SnN/XbB8iedmuq2DtlcRvFSF3FiENMEZI73lndCcJroLwqWEyyy2I3UcBo9jHg+cg8OQgOv8V5ZbhIKw0m2J5 cfNQ2CHg Zmjzj3gefqW3yal3GWER8InTKCo16A9t06LSx96X32wzb9K5MX6XspHEMJ//WClbAyDh2tZdfuKWpchzJ9Kc5tyweQz8DPPSRlSWygvMEKnSlql6iHr/BjzLyiE0P8Wg2brwnV9FibKF7S4vS/swJ5AqTozpYCgSu85u9XzvcGup3eMj6V7Iax0RgDc/+lTC+TegSxeMhwTx8mNl1iDiNe/PJJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Kefeng Wang writes: > Save two calls to compound_head() and use folio throughout. > > Signed-off-by: Kefeng Wang Reviewed-by: Alistair Popple > --- > mm/migrate_device.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/mm/migrate_device.c b/mm/migrate_device.c > index 82d75205dda8..66db28b89f9b 100644 > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -898,16 +898,17 @@ int migrate_device_range(unsigned long *src_pfns, unsigned long start, > unsigned long i, pfn; > > for (pfn = start, i = 0; i < npages; pfn++, i++) { > - struct page *page = pfn_to_page(pfn); > + struct folio *folio; > > - if (!get_page_unless_zero(page)) { > + folio = folio_get_nontail_page(pfn_to_page(pfn)); > + if (!folio) { > src_pfns[i] = 0; > continue; > } > > - if (!trylock_page(page)) { > + if (!folio_trylock(folio)) { > src_pfns[i] = 0; > - put_page(page); > + folio_put(folio); > continue; > }