From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C6CAD2446F for ; Fri, 11 Oct 2024 11:05:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D853F6B00B3; Fri, 11 Oct 2024 07:05:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D64476B00B4; Fri, 11 Oct 2024 07:05:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4B8A6B00B5; Fri, 11 Oct 2024 07:05:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A57016B00B3 for ; Fri, 11 Oct 2024 07:05:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 241371C3C39 for ; Fri, 11 Oct 2024 11:05:47 +0000 (UTC) X-FDA: 82661041302.25.FECCF5B Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf20.hostedemail.com (Postfix) with ESMTP id A1B3D1C0015 for ; Fri, 11 Oct 2024 11:05:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DJLQZvwp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728644721; a=rsa-sha256; cv=none; b=flxbssdKYFUkkVJQgVHsmkDfi911s3e/GRuQz0q3yde0r9cquw3GBWjM0GTLwZwW1JIezT X3nuW3MdG4e0HyIyDMxDNp3ZufsQEM+OUDQjH2uY+LG4A9K1lnk7f4qpJnK/7tMi0hcuFo eLmNCVGfbqLbFnkm6GSVaY45FHSIhD0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DJLQZvwp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728644721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=4lP8AzkLPJlBDrSbaT5Bauc0dziSDSxAksJ1QNpxy4E=; b=1ABBBD/sg537F9ZjNPdWGPk58u3tcvhK8ggOSYXoDHLqYZctQGfjAQoxhuKaNc7qibVoyU +0qIwJyg/V/VybM1RSCVkN02z8qn2WzxTrZ5w7zt2bAIhyI0PUDG+GSVEzLEjJX2dQAy0D zoii/ujF+to2u9oVfjG/4bYRpCvnaRg= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20c803787abso13597365ad.0 for ; Fri, 11 Oct 2024 04:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728644749; x=1729249549; darn=kvack.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=4lP8AzkLPJlBDrSbaT5Bauc0dziSDSxAksJ1QNpxy4E=; b=DJLQZvwpHtNM4NobYIPb2X7Vn6DolNFpjsEZALv/Q6m+bw6gcs4XDw1wuz1ppJ1s+a chFaQDM3Qgjc5wPM329j9Qr5942164HU7WHsM7UGqPlypEDWGsPCHUN7TR1AVwsO/jho NCFhip/QLbPadIltyEHaYVfEu0Cr37FYrGP1mwWZRxXBjGah9GSpWUKSkjbSHWfPCqGw HVrlwGBHJtD9GyBVwJ7KxKde5uXJ0WQ9R0pWRiYejAbNU2SdfRq2pjR5t7ukY+M51bQw VvrJ4l3BfB0YVEjQ04whhcC39vmFF7WkXo4uARd8v5U9t/TjX2RJ2WRXS7xGgJmj2hB3 bI5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728644749; x=1729249549; h=references:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4lP8AzkLPJlBDrSbaT5Bauc0dziSDSxAksJ1QNpxy4E=; b=If6WblZoV8vWfKdPUltOZ8OCAGZ0XXsG1IHMaP+UEGtVGL99WIAeSCllPGuCs0//xj DV5Hu4t2UDi18rWeNPcKsHdbq7Uys9EKqPQYSYYOmK6DYA0S/fg1yyOhpq5on1xNQyQH ORdEpkzKXwmfOflC/ScyFFA+vMBWE14Zx3MtYhOdqL+pwZK6y00R90U1Vm0iiOTvm6sU 6LhIIX4PdhQtn948nBudDl9Bo5wQm0pUQpUEH9T9GyptH5Nt2Dq5jNU9T73B11CkTxmT 5ZyRGEDPga2FY3TH+ZktRMrsiuKWWdsNXSZwGJqdd88AuudAgXro82zJKd9WJrjJyO7a va0g== X-Gm-Message-State: AOJu0YwcV1vp3fSQe4Hq6VI2YiJVZXZmaRTXuv+Pu9uws4mDt3cJA2nL jgrvpvhxEeQCQYGLRhrHh7/enTS9A1cdyeySKnHw1fLhZ2lKF0lA X-Google-Smtp-Source: AGHT+IGxXL/GkLsEq8K5RCKB5q8Ci7ka8sCfDOJo9Ybqw500oUx4Vul/sdxip4R7mV6DPgcAMTFT4g== X-Received: by 2002:a17:903:41cc:b0:20b:a409:329 with SMTP id d9443c01a7336-20c80442c36mr107526735ad.5.1728644748610; Fri, 11 Oct 2024 04:05:48 -0700 (PDT) Received: from dw-tp ([171.76.85.106]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c3510bfsm21757195ad.294.2024.10.11.04.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 04:05:47 -0700 (PDT) From: Ritesh Harjani (IBM) To: Michael Ellerman , linuxppc-dev@lists.ozlabs.org Cc: linux-mm@kvack.org, Sourabh Jain , Hari Bathini , Zi Yan , David Hildenbrand , "Kirill A . Shutemov" , Mahesh J Salgaonkar , Madhavan Srinivasan , "Aneesh Kumar K . V" , Donet Tom , LKML , Sachin P Bappalige Subject: Re: [RFC v2 0/4] cma: powerpc fadump fixes In-Reply-To: <87zfnb54fe.fsf@mail.lhotse> Date: Fri, 11 Oct 2024 16:30:31 +0530 Message-ID: <87bjzq3nw0.fsf@gmail.com> References: <87zfnb54fe.fsf@mail.lhotse> X-Rspam-User: X-Stat-Signature: 5qah7pp6dqxxq9phdschapyw73ctbcn8 X-Rspamd-Queue-Id: A1B3D1C0015 X-Rspamd-Server: rspam02 X-HE-Tag: 1728644747-833499 X-HE-Meta: U2FsdGVkX1/tjJjSrBcZ+dA4WHE3C0fDPfQeGUayD/AQuqdzJjRWSMQtME8uHloEypxGAy1Qgm/Sc3QF2/t9eXJwgA/BNpjdP8wwoTdnqAr5X5HmGDxUUUvi7Q8UtPiQlENzTNZLiw8WksjxryO0ljGEIFAulHyBgkst7EXjHNFjGO49U0g197m4Mp7KCPrkE939oqH1F2vY43WdHu+Co6r/llsR4x39GXry9sZNfNYmwAx5HOWhUp89MddbfRLwxlIWxa2fJRsxyaOz9KFFFWwor2PbZ0mkYKLgLpLyaLwFhvOggC9TJu1BOSGssM/OYFdI5ZdPl6B6Fb7JO3/1E/+rBACbKi6bskyRYtOsLulRDkDZG/kKkWcKveM/D5wRmIsCzRcF6W5HKvOdyMJTRnO9YgB9sKQfnp8nYQJMNNV/2MmkYLJrWv/8MPxxYs0ZtgiHA/YJZ96HHXNYUJDoyjAGC/qGf61P5MEa4SWtGi2RaOG9CajeaH/C4b7tDghRiVvFM6cHNqwhTsDxkHAMgbpESg5Ia9hDxBMvtNCePMZhLkbjjQPHZkgp2B0kTvjKgwKC+lIkyhR2m9OGykminuTzxfRq6pbtYOlQc7UFNIP5r4C6FVj/YduoTOkJ7h2Jo47fK9mj7jvNySalVeMRUMT8A7PSqh5gzutgDixMt8osuuDKzqtvjlRAPs4xg5fNrRu9TvwJ6sGXDhwGTOyczpBkH8VTORttcrc5X6XXE8XmpT0/I64Iau9szbBlVH32g29RSMEMixv+Z6XCxfRQ8nn8RfLAHeIfTFeAoJ8K/T3d5RW8LZjYGagGiG+r7ll+q7JUdvpbI++8ZF9fPqpsAbZlBjBfJWGh6yxuQ3XvRiiwSQOsW1AS6UrQSM9B9bKVrgxgQNmDg11useKtlXZjpHscL7rLQpwHjjdxsCj650oVor2TCSAZMcBeOz6o/xTL2/IUZdDGt65//Zz2eo9 uHeqzlCI i2xhhAhd2LgqAI5E/p2efdW92jWVmKm9m58O5Pwq3ORrk9ralKnR9FOA7+n2qPODhE9ad4z8fI1Xy97ctC0yolu3JQyyQ3neZ4mzbm2NQ68c57sZFnkJxWS4EcSh8XfWuDaiz6pTKisiuINBjPUNYMDXROnoILgr9En4RnDOVQHLjNqHvd6Y5E5/KQKJ2jblGEo6ueHgfMTe2ok9mt3udlUjEQ2CofzTgkAMzQAuzkBfq8fPSNFIckjXNVXtO60Ev9EumlMxXcPs6JEKBml91xZR2XvKRa2egWJ1BKHCIlpswIKK55uH/3+cmMQw2eqtVbwLgIjsgux5WRI+s2mU2WWfZ578dxwI3AaYUMiS13d4m4X6p/HYWLXF5iHvHei6e/1b+rdeN0Kttoe3rqtIaDP7EmNATlj9NwFmWqR0fKV8bdzLZ5vZoX2AsvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Michael Ellerman writes: > "Ritesh Harjani (IBM)" writes: >> Please find the v2 of cma related powerpc fadump fixes. >> >> Patch-1 is a change in mm/cma.c to make sure we return an error if someone uses >> cma_init_reserved_mem() before the pageblock_order is initalized. >> >> I guess, it's best if Patch-1 goes via mm tree and since rest of the changes >> are powerpc fadump fixes hence those should go via powerpc tree. Right? > > Yes I think that will work. > > Because there's no actual dependency on patch 1, correct? There is no dependency, yes. > > Let's see if the mm folks are happy with the approach, and if so you > should send patch 1 on its own, and patches 2-4 as a separate series. > > Then I can take the series (2-4) as fixes, and patch 1 can go via the mm > tree (probably in next, not as a fix). > Sure. Since David has acked patch-1, let me split this into 2 series as you mentioned above and re-send both seperately, so that it can be picked up in their respective trees. Will just do it in sometime. Thanks! -ritesh > cheers > >> v1 -> v2: >> ========= >> 1. Review comments from David to call fadump_cma_init() after the >> pageblock_order is initialized. Also to catch usages if someone tries >> to call cma_init_reserved_mem() before pageblock_order is initialized. >> >> [v1]: https://lore.kernel.org/linuxppc-dev/c1e66d3e69c8d90988c02b84c79db5d9dd93f053.1728386179.git.ritesh.list@gmail.com/ >> >> Ritesh Harjani (IBM) (4): >> cma: Enforce non-zero pageblock_order during cma_init_reserved_mem() >> fadump: Refactor and prepare fadump_cma_init for late init >> fadump: Reserve page-aligned boot_memory_size during fadump_reserve_mem >> fadump: Move fadump_cma_init to setup_arch() after initmem_init() >> >> arch/powerpc/include/asm/fadump.h | 7 ++++ >> arch/powerpc/kernel/fadump.c | 55 +++++++++++++++--------------- >> arch/powerpc/kernel/setup-common.c | 6 ++-- >> mm/cma.c | 9 +++++ >> 4 files changed, 48 insertions(+), 29 deletions(-) >> >> -- >> 2.46.0