From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF648D1624A for ; Mon, 14 Oct 2024 11:46:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6210C6B0085; Mon, 14 Oct 2024 07:46:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D05D6B0088; Mon, 14 Oct 2024 07:46:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 472276B0089; Mon, 14 Oct 2024 07:46:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1FEF96B0085 for ; Mon, 14 Oct 2024 07:46:37 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 90489ABD5B for ; Mon, 14 Oct 2024 11:46:21 +0000 (UTC) X-FDA: 82672030140.09.3D7A3EB Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf03.hostedemail.com (Postfix) with ESMTP id F2BAF20009 for ; Mon, 14 Oct 2024 11:46:31 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dBLY+zRa; spf=pass (imf03.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728906323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=aWFh25nJyPJAANz+nHPv+XgVZ4oTsCk51SIBxPDCfHQ=; b=z9LphJ5ubXb4bJ/sktvsaNpdW/mkmDXv423tJcFFSC+Zz50dHHLIXBZX2Q2r0cYNaI8iT4 htH07AnY11TS7WVH27JFoC0w/j4I0pc9umLDh4bOy6WnsjwHc0h0fdz1C4b6ofa0sO/9Bg dRuVYNEzTIthzPegfZ8XnR8wQYnu0NI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dBLY+zRa; spf=pass (imf03.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728906323; a=rsa-sha256; cv=none; b=UyR5nLZzCcUzZ0yNcBICzQddipiKy/HCvVYUi85FGeyB5mX9IV3miEoehxHu86C7G1B33D e8rApsuB/T6AoSf/O/tQNxErMtgFJr+AqkzdmFXUaCdDNgoxxvxOwNB1sUHFqgxhmmpUrW kYIsdS4Rg5vgHCE5H4gcQLqvMGvLMRc= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20cceb8d8b4so9049585ad.1 for ; Mon, 14 Oct 2024 04:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728906394; x=1729511194; darn=kvack.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=aWFh25nJyPJAANz+nHPv+XgVZ4oTsCk51SIBxPDCfHQ=; b=dBLY+zRalRI5MPCnCJ8LFJo6vySQ+BjgYFAO0QP4t2BAu1YE+poc2siGfrZXaRCVtn aCVaWn41QodMNPwLuYCarQaIobFEZS5qDy30E6cb9sq40X/91a/gPYW+qhhLvrNf8nNG /yJSwausrBFGIJVxfYxhoB1t1mC44dh0zeEtALoOEfgX/Imxwvl1af7K+qd4NRyRFvo7 CEOYxXeGN3mg0ckMEDIQ2ugvoRxMT59K/S1M7B72IQEpNwZ1VjiAHa6M0HptKgQ6ZOTD RoRCuEvafiJq3kxIW5iMdB7Bgbs/6hOsC1dtKX5K+6o+CTfF0Yx3OyNF9V/1h/Mi0uaC VOow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728906394; x=1729511194; h=references:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aWFh25nJyPJAANz+nHPv+XgVZ4oTsCk51SIBxPDCfHQ=; b=CLtSPlqFmvoXPOI1P37NgiAODjqbwV76qdMrfNTxmIW5lOGLQvAQam/Ghl9fj11qxZ QzAgs33NPGsPvAcvYNG81I2XiHYYF6BypBVP0wOmo8zrDlKXxTjLuP8XTYnC7DVg5qMn kFXACNqn5Nvk/QwtglQpM7ZAEocjzQAoIGWWK7Pt4JomnJycfb+ta1nlfw3KWoXaiXNS oeiPpHdNvwLJrap6H07D2kDP4SiYIBPs+3xH8rugajTf1kqBEZFMpWAqOQFz4WdwIsa9 f4BghSM9C4qObDF3QqilU/Q3og76VhoIgRy86WtGonULZygmDApb6soTUXIZweR/l38y qDJQ== X-Gm-Message-State: AOJu0Yz++uQ8aZoESF25rDfgMv2BTWAIQ3ZWhhHdk7qfdewRfoQVz/W4 hNtKfkE9+ng9FnWj07DawzE19uW5bR5Tv4G7kni1htZa5mR4lYDj X-Google-Smtp-Source: AGHT+IEbzH2rLW7vX0++DAbmN0Cd8+5Z4OH+8mqkENfD5VLnA/+m5ohpTGDY/xnSU5tPiRMckODPdA== X-Received: by 2002:a17:903:110e:b0:205:5d71:561e with SMTP id d9443c01a7336-20ca0402291mr172569595ad.26.1728906393559; Mon, 14 Oct 2024 04:46:33 -0700 (PDT) Received: from dw-tp ([171.76.85.106]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c0eb755sm64431045ad.134.2024.10.14.04.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 04:46:32 -0700 (PDT) From: Ritesh Harjani (IBM) To: Madhavan Srinivasan , linuxppc-dev@lists.ozlabs.org Cc: linux-mm@kvack.org, Sourabh Jain , Hari Bathini , Zi Yan , David Hildenbrand , "Kirill A . Shutemov" , Mahesh J Salgaonkar , Michael Ellerman , "Aneesh Kumar K . V" , Donet Tom , LKML , Sachin P Bappalige Subject: Re: [RFC v3 1/3] fadump: Refactor and prepare fadump_cma_init for late init In-Reply-To: <941875f7-0d7f-4ba3-bc7c-7aedc3b20dae@linux.ibm.com> Date: Mon, 14 Oct 2024 16:54:56 +0530 Message-ID: <87bjznyliv.fsf@gmail.com> References: <030b6d46fddac126a6cf7e119bea48055338f0ed.1728658614.git.ritesh.list@gmail.com> <941875f7-0d7f-4ba3-bc7c-7aedc3b20dae@linux.ibm.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: F2BAF20009 X-Stat-Signature: nzni6jjzf5m7c6856t1wsk8ctmmsn595 X-HE-Tag: 1728906391-660831 X-HE-Meta: U2FsdGVkX19v4I1FU5txDRpGEEqJCnkcblT9P1UGi0LghW68c0ARs/wwGf59mywKwBo+jIjfAgsZCee2TXHtt5QF8LOV015K9JjGAe+QAKSqwagTOuLsp6WeDkKN8Lf3s1+XYvHn/pXS/LZV4PbfOG5F/IAIEHwyymcjqbTBy/PQwOiEv9q+ztkfVULvXht20QGXjvHWP8CklGypB9msrkPdER78Fsv1K8c2UUXztvHsuVSSOgdBWYr4ea9LWWwDovbYbVAEaQjH+at/xDOnWE/9fQDPPqbSP9R9E8Rkmqv/NfcKmtbRyxKOSp5iO8oCldKetTITMYv7/KAe2StkPUf8w5CRz4dZYdJftzTLTSD81tHvaVJk044GiHa9l2qxFQg310UAr02XXT9NLsjPXum74RpprzlYIS7eUZrflhEwNsbKNGW9iO3AHB8DSbojACqMwzHfHd7yR2WXDG/Nhb5SOZ2iGOXxW037QE8A4/ttPSkLgJIemFm+1StmMIkztJV/FUlQwyVVClBtLhecy//ZXFL4ePWN7y/QTDJP4NTp1qsuL3SD2VWHEswNXlotmCuZodXNifCh2WEuiPiE9Nwivr3qyf5WiOzzn4GS+Kmn4jniUVtG1N7WO3OPHFrC8aW34sfuc2QNDvH61Mdcj6sMlwvqbTbSkl3Eg+9KGe8kd3bF6tT/GNgK4z8vhVGlNhOE5M4FcQqzJwu9AA+IDaagKcBWUOrdEFiT3+vN+xBARCQkUHp3FViCtzLZtZ5JAQXEHbDDjR5cpl/ZQ/p3tvtKnAhsArlqFH3bc74ZOwAwWdIy/VhvDoQbV7BJAclrGYHYJcehjXxJ55Pb8LNSx/eR2FTOyB/HkUDzearmcBCMNLSWaNzNVWuHj0PQteJ33LUCKzN6c4AIDS8VZr7pS/fSnqoMjnncSU2oqN7SOldpl0nwAQIz7GI32bJalCiQO0sCOnyCJ1rQyLCbABA T+VkNrhe faqwPN+bI0W0J0mdQXoOJwJ/w2KuJHyhTbfIL979JCbSVpKcBLMiMpA5YUcvX96pVoxIkJCk1xM/1RtZiuN/O60VFwhQnSBR9gdOfdfy61r5Ijjb32bo1NvaBaKSkJYWICPgwTg6pvoTs6WlicW6NQSDy8mjK2okyAyT2fYCs85PeLt6hg2RtzxMQWPctKuXYnAR8OEGZRx4w7gY1Lt8tCgDixgJJbivQ3oRaRTyjdQi+zqMjIDsePuTbyTJw1V/fEhMEROt8Dzn5HuNvvAdgOg0XswmiW9euHgwwheJzTsiapAoYt2elP+91swuyds9qa9vO/pv47ZQwtteuuuB37w9ao5oQ+6cYpqd8Z1t59xtXFFuoAtMG726gowtjmcs0U1LFmMQtzKJC6EYwUocmKLfFvKmts8RPbJ7Q0NkGdSgcnJ2vHn62EkXcn7ARaE0Xdloo3VkOrm1H2RA866z9/Ey6DXuKerVT2ySTlcx64mHh3bW+RG3xdGrHVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Madhavan Srinivasan writes: > On 10/11/24 8:30 PM, Ritesh Harjani (IBM) wrote: >> We anyway don't use any return values from fadump_cma_init(). Since >> fadump_reserve_mem() from where fadump_cma_init() gets called today, >> already has the required checks. >> This patch makes this function return type as void. Let's also handle >> extra cases like return if fadump_supported is false or dump_active, so >> that in later patches we can call fadump_cma_init() separately from >> setup_arch(). > > Usually patches to this file are posted with title format of > > powerpc/fadump:<> yes. I guess it is good to do it that way (I might have missed it) Although commit history of oldest few patches to fadump shows.. ebaeb5ae2437 fadump: Convert firmware-assisted cpu state dump data into elf notes. 2df173d9e85d fadump: Initialize elfcore header and add PT_LOAD program headers. 3ccc00a7e04f fadump: Register for firmware assisted dump. eb39c8803d0e fadump: Reserve the memory for firmware assisted dump. > > >> >> Acked-by: Hari Bathini >> Signed-off-by: Ritesh Harjani (IBM) >> --- >> v2 -> v3: Separated the series into 2 as discussed in v2. >> [v2]: https://lore.kernel.org/linuxppc-dev/cover.1728585512.git.ritesh.list@gmail.com/ >> >> arch/powerpc/kernel/fadump.c | 23 +++++++++-------------- >> 1 file changed, 9 insertions(+), 14 deletions(-) >> >> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c >> index a612e7513a4f..162327d66982 100644 >> --- a/arch/powerpc/kernel/fadump.c >> +++ b/arch/powerpc/kernel/fadump.c >> @@ -78,27 +78,23 @@ static struct cma *fadump_cma; >> * But for some reason even if it fails we still have the memory reservation >> * with us and we can still continue doing fadump. >> */ >> -static int __init fadump_cma_init(void) >> +static void __init fadump_cma_init(void) >> { >> unsigned long long base, size; >> int rc; >> >> - if (!fw_dump.fadump_enabled) >> - return 0; >> - >> + if (!fw_dump.fadump_supported || !fw_dump.fadump_enabled || >> + fw_dump.dump_active) >> + return; > > Is these checks even needed here? fadump_reserve_mem() checked for all > these already, also dont see any other caller for fadump_cma_init(). > > In the next patch we will move fadump_cma_init() call from within fadump_reserve_mem() to setup_arch(). Hence we need these extra checks in fadump_cma_init() as well. I mentioned the same in the commit msg of this patch too. >> /* >> * Do not use CMA if user has provided fadump=nocma kernel parameter. >> - * Return 1 to continue with fadump old behaviour. >> */ >> - if (fw_dump.nocma) >> - return 1; >> + if (fw_dump.nocma || !fw_dump.boot_memory_size) >> + return; >> >> base = fw_dump.reserve_dump_area_start; >> size = fw_dump.boot_memory_size; >> >> - if (!size) >> - return 0; > > So this is the only place where we return 0, which in turn will make the > "ret" in fadump_reserve_mem() as zero forcing to call reserve_crashkernel() > in early_init_devtree(). > > we are removing it, becos we know "size" here will never be zero? > > yes. Because we already check if boot_memory_size is less than bootmem_min in fadump_reserve_mem(). If it is less, then we fail and disable fadump (fadump_enabled = 0). So then there is no need to check for !boot_memory_size in here. fadump_reseve_mem( ) { <...> if (!fw_dump.dump_active) { fw_dump.boot_memory_size = PAGE_ALIGN(fadump_calculate_reserve_size()); bootmem_min = fw_dump.ops->fadump_get_bootmem_min(); if (fw_dump.boot_memory_size < bootmem_min) { pr_err("Can't enable fadump with boot memory size (0x%lx) less than 0x%llx\n", fw_dump.boot_memory_size, bootmem_min); goto error_out; } <...> } <...> error_out: fw_dump.fadump_enabled = 0; fw_dump.reserve_dump_area_size = 0; return 0; } Thanks for the review! -ritesh