From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE040C5AD49 for ; Mon, 2 Jun 2025 21:39:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B2DD6B034F; Mon, 2 Jun 2025 17:39:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88AE66B0350; Mon, 2 Jun 2025 17:39:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C8FF6B0351; Mon, 2 Jun 2025 17:39:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 512A76B034F for ; Mon, 2 Jun 2025 17:39:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E436D1D755C for ; Mon, 2 Jun 2025 21:38:59 +0000 (UTC) X-FDA: 83511775998.15.6405FF8 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 4080120003 for ; Mon, 2 Jun 2025 21:38:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=Asn9VQpg; spf=pass (imf13.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net; dmarc=pass (policy=none) header.from=lwn.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748900338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ul6JEfvKkXn4Ju4PyxymsrKGgYLL2i0zjIICcAO4IMg=; b=zBhTouiBazE0rhKn6oE7ElFRyJIOf9KZr9PwDy4w53uYq7GDQ+AAkwSh51ACcpCPKlJnZr mO626wWh+xeKu0PsucO3Fo+cP+ZMIm1mzx5dOjBlwo2sw/H5o77NZz4ZMup5dzQjngbMTc wL2LcSw45Z8DxCEbOq+nluiBz6kG5II= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=Asn9VQpg; spf=pass (imf13.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net; dmarc=pass (policy=none) header.from=lwn.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748900338; a=rsa-sha256; cv=none; b=Y0RmlZ/PHCo61zIkQFJMNq8QQZHX3gQj4Gi+KNKOmeHYBHxQNU/oZ71AfWzq9VaBROpB16 cfiv/mwp2uABe6Ch9EguKEIXrRxDFtZiQzOTpBd6EqLcDAXXs21+Z7DKBEYU1PfBXLk25F +Dy8/iGrHdlwodr0gg22AUR+oelYiaw= DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 6FD9241A90 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1748900336; bh=Ul6JEfvKkXn4Ju4PyxymsrKGgYLL2i0zjIICcAO4IMg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Asn9VQpgN2Mti+VN4ioSRnUmD+EusZs8NWND6DgufnAzjzf7Gkukg9+dCnJzEllbc KBIbQ7Bt4qYaERC5XQC9vB+BTIOycmvrFCuoEqUz8H9BwUf0ZQPgXVPeYg5etNmFoT I7JKJWJcUwAKsZe+Cd3a9pvAKZvyQZt6GBzQIcyyWgVU0iKJOYjjhYFAZoEIR1nGKj VRxI6pLnllf3577zYF4V6TEqS+vAzUGmNOacZHxR2i8Pnmjgjx6OJaAgyXfrpqqUyK wwT8FVmy8rXBaMPfp6KWgwKWsmixhteTpkmMgYdKwiZJUvyBgqKQc0dJhv5jLi8TpU YVgYVUWOtYE8g== Received: from localhost (unknown [IPv6:2601:280:4600:2da9::1fe]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 6FD9241A90; Mon, 2 Jun 2025 21:38:56 +0000 (UTC) From: Jonathan Corbet To: Lorenzo Stoakes , Andrew Morton Cc: Suren Baghdasaryan , "Liam R . Howlett" , Vlastimil Babka , Shakeel Butt , Jann Horn , Qi Zheng , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] docs/mm: expand vma doc to highlight pte freeing, non-vma traversal In-Reply-To: <20250602210710.106159-1-lorenzo.stoakes@oracle.com> References: <20250602210710.106159-1-lorenzo.stoakes@oracle.com> Date: Mon, 02 Jun 2025 15:38:55 -0600 Message-ID: <87bjr59634.fsf@trenco.lwn.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4080120003 X-Stat-Signature: 9e15uj18rkhdi3w53xyiyuegiyf1ndqw X-Rspam-User: X-HE-Tag: 1748900338-852781 X-HE-Meta: U2FsdGVkX1+YHOs/3fdpvEt8ttThIuBnlU4nYRM/9aPt+JOXDHAslRNATaAhASBIOBTYNCLBD8jHhCAdqOfpNJyolppib1XLCvGj8pWoOwmxepVsTdAoXVwbYsApS5qXd+YeXxqwCredNuuleEccUMm4HEHoUiKikueKLyB+QPKvpIxmmU6TsMk1Dli3FtrB5KxniZj6hRl6FvcEnWEo6cu7qY2NM7mZLXVFRquMx0ysAnym0UTyMh1o6Pk/93Qkqhcv9UfLAdsgOmgr88HpgUng33y7MZyHndAsAVrzunqmkOWvrAZvaCI5TUV093RwaE+LNMLubuLR95SQ5doKlD6h09P0ixjrP4OMbSziKnooEoV+UtnN5fTa95tVMsJuQ6bQE1Pl8EO8/EWlGkilgKsZI57ud3P6cFrcoQRbORmarX6My2dgUuqUzvJpcVFdEBOc2SqrLVZNrerSrhl9qjWP4+dASpudniGkzNeGb0hlvC38LQ565IariM0XNdD6RmjYvzqeWO5Rxretiy+JqBPcDv/trvwKDlfGer/bZj4bxDYSF/rtbNN7iZJnfVA5U/1/KdiHjtdnA3sjj8L2ZT3tkLGRInwFaWq74exnkussHb5rHLd1vIAOns/y80+L58/6MjC+7+H2VjAidk1Cd3EWXwrYmIeUqmTv5uZWVjFF2Dpt6IcofwhKD3a3wKNDtWuqczgafdzUq9knWEoGUYjOw0hBy46XkzlJqWMpkRffcw2j65IGn90KpdvT59Dv01EyjbU5AiIL+tmuBuJKYpU6l1HU3zCoH2eZopQQ04rTZtSWP531+REsf7iUT/JH4e0e5oOuhFfE2wvF5cLw0G7vyJnmpilMaON56+WFxAWc5P7Relv+3aFQXcDNeLyQGglgI7QmPfWTYnrfLH35536nLz7dpNEmpkB1SyZn6V+VfkLZz4x89fVL1WbAh+LmqMI2fn+VIsOYgRa6W5I QObh7ZMd /ZTq9vpVZxMNOQ6WFpl1JZi9jidAi9mklZB9U2AP5pOjBfOh4dqBRtXJkiMh8uYkgreePsFveiXD6Q+m6ZGt70PA5juZL0ziyGkYKsRxFIncizyXmDTqDVcfKOD3ahyqUr4FvPph+MFkHU3oIAAVGepkq559oxoAY8HtALqqvGB2HJEmxoRDiRmibn8C1wTzUIwLcO3N9hFb4EzXUdXmf0Q6S6axZYewhKZs3m9s38o+M/eWXzpcd9tP97UYD98aiNSs4lnxs0Zw67BEd0peF1zSaLdgzfZT2Idh2Rbj2grYKw94AD4Dw4VsN8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Lorenzo Stoakes writes: > --- a/Documentation/mm/process_addrs.rst > +++ b/Documentation/mm/process_addrs.rst > @@ -303,7 +303,9 @@ There are four key operations typically performed on page tables: > 1. **Traversing** page tables - Simply reading page tables in order to traverse > them. This only requires that the VMA is kept stable, so a lock which > establishes this suffices for traversal (there are also lockless variants > - which eliminate even this requirement, such as :c:func:`!gup_fast`). > + which eliminate even this requirement, such as :c:func:`!gup_fast`). There is > + also a special case of page table traversal for non-VMA regions which we The "!gup_fast" caught my attention - I was unaware that Sphinx had such a thing. Its purpose would be to appear to suppress the generation of the link that turns the cross reference into a cross reference. The MM docs are full of these, do we know why? I would recommend removing them unless there's some reason I don't see for doing this. Also get rid of the :c:func: noise entirely - just saying gup_fast() will do the right thing. > +.. note:: Since v6.14 and commit 6375e95f381e ("mm: pgtable: reclaim empty > PTE + page in madvise (MADV_DONTNEED)"), we now also free empty PTE tables > + on zap. This does not change zapping locking requirements. As a general rule, the docs should represent the current state of affairs; people wanting documentation for older kernels are best advised to look at those kernels. Or so it seems to me, anyway. So I'm not sure we need the "since..." stuff. Thanks, jon