From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 047EBC27C52 for ; Wed, 5 Jun 2024 05:24:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 386AE6B0085; Wed, 5 Jun 2024 01:24:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 310356B0089; Wed, 5 Jun 2024 01:24:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18A8C6B008A; Wed, 5 Jun 2024 01:24:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EE6036B0085 for ; Wed, 5 Jun 2024 01:24:36 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7F91841132 for ; Wed, 5 Jun 2024 05:24:36 +0000 (UTC) X-FDA: 82195694952.10.3E7EBD7 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf19.hostedemail.com (Postfix) with ESMTP id A8CEC1A0003 for ; Wed, 5 Jun 2024 05:24:34 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=bsjLeBM+; spf=pass (imf19.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717565074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=ieXpxhBBWSSEFA3ad/RzGLUGCP/3ui0qmyCSm+SXO/M=; b=VchRKavMFHr/dzITckoHDqHZMAZGXXOb7VvaYmF9dXDwpwBgtAtocESD1g19dj5V76+d2R hungTSIaew9dIwoPAWshta8emRtrZeXg3kOt+Yc19iGZ2M4EJNqYCzxwMGWUCS4eOL1RrN rAt/VxzjKDkZl0WzltZWJP30L2+tbvI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=bsjLeBM+; spf=pass (imf19.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717565074; a=rsa-sha256; cv=none; b=EchAdKZT8NPYSXSDvkbrAnG4/UY48wjyPeqcvDuTal5LdGKPkvXNNFLVABZ+v3obVdCnOk f6mu60Bt5slLdo1sB7LoU1T7mphBN7M7Czp/UghI+x4OSIZhWqnEE8amDYqBIOVeOFFvQ1 gxl0j81fJyoAwHoYzpNp48Jmq/qeTPQ= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-57a7dc13aabso2250497a12.0 for ; Tue, 04 Jun 2024 22:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717565073; x=1718169873; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ieXpxhBBWSSEFA3ad/RzGLUGCP/3ui0qmyCSm+SXO/M=; b=bsjLeBM+x/Zj5fm3h4rML8jdSSrY9ktdSYhBvtur8YhVvGKobqCN7AziXa75EpIayD 4AL+XMF+n5V7uAoYsoLisaTfLaAA/ZHUljcH3JU4P9sDv0niXl81Rsf3KMTBOGyeAQU7 dUIXPbdLySatz5tbEQnwQqI+mQSV16bZ8mN4eQ3PSuGTqBy9XUY6L9NYiMRlNiBJT1fj w04I5EWa44KE/uDNx0Ur6m6phIw2YvUiNYY4ZRbllPoMZgQLIzSTXdbXEmPLCtQN2m+e XANjkd6KQYPy7yc5xyPydDzf1gt0zwNiH2eBMMcwUnM42CkjK1tAFy1ZMO+fNKW84Vpp fDdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717565073; x=1718169873; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ieXpxhBBWSSEFA3ad/RzGLUGCP/3ui0qmyCSm+SXO/M=; b=XIBf45b10PwXrq7hUe1K2TjxnrYEpX1X0ubO69unLyiMjKrXdD+p0bn+rJK2IFWgqs qf19bvL5ccpViIDzdkTyGSdMbKe/Cm+ibRfnxt0lE0jlTy+Se2qFia0peWpEd+cPSSjM rpGCI4WNfuTpLXpAgMEoeKDeaw8vkzbNaBzq//5P/uPmh4pa4zrlqNYGe1do8eikUpKv 6G9xLxvGF0c62uUiRy1JS7zq66Ut5gVW0fLiJWDOzfcoglFCcRMWLiIMbPgeIKKm64O/ fUf59oQW0hEkTqM/AkIrVC+S/VxS1SwDvKLjLjemxv6abP2+zlWvL5gJJu3pv/0eU1+k lVTw== X-Forwarded-Encrypted: i=1; AJvYcCV+T+ILQQYc2mdVOLWdJbv1wFV5SbytW8lxCDikNSv4qZrCI9aXYYBDAH+dNvPljuJ9rz1x2PD7usUJuReFcSTo5d0= X-Gm-Message-State: AOJu0Yzroy2f7xbpEWKNa5LKD9JGlVJuh0dkGw1kjhLXxuDLhMvbfLO9 GLkoyfbzYVxqAkKQ7nObHwbGPKiAa1ZgN7ratkUOfnDETmr1XBEto4SbtolMuWc= X-Google-Smtp-Source: AGHT+IGblo21HwWBJITrF2Lq0wtl7QLdAO0pjSkQJ1yY4jTCAGyNBZoCeBT+Grw2RfWlVYwmCDGV8A== X-Received: by 2002:a50:d6dd:0:b0:572:6846:b899 with SMTP id 4fb4d7f45d1cf-57a8bccb341mr692996a12.41.1717565072709; Tue, 04 Jun 2024 22:24:32 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57a31c6d301sm8526348a12.76.2024.06.04.22.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 22:24:32 -0700 (PDT) Date: Wed, 5 Jun 2024 08:24:28 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Xiu Jianfeng , akpm@linux-foundation.org, muchun.song@linux.dev Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 2/3] mm/hugetlb_cgroup: prepare cftypes based on template Message-ID: <87bca9ca-0c3e-449a-b121-eee7b84dc2ed@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240603120506.1837322-3-xiujianfeng@huawei.com> X-Stat-Signature: pnk4iru48usy67nkkzsgsngudc3bw1ay X-Rspamd-Queue-Id: A8CEC1A0003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717565074-317808 X-HE-Meta: U2FsdGVkX1+YbqMPya70oXn8czkaimlIy+UdrftIR47wRUeqjBTDjpVgWqyeeUcCnLUugskJfpMm1hWW3HXwCatlw0UxuG69nCI+4F+NWww48c0Wprww7ZkmXJIUfqJSpR2ipn6EDJrbNrbCdhf3c2D8xEYg8jntILauAuJb1V+KhFt6z6IltB0lBPQyiPJ9r+pckbbYstKoGyqeHAdyXf4PCD1gFthrWD6jS4LAar3cwidfQ1sW09HaWqOR3REjQQo43dYtFJkJl6Bxc9fghRwuSIDm+s4aDBu4nV26qCPyhiLkOtRVGneTpdMbCK8O9qT91RlxydWXFJ0Ut4dJlayOBfiuP4Hy7CQg4gECau+UvqC628bFjcpFqrA7YTU9EwCYdk4jeoMtHre7FFKxv0Y4wjn2y0S6Hgi50Jh+VS9CiguldPYCSea9xZeOGhqo8pdaydLTwTAQIFtLA82AcddxmsR9x120vPpYxfy+yF7TS7F+lsHMb9wX9Ts8TCkYbFu7zeG01hxDB+D7IbOfLLdpqk4Q7ZHQpui2SOjks6UC+UgWLSXsxBwOURtqXO68JKW38VEGqxIRa+i2ao8D5gDaxQ4veqAl/q1/Y44MzYjV7uPzfeRmWJhLY6KPvq387xz5hFJWVlNJEtIr3zC+2J2qTq7u0xigbA5jAGERlJj3n96H2g5Ahx9M3etYee/U2n+ESc/uHtw50jAkKyl6Y1rc/YugNyOha0KSzrKzUAqcr7JeKK7kOwOC7+7qahzS8efu2bKj+uM+bPF6eupudyRzXPDQJ4AedSzWeQEpGR8c/NR3PyqM/7IBkehnWx3kUIFGJ+SF86+3a2PCozvxbNlBT+LNjCjLqKCptAlb83tnq+p2h8AyrYQ59y2cSjuclioCqNRueTOAelOiNsBU3zZN12uguKH1NbfeFDiF6yC7rMYH8l3YNh04A1KFTwMmcLo22ZyBg6jxpCObttc yOLkCgRD zOfAdbgxfT6a8ImEWoz/xv7Ekv8a8FbH1NZGCnHXAMMCUQRV57cPCinlNqrAuKPgpU6J1DcLfIB5YDiDWoupH3H7wko1p8j+WM8eCBXxm+JyAIMmOFnFMqq3G0BRK826t+KOAF0U4MG+84fB84q4Wp9hikOs4d3ityqUrDwChCM2/x5NYy2CyijqCs7NIkN5udSgPy5CyPgDOWHL/gAW2d5gkhrKzR7wi90EHApSo7mDktztOBAX1fmSt3D0XwC4ZA7WlW1u+C8UNefSflIVcRytP9ZHBBvOZ+BgKFMrc7CUuo/7Lr5lvkpnZa9/ULzK1FRRvkv5MkfazSfgHM4k3UgTACO5yAyEeogfJnOj5TMiEUAZGpEI6YEkCQv89nzdV/h2zjRgUH6KRp+nLy7ToEDbhrN+7eRh3/8NdLbOTPSWd3fuaBWYUbtoeDPognHLW0xZdP/7u4mE9nxFmcfl/ofzOOIas9HgAXx9u0uLKr8wZRQTE41C+VS9litNhUpgTp20U0usC5jiRKiQ7/6ir0kgocK2ToshpzbOE8h2XDRLODz3NaZAqZQwxFoEUyc0PHxdoreVI5m4BC20VxDGJVKsO7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Xiu, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Xiu-Jianfeng/mm-hugetlb_cgroup-identify-the-legacy-using-cgroup_subsys_on_dfl/20240603-201513 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240603120506.1837322-3-xiujianfeng%40huawei.com patch subject: [PATCH -next 2/3] mm/hugetlb_cgroup: prepare cftypes based on template config: i386-randconfig-r071-20240604 (https://download.01.org/0day-ci/archive/20240605/202406050210.OWthxCFt-lkp@intel.com/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202406050210.OWthxCFt-lkp@intel.com/ smatch warnings: mm/hugetlb_cgroup.c:828 hugetlb_cgroup_cfttypes_init() warn: this array is probably non-NULL. 'tmpl->name' vim +828 mm/hugetlb_cgroup.c 66bcc9ace99241 Xiu Jianfeng 2024-06-03 815 static void __init 66bcc9ace99241 Xiu Jianfeng 2024-06-03 816 hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft, 66bcc9ace99241 Xiu Jianfeng 2024-06-03 817 struct cftype *tmpl, int tmpl_size) 66bcc9ace99241 Xiu Jianfeng 2024-06-03 818 { 66bcc9ace99241 Xiu Jianfeng 2024-06-03 819 char buf[32]; 66bcc9ace99241 Xiu Jianfeng 2024-06-03 820 int i, idx = hstate_index(h); 66bcc9ace99241 Xiu Jianfeng 2024-06-03 821 66bcc9ace99241 Xiu Jianfeng 2024-06-03 822 /* format the size */ 66bcc9ace99241 Xiu Jianfeng 2024-06-03 823 mem_fmt(buf, sizeof(buf), huge_page_size(h)); 66bcc9ace99241 Xiu Jianfeng 2024-06-03 824 66bcc9ace99241 Xiu Jianfeng 2024-06-03 825 for (i = 0; i < tmpl_size; cft++, tmpl++, i++) { 66bcc9ace99241 Xiu Jianfeng 2024-06-03 826 *cft = *tmpl; 66bcc9ace99241 Xiu Jianfeng 2024-06-03 827 /* rebuild the name */ 66bcc9ace99241 Xiu Jianfeng 2024-06-03 @828 if (tmpl->name) 66bcc9ace99241 Xiu Jianfeng 2024-06-03 829 snprintf(cft->name, MAX_CFTYPE_NAME, "%s.%s", buf, tmpl->name); tmpl->name is an array so it's non-NULL. Just do the snprintf(). No need for the if statement. 66bcc9ace99241 Xiu Jianfeng 2024-06-03 830 /* rebuild the private */ 66bcc9ace99241 Xiu Jianfeng 2024-06-03 831 if (tmpl->private) 66bcc9ace99241 Xiu Jianfeng 2024-06-03 832 cft->private = MEMFILE_PRIVATE(idx, tmpl->private); 66bcc9ace99241 Xiu Jianfeng 2024-06-03 833 /* rebuild the file_offset */ 66bcc9ace99241 Xiu Jianfeng 2024-06-03 834 if (tmpl->file_offset) { 66bcc9ace99241 Xiu Jianfeng 2024-06-03 835 unsigned int offset = tmpl->file_offset; 66bcc9ace99241 Xiu Jianfeng 2024-06-03 836 66bcc9ace99241 Xiu Jianfeng 2024-06-03 837 cft->file_offset = MEMFILE_OFFSET0(offset) + 66bcc9ace99241 Xiu Jianfeng 2024-06-03 838 MEMFILE_FIELD_SIZE(offset) * idx; 66bcc9ace99241 Xiu Jianfeng 2024-06-03 839 } 66bcc9ace99241 Xiu Jianfeng 2024-06-03 840 } 66bcc9ace99241 Xiu Jianfeng 2024-06-03 841 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki