From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B97C4332F for ; Tue, 13 Dec 2022 08:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 199EA8E0005; Tue, 13 Dec 2022 03:42:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FBAE8E0002; Tue, 13 Dec 2022 03:42:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB6C28E0005; Tue, 13 Dec 2022 03:42:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DAA3F8E0002 for ; Tue, 13 Dec 2022 03:42:39 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9DD4F80A1B for ; Tue, 13 Dec 2022 08:42:39 +0000 (UTC) X-FDA: 80236642038.04.0B76B7D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 9B7BEC0005 for ; Tue, 13 Dec 2022 08:42:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BDlrZYQu; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670920957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oo3SpYmVzFzB5/FBUFq/XhjE45kVHHL6DxTvof2O3/c=; b=MWGiTTrc02wnpHiuz+58bZgwPvQ/q8wLxKbHKU8a6vTtGBjJfo/30ABtffu7ojK4fZ1axK tdxI8FCqven5E2CyuB2Cpu6NfjYa6WkDfjcvbSRtkAm1n25ApgPgH3308iSIwUIKN+kLwd Rcnprv9rmRxRVoKcKoCcsYbuzZOKqf0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BDlrZYQu; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670920957; a=rsa-sha256; cv=none; b=b/t2jNnwihpcYA9jy+0a1QsIc5NvEElFH2ZP7OpEhVsmI2GE5k9O636guNn0uMPETzOuts xizxMQ0dmZTapSqf49bRwNpOc/Y4c0QSGp8gzEtf2ngWJgIN9KtRUMtkKWMopuHL8U9bHI PE2XmlVeXo7cML3/lUrYb4xNP9NGal4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670920956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oo3SpYmVzFzB5/FBUFq/XhjE45kVHHL6DxTvof2O3/c=; b=BDlrZYQupnK01tB0oBjtZIw5THsLSZ7htxoUHrM2/ZhfDnJmq/UqY6NU5zPkyc1kPGUBkB R0c7V8R5/2XkpNo3hBBZ00Srm/TAsuYqlYtPpK9PAa6PmMiFD9EptLhSw0chTDzZclfuUY 780P8ki6tIobp8JCn/LrCN7F1UiIX5U= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-73-Q4KFHSDoOO-7RO3-_Lejrw-1; Tue, 13 Dec 2022 03:42:30 -0500 X-MC-Unique: Q4KFHSDoOO-7RO3-_Lejrw-1 Received: by mail-wm1-f70.google.com with SMTP id p14-20020a05600c204e00b003cf4cce4da5so2736316wmg.0 for ; Tue, 13 Dec 2022 00:42:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oo3SpYmVzFzB5/FBUFq/XhjE45kVHHL6DxTvof2O3/c=; b=c4DdeGo8rDJFATKatkbDix6RUZb6MmBJ14goTbMYysUlv+OXh2lnz7elMUeAnBUkRm UQE87n3uQwAoEsV5OeyameAjr9lw+WMpDZfT3tAQKnlmZYFdxcKvLKGxrk6lhU55heHb 8BVWn80l3QIiTyCqQZ9fIwoefZ+LX1tmpZ4mAy8+eyQ8nW9X+YFs1qOgQi4jOSDn/Jg0 TQB4MDQAEa3Y/r5W5E43v4RB6T8bKgEEeWkm6x2AOhNOt+ZRsnmvLaiRmOY897XKH0Vi nthGz8+v/RrrQ39g0vP+s9VGTqms5ub7R9lKABKljFkORO94GOsohodC1utULX9HbbHE zTVQ== X-Gm-Message-State: ANoB5plOSdYL4bUn5KOR8znDlyv8zlUtpqXMETukjpQeyuKg5Bgny2LA U5eu4ZVX876OZlsnUfpA0ts4xg9fUYNdP1chvarHVD8judUI51c5W+uR8hdX02Wow71p1xSiF/p pWw3hnkYkv1I= X-Received: by 2002:a05:600c:35d3:b0:3c6:e63e:22e with SMTP id r19-20020a05600c35d300b003c6e63e022emr15042751wmq.5.1670920949284; Tue, 13 Dec 2022 00:42:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf5iWTiMb84ghWMd3z8QM07b9H7SdcKMAsnLrbSi8N48ctay5iscoKt5xIlEygqW/FLvg6egXw== X-Received: by 2002:a05:600c:35d3:b0:3c6:e63e:22e with SMTP id r19-20020a05600c35d300b003c6e63e022emr15042735wmq.5.1670920948988; Tue, 13 Dec 2022 00:42:28 -0800 (PST) Received: from ?IPV6:2003:cb:c702:6e00:8b72:420e:df27:90c2? (p200300cbc7026e008b72420edf2790c2.dip0.t-ipconnect.de. [2003:cb:c702:6e00:8b72:420e:df27:90c2]) by smtp.gmail.com with ESMTPSA id f10-20020a7bcd0a000000b003d01b84e9b2sm11638819wmj.27.2022.12.13.00.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 00:42:28 -0800 (PST) Message-ID: <87b0dd5c-f746-b60e-caf5-375ac342c7bd@redhat.com> Date: Tue, 13 Dec 2022 09:42:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH mm-stable] mm/hugetlb: set head flag before setting compound_order in __prep_compound_gigantic_folio To: Sidhartha Kumar , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, willy@infradead.org, tsahu@linux.ibm.com, jhubbard@nvidia.com References: <20221212225529.22493-1-sidhartha.kumar@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221212225529.22493-1-sidhartha.kumar@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9B7BEC0005 X-Rspam-User: X-Stat-Signature: xz6g3jgsgsgayuhjry3gefym68uy1hp5 X-HE-Tag: 1670920957-95113 X-HE-Meta: U2FsdGVkX1+nAOn9elu+9/FtIBmtNlkvu9XEhV7jjeeiNjbhXvtxZMW+FeiWpgY+5iqQ3RJqKdx/6LkK7SKbyM+j3VYp6+72XGS5zNXF8R9GntT8pxangYkw4HCSWUA1yQfZFV/jDSKipzqS7FV6ogg3yhYSYeADBzKTFYoGicoirrKVOZXQpSa+OW9PCX8FfiDXsos6CepcDwqKJpckHate+TgJxqQ4Hyh+ivQrwM+8sn797yPXbyporryas1cdBhfErFLc4asoO79XmUaAcTbmfJmNnx3nrkkfkmU5UCx6XavZdocP5qquBczodNTQ3hlb9sCdz5Il2PHbUWjZM9BWSmX0YOgkdKziTh9t7cTtD3Jp9266vIQB6MNB3U4/I0/KGWb4Bk41Gt/annz3W5l0VTUVbGSWpsK9wCebAj4dxC6pnoKPO1mv8qJGiUGH+DsqHbXYyX4k32HT0Sk3jYWTxobwV/dUOvw6N/wMZljfo5zFGU5kzxte5Ro5cJmUARFCh6rPRvj/zFwJ9C/2+hciXLx21XyXnCDXWdVuNXLllWuLtwcgKW/X+PowvokuwoaZi5d0vTIJJr0fAr4LcG/yFpYRdrDxXOjhSeCqYhgsUjIHql3cL0CUQo0CDWjTEdBJPAnxcqIPHfWkJgG+0uz9zkZpdXhzhlO70SFDQZrXy4syBM15+IeRtk17Rhy5NWpUlqyduncD3dCzt4NuK/iqlvxeUKyes0EdmFmgt2iHIlkyWXUuDTkP1cGgrOGi/zwRhlAZsmVp9++5YM97ofvSxs3cmtiwMQYgX3zhtzJCLY7XC3ov+C1MhHI0aHKDiaunhFchSVNlP9PZAiOZM8jyQYs5+/VPSI7tPIE+U0K9/MCTwKxNylkvAX+yo1GThdpTtCzN4QIJyfGSdvs3oOmMZdH3dSNC/uZW0H80HOudT585adsS0fNiH74ZXfU2tGSTw6KBAlrNnBwwtqL SLFcXEfa VAPPNOWv8opRYpxYdK+BY3wVXf05X9lPy2H8FlnTFnqdBN5y3QWjFWtNEw7+17JURLTK5L1inlVaPe7eFAp7+KMA4Bk9PWcmjOSY26cx6MwsA/yhV68scj/5qFiwKWE71l6ISXjoFMwRgDqAaSD6AIgbVhc2Hfmdg2IJIMGZVjHQ530PpDJkuE3DlfcIpxkx9qWcw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.12.22 23:55, Sidhartha Kumar wrote: > folio_set_compound_order() checks if the passed in folio is a large folio. > A large folio is indicated by the PG_head flag. Call __folio_set_head() > before setting the order. > > Signed-off-by: Sidhartha Kumar > Reported-by: David Hildenbrand > --- > Hi David, > I tested this by doing: > > echo 10 > /sys/kernel/mm/hugepages/hugepages-1048576kB/nr_hugepages > echo 0 > /sys/kernel/mm/hugepages/hugepages-1048576kB/nr_hugepages Thanks, that should be good enough. > > and checking dmesg. Let me know if there are other ways of testing > you would like to see run. > > Hi Andrew, > This can be folded into d1c6095572d0cf00c0cd30378639ff9387b34edd > mm/hugetlb: convert hugetlb prep functions to folios. > > However, there is still ongoing discussion with this patch series, > specifically with patch 1 9fd330582b2f mm: add folio dtor and order setter > functions, so I'm not sure if this series should be a part of the 6.2 merge > window. I am planning to send a v6 within the next few days to implement > the suggested changes. Whatever is in mm-stable is supposed to go upstream as-is and even the commit ids will remain stable, meaning we an only queue fixes on top. Therefore, mm-stable now contains: commit c45bc55a99957b20e4e0333bcd42e12d1833a7f5 (mm/mm-stable) Author: Sidhartha Kumar Date: Mon Dec 12 14:55:29 2022 -0800 mm/hugetlb: set head flag before setting compound_order in __prep_compound_gigantic_folio folio_set_compound_order() checks if the passed in folio is a large folio. A large folio is indicated by the PG_head flag. Call __folio_set_head() before setting the order. Link: https://lkml.kernel.org/r/20221212225529.22493-1-sidhartha.kumar@oracle.com Fixes: d1c6095572d0 ("mm/hugetlb: convert hugetlb prep functions to folios") Signed-off-by: Sidhartha Kumar Reported-by: David Hildenbrand Signed-off-by: Andrew Morton So, best send any future changes against mm-stable instead of sending out a v6. -- Thanks, David / dhildenb