From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D1DCEBF81 for ; Fri, 27 Sep 2024 07:25:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A1D16B0082; Fri, 27 Sep 2024 03:25:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22CAA6B008C; Fri, 27 Sep 2024 03:25:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02FAC6B00B1; Fri, 27 Sep 2024 03:25:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BD50E6B00AE for ; Fri, 27 Sep 2024 03:25:26 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7A52FAC053 for ; Fri, 27 Sep 2024 07:25:26 +0000 (UTC) X-FDA: 82609682652.28.7CBCC32 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf01.hostedemail.com (Postfix) with ESMTP id 67C8A4000A for ; Fri, 27 Sep 2024 07:25:24 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=gg8YXmla; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf01.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727421803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JBEcpv3YHSVlk1Wp65VWtKfznpwDm9l9nfMi/ye6i/I=; b=3MBsQuQFbBPMAT0eDiNHT5E5EUJt8pVmT1p3vM3zlJgyW6xBoU59Y9Z55PSVe2C8OuRqN+ dayLWmBF0hYsb2NAwsl7sZwN1sWPGX3nmtjiByusCHbH+qcZBa6aio3bZl8wRzAWcOlS0s lWbZjoIQuSdm0FWlvGeOjovvd9fNbxw= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1727421803; a=rsa-sha256; cv=pass; b=6k3yx1aBE9CoRGc0kEVCGReAfuSh0ZWAqaEiyITp5WWIhZ3f9lfFZW8Nrx05H4i7hpurer LMqg+Ddzd39Y9Pg2b7y6TYSa/pQ0l5Yr/gBJSRzwj+OBjE79iizuvsgLb+cHxhdnPXfXiI HX9HtJAYApRnQRno+gWYqYwjWFgP54E= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=gg8YXmla; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf01.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; a=rsa-sha256; t=1727421914; cv=none; d=zohomail.com; s=zohoarc; b=TtmE2KMW469q5De9PwLR5QBK2XSBNOYmh33iO0FhOc2Ouji65rQrZHln8G4XbsjyuIg1spmYemGow95YwqA9/y7epSYxl1ONnNiWTnX2WES83fB5Qhu68e19rA0hLxSNRg6KdmKwQIrngdRZCIcQPSe4eDwCKrke54SfyoY6Pw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1727421914; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=JBEcpv3YHSVlk1Wp65VWtKfznpwDm9l9nfMi/ye6i/I=; b=ciRNdoL04zKMZBDJgG/JPY889Bb3DGIvboYsRTGZU+Py1oF20wxFtIPzmxAmp4we3Pyu6l3GT8UjUG1c/9zckkNu51KnDDLko8EEhqjxXfMxtNnCp3Gw2nY0Jo9k7nbwopBKXj3/jDIZ/6DKdrn5XI0SlGfmhZ1KXn5Belhfp4M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1727421914; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=JBEcpv3YHSVlk1Wp65VWtKfznpwDm9l9nfMi/ye6i/I=; b=gg8YXmlaw/p6I1VYpkNysJ9jSLmbwXF8lpWpVr8Suf9lSIiVc3DQogqLS6YZBOYU HTbdSgHNyyKHc6NoKBZjy8rUDlVnwFQE3FBxjq/5CQQzUoLeq8Ao+GxcucmCWBVMxLF 7HhYsYYYYxv45HK0Eww/+oL2KShKgTxFvJMIh2lE= Received: by mx.zohomail.com with SMTPS id 172742191298275.66141873135632; Fri, 27 Sep 2024 00:25:12 -0700 (PDT) Message-ID: <87b06c82-5e59-404b-889d-baa1293bd160@collabora.com> Date: Fri, 27 Sep 2024 12:25:07 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: Add missing free. To: zhangjiao2 , akpm@linux-foundation.org References: <20240927030114.3792-1-zhangjiao2@cmss.chinamobile.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240927030114.3792-1-zhangjiao2@cmss.chinamobile.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-Rspamd-Queue-Id: 67C8A4000A X-Stat-Signature: 3nh4ko777rh188hzxd8dqbrfseqamnfe X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727421924-205000 X-HE-Meta: U2FsdGVkX19uxX83uIh82AgCETWdkRfb7TJfyWZegg2RKtMnLGpEDbHoOwkJ4REQfeqHO9e+MWbP4B5ujHmo+geutas7foFUxXgrn1oOzwRsCQtwUTv6OEz9SwX2Lk68Dc+XE2m/kvRcvSuuphthLClLKAyFoXWCGs09wVpMPgfmLlt8sMaqD/gxicgm6lceu6SMwvlQn9RxUux65G/QmFktKUuFS0DBPNCAlMnsq0Ko4GvA3YTf9CRJSdbBPQ6ev8lwLVs7w8HxESjinLS2mEx3BS/I58UycRmWBivSnhKaPqIIwDl41e9j8RnHEMt88erC51MORs0lnJ0LMmzHVhcLM5Qvwd3pekal1yKtT91jRggTaeP6l+DyJkHPk5kjqdtS+9WcqVlSW1TM/8I1fS63gDHs6MROutIuQzgcETrSt65tyy28tUY6i1PVlRpxGpkl31ASTAG5GT3jwZA8lVxayk2PTBq2sS2KKS9Xl10Ewrouo+XyeBr2VXxkv7olIMVPta1kNAYzmLUiuoPC9t0eSqDv9Y0YHSs6g3fuQJSseE5/c8kQssiqhTOojBjoD4J0j5sYk/D97vVZz0+jzS96s9Btqfh49Eg5f8g5dvDWyEoJ/JaWitsLESUbVzUU5rrSiMwisMNFGSomYer5E0IRGx8lMKXULiL7Yry9V+JJF7ByZXOmymPitvHghF1lEbCr4gETeCUVxltwsjFxfBWA15i3k+ruGOdubzK0laOQVpBYjUXdV2JuSgGj2rZtTUnTZai2HggLhzEy4emTdbGx3A95oQu6OiG3Dw/FAjj/SkNw7f2XlfRA4WHTQWNrNX/olvK99+BiHPIriiaDWaRnYrNZ52Kv492rb4YnN3oidGpoOezejXR9jptFREGT2AnTp7Nvj4HxwHFkkUnGcUrgoSCKSkwSwto69ytY7jJlYp679mb6A2CNTrjMQ8eXZIPjIZIUWEj95nMGYzy s3VGBcQr zlxuS7c1c0oPS/5/Uh3/WT5S8IXVwKlpUOfMG0bymTELkSBAinDQP45DfnWADq35FtaeZ0Hqa+TsVjWbzA8/DsMIPAeJXXzrKd0FlLi0MznVYI9TR3byIVAunhNnm8H/HVmiJCJgUVvOLb+PRuc2wEdHsisyB02843vZRKmz0D9zL0gBI7QL1DKdM7V1AMSZOM5XolnUBGijgxQwg1sSxC8DXfn+/iKbLtxdJpTre84ddBSoYeBz/XcT1Y6T7gmgRr1+GcBDMLGZpuP9zMP/D3caLv9I6TAYtS1jEGR3vhH4bRls0GOlssiasAhNQyeUmAEO+eZFS+ylrakE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/27/24 8:01 AM, zhangjiao2 wrote: > From: zhang jiao > > There is a memory leak in mkdirty, just free src before return. > > Signed-off-by: zhang jiao Please find the first patch which missed this free() and add fixes-by tag. > --- > tools/testing/selftests/mm/mkdirty.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/mm/mkdirty.c b/tools/testing/selftests/mm/mkdirty.c > index 1db134063c38..af2fce496912 100644 > --- a/tools/testing/selftests/mm/mkdirty.c > +++ b/tools/testing/selftests/mm/mkdirty.c > @@ -280,6 +280,7 @@ static void test_uffdio_copy(void) > dst = mmap(NULL, pagesize, PROT_READ, MAP_PRIVATE|MAP_ANON, -1, 0); > if (dst == MAP_FAILED) { > ksft_test_result_fail("mmap() failed\n"); > + free(src); > return; > } > -- BR, Muhammad Usama Anjum