From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13ACD0C5E6 for ; Fri, 25 Oct 2024 09:01:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88F646B0098; Fri, 25 Oct 2024 05:01:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83F766B0099; Fri, 25 Oct 2024 05:01:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 691E26B009B; Fri, 25 Oct 2024 05:01:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4EADB6B0098 for ; Fri, 25 Oct 2024 05:01:51 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0F09580711 for ; Fri, 25 Oct 2024 09:01:34 +0000 (UTC) X-FDA: 82711531140.08.82FDBE3 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf20.hostedemail.com (Postfix) with ESMTP id 868E51C0023 for ; Fri, 25 Oct 2024 09:01:23 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=nXac+4rI; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=pzyDTp1c; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf20.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729846737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0zqpZCw7QTCtE+yIzU/ne/b4P7tTgttpmHGsLqIFpyw=; b=t6Jiv5LWbOg7zqPPzbWQLWqdX4MPAxHwIo82huneH5q+FXQ+61M95wtot7y09n4pLKTAkd /xkIi3LSI6Eq5Zx82MWX1kadWlBHsTeQv9h0yXE1l/hx7DD8kyZHxTgk74+AUyGxAb89jE 3Ao+MOtOEWPmmGMs8vFvv0jZap4r1yc= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729846737; a=rsa-sha256; cv=pass; b=kZn+7Oa4zrDR+JvyMlib1BJ6OBUuM+5Sp8l7wgIKyPkLyse0N/ZvVYsXeUflLaiSbzy0Xu W8ZbCtYzc/0IhiMKCebtQHb5/HR6QOrpjm9kHp8QJA8PNrIcs4lmZ7yCeerpcs61qlG6qA KLw4Vqwl2Fzi/YM/BeKYsZBMIGEOVgk= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=nXac+4rI; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=pzyDTp1c; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf20.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49P8Bjjv001056; Fri, 25 Oct 2024 09:01:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=0zqpZCw7QTCtE+yIzU /ne/b4P7tTgttpmHGsLqIFpyw=; b=nXac+4rICRxAwUrCdZQ4372EVSgMwmPydi pOYcggvO/pOZRxoejbGYK6KYDzWkXPp2G+Sf5AAqchXv2QflmAEcq+Zcc1B5ID62 3EQvUJjqer0lPJYUHlmX1YzAqH/WuRgc/l7/SzPl/URrVGI+XDVy4yjz8PrEjkxd rq26gn0qqLjlp9sEJ9Yto2Rl3g0XaLjR8FzCyTsuD7ftl8j+E4o0FkECdxQPpHET kqTLdsBkE1gWAz7x+rch81u4scRhGGcICK8CV9fiPVCUBF2Ip5N5H6WV9XNH0W6c 1zqV3K7EGVRIZ0H3+SvitiXxZnZ3CK6CRdkB1rtRHDKVyRoMNbRA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42ckkr3s87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 09:01:44 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49P7m7or027348; Fri, 25 Oct 2024 09:01:44 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42emh5g707-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 09:01:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QxZdTpXiT8pvNaaMXG1C6Xmq+Lz27E84BEifaxKUbPhIj1QYueLTeFZQRucnapN8sr4xUaEayb2e4Es91ZAN33nIsEAaNTF2jrgrvaN+pB3ankhd0VQ2t/5VC3cLG1170lyGDeNClMGEngiij7BH4jqriasBZo8YpT/frTTOOH6DttIHKBF0B48zh6cuUfod5QolZptz1KL1EUfOt9jA+Yfon3W28FUrW7WrCA7epu1HaOWxA2UGTcQi3d/9Vb4lSrHZjjaxKviALhfNU1Kl4Bg+aeyAdg9BQwbyFb5uOiXJLO6joXk1pIyqe9Uj3ptT2cRxqFvGRs9PuNVns57aOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0zqpZCw7QTCtE+yIzU/ne/b4P7tTgttpmHGsLqIFpyw=; b=ja8zjdOlvD31p2+BRotnr/PYUYv0KiTluKpUbu5rPnjTb3qJLA11cO0/BgHDsvsgV7JQvUUqWxlZ1zfnpNYembF8QurWtLa4WadF+rdtzpYKJY4VB7SLEUAJ0Ee3UIbJKz03WMAyXnP0QUImRpYyVf0TM0nPIk6x3MnCOKca7Pba5GeKmMRZL3VSF5g9OFCM+UiNQinzofnY6DWYKNi+Zg/P7+TADFYd3GCtbTjNe91udlxHu5yjdygNjpcpeL1OC12MR8DuWPdUUOJDhY8RksGPI9l/gKlAtj0uKV0NSBMDCqNgzIdiQntRdtGIK3mtjiGHmwZhi4QHQdwfDtsPAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0zqpZCw7QTCtE+yIzU/ne/b4P7tTgttpmHGsLqIFpyw=; b=pzyDTp1c5N4QFMLrfFGPRT4Twjk0+VIklvG5GqfAKa47n/q5mWaioeP+OAwZnuOzuCpkk70p4tU6ecEJy4IBktGNzLOGLnWCIluJjPeZUqdpZVAvYeFY7K1TFtLHyGeHwTvQbTX5DAFqo6IEVH0ZeyUXXioCQoXe11WErrrpJYI= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by CO6PR10MB5586.namprd10.prod.outlook.com (2603:10b6:303:145::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.20; Fri, 25 Oct 2024 09:01:41 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8093.014; Fri, 25 Oct 2024 09:01:39 +0000 Date: Fri, 25 Oct 2024 10:01:36 +0100 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/vma: miss to restore vmi.index on expansion failure Message-ID: <87ab8c21-2dd5-438d-916a-2fd9c48679e1@lucifer.local> References: <20241025031847.6274-1-richard.weiyang@gmail.com> <20241025031847.6274-2-richard.weiyang@gmail.com> <848b5701-9dec-4c69-bcca-f9186090978a@lucifer.local> <20241025075955.hczpuimxcfqhjv5x@master> <978e1d13-bb8b-437e-adc2-8af389064ae3@lucifer.local> <20241025083227.nt3twr5mgq7ssg3d@master> <20241025084919.m7etchfw4riavxmj@master> <20241025085409.hpoi46cazmkogbfg@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025085409.hpoi46cazmkogbfg@master> X-ClientProxiedBy: LO2P265CA0114.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::30) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|CO6PR10MB5586:EE_ X-MS-Office365-Filtering-Correlation-Id: 159e841b-5910-4f09-b22a-08dcf4d3a33a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?h4kQgGUQ2jRRY6VJrF2XCQrnCUUPdiFFMcvqW6PH3YJGyYC6OeXAbVz1C/in?= =?us-ascii?Q?345Bofo8txuVKBkYYTk/L7ybwQSVYS+IyLYbB4/qnDfm9LSctvWBfdgrmELp?= =?us-ascii?Q?/M70bjFPLzfuCiiTTrL8rfiuH1myNYUnIy9BrRoLJD//6cxIExnOQCHm9uQp?= =?us-ascii?Q?z7gNm13CRfk40PYOfXJOrcRu2235YQn8WhtNuY3Y+XAenWDax8oPFiqQM7Ny?= =?us-ascii?Q?hUlE0F5oUgAenNP9qvXT1GwdEKMRt5VoUONYnRn14cL/ajuoO4HiSdXlc/AC?= =?us-ascii?Q?Ex6dGDXWFYKR7bjdkCcS+KlzGYo/m6WaOIeyZdApO0WcoZksuK999esT16Lb?= =?us-ascii?Q?ED14HTAFFF4nfeYq30zxczUHHTZHF7BFcPfv2n+OZ/9geRPqhq/O6arN33Op?= =?us-ascii?Q?gi0ETs8MZ3bvVOwtnvU7K3WrO8stAQI8QGAdHAdi3pSfO+jvXQEssBZq+wPj?= =?us-ascii?Q?JXhzUGpH4c76MxHbtW/xa8bQOJhqaQLDL20y6su7fGWp+cJHHzUm8ecoJURg?= =?us-ascii?Q?6R5SBe3IO2NhEnc6hoxgD+ZpZssUybKMbhhQagZc7fE+knxKbaZGzgT6Ak0L?= =?us-ascii?Q?oTuwOZkMgjbWKztcAZVUZZZxOwPxH+5DwzLJsaS8tCwYFUriT/1W8NDopGRs?= =?us-ascii?Q?xpDQq3YnJR/oPE3jNwzrUfhnCpkaDFjkDUuayQCjouV/Mum3vTzzrjhHTRGJ?= =?us-ascii?Q?A0SKUTeorTMNaiD7UDVQpta7NIlx5b/0N90pfrcVYJYYwwJwwLF/7m4DBSxH?= =?us-ascii?Q?tcIhZfXUSX2ezZcPPoBolTeniTEQ0LL9+tUAj5tdktosBoIc1BvbYNJ9KIeV?= =?us-ascii?Q?Stta2uxYxN0xkhv1VnUF6MGir9dzSlA5pTPCJ9IlSObwq1Pz9z/Rhit932wC?= =?us-ascii?Q?bicUF20SFpw6QsoQ+ROWMQofvvuGlmhm4HUhz8jFAsK2/N4+uSdHI7JtjcJ8?= =?us-ascii?Q?DMLpL32e3N4zRQXBCcLqS1BNTUmH+7mvILyloDBUidlkTo8W2wpf0O7nIQKw?= =?us-ascii?Q?uvmCzwHBOJNes/PAZnYP+cMEZbdXfptMbvVJ5X3pNeQ/aUW9bn6JOzU7iwsu?= =?us-ascii?Q?pAHr9cXUKN7yS91/q0TH1sZLvyq09fFt+fPUvWid4/RXlCba6xUE3jWOSEa9?= =?us-ascii?Q?kzqAL5q5plvRHhgDqZ4X715s0kX7CmNsoQhfHEAM2jpBwn5c+rh6s6C7QFlQ?= =?us-ascii?Q?sCEA/4I8q+TmXXN2OfVga4jsfCUCqHt1y6sBSAa7PLbdf39zw0RYldfsNUlF?= =?us-ascii?Q?HWbxhvIn5UvKzIU5hBDE5GxYtdNadvToOResFf8xVpdaI/LXjX+2TpdnlPuu?= =?us-ascii?Q?uF1nYeDN5pwDdbkYGZI481Tb?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?67s5gedyLe+KgK04pdtHB4GT7uI9A+qvldNk/wJVwaEZgGLhEMupqofCbMEF?= =?us-ascii?Q?j2AaaxoAmuvdPFgc1x2REP3J1aVdw2WKOoG88uggl3IOdqiXCE1vLEDwuY2O?= =?us-ascii?Q?0eyMzg0y1oMrlqcotEXm8oqXj/CFvEgmJyas6lyHZO85LS7ZdoGG7EDDHTzk?= =?us-ascii?Q?wsC/wdwGm2+ORTidOcVCNSq7jmiEZE7Wsdw8dz8Cuni3+m9Ytjb4l5sIYO/g?= =?us-ascii?Q?PezpxDuUAO/m1UGpZNtgMoGlAz8j9p1IIAqsGZUOV8EGBYL+S9HpctLCdXNE?= =?us-ascii?Q?IzqlsMgkMyd/v8v8TwifQVgE6zCvuwnyZIjLB51VX0rChyzDMBBEevF7JpOk?= =?us-ascii?Q?Rgg/R9l59lQFJNXnoYn7RFrd5PljQg2Frb+R784Jd9ZGIgSXENg6Ww2+U5S1?= =?us-ascii?Q?F444TAT8xXrXCeNgClJOYL7BNYq2NE0SRC1W1Qel5HLIWnGpGoqk2PDrLblB?= =?us-ascii?Q?/EqzF3n/R57PVgGmpDiGdVsTnL87FJ71qKYnsBuDQeWO+KkNm1PMwr8CUoAM?= =?us-ascii?Q?4g8Z45DmNeZt9OdRC07rNRms/WG2xjKAFNzh5ttzN9ThLH9bjEI1R4Q8deIf?= =?us-ascii?Q?RhpLu/PE65QVrUr2Naszr7lN0aO+qbrnmiVLw3UnMVVcOV8IsqZ/BFch753h?= =?us-ascii?Q?t5PlQ0nv3PwiydSZwn8OqyMBvmthLEpLX/ZTgEvGpuGYGpWWx+iNKNcUn67J?= =?us-ascii?Q?zt77jMelwyEYGaaaBUHh7sXP2WpVIAYrgqhPM1Ucq8/kFLqDGp0pvIWPvWIF?= =?us-ascii?Q?b2nzOelPASfpJS6chuqQIY03MhZ8Bqf1dYNm7TZkx9Ni+0mKnnuMataOKTpz?= =?us-ascii?Q?7uDHJJ5FQGsy6RhexN+0tBpDTAB+H38c1KRvB28M7jliQ2QYG9BoxWoV+xLN?= =?us-ascii?Q?BoIzUiKQQU8X4ClRnZFIHvlCb765D8jFQ2lVR/YNKNBS0VeAg8roZmkEQMJh?= =?us-ascii?Q?9mYXld/giJlKfJcZCuIfgJHiPxL/61FpV2QUjXcKWoTSh1aBoREX6kXRWjrQ?= =?us-ascii?Q?6O2soQABAOdOjCp3fxKp8+PvpudFjfK+nemcQSdZk0qJ7ruxlb4KgqIzNcWK?= =?us-ascii?Q?IY6cyQGlV3Lin0/HIfwcHolKbX6zVws1zqc/qOI0Twyh/hMlTCbraTuG36Y0?= =?us-ascii?Q?8y+/vzGvAlkag2QjXvcv1Cu+mvaNUqU8d5SdiPr6apvh047KO/JMJCB+liEM?= =?us-ascii?Q?SeWgr1xtf3BeC9aHwvw7KBmEwp9nVIZ3p9l0h8Olx5R21Xh8keehEsrhL4V3?= =?us-ascii?Q?sYFJ2kN2kyeCW49gFoisMR8/xnWZ83R2cM0JyV2Hxr5yrokxAn3L4FZpadQh?= =?us-ascii?Q?e3EpSvvHOpwhvkBi672GatTGTd1hWxUOvUNn6xSEChdvkBupWzEQthuTc5Ah?= =?us-ascii?Q?OidMqoFz9PBJhxuzgDWX8rdIfYn0/SWLOE6Z5W1jjXPH/hAwsUmsgbRTQqGg?= =?us-ascii?Q?sxNR0T5rSlWAtXUnTsb/K29UfqaRneu7KWrMqXPXlCOXbhWpthUI6qfAEeDz?= =?us-ascii?Q?oGX6E1wcdjFk03MU6l0IlfbamTcfxtIt8J/TWZZ9UELhxZdCXGzPWROQzJNU?= =?us-ascii?Q?n/OLVRNJ5hLz+OZk/mculYlY2vOqlcqHh3tC/d8IRlkT2DGSwHCg6XJd7hOX?= =?us-ascii?Q?Cl61dCBNszyAZQWaVmcprFvZR3p8HVvjPCnYe3+e9gtVFqLuIQOJCgfE9DD1?= =?us-ascii?Q?uckcYA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: eNHFBhfSNda7wSiBegEtlVgYcy/q5iLMw1/3XVy4dtqZG5rJSJfi4VXjQAlVuMGvpqDTusS1mv8oNwbp7GXC08EhE4bOuGWvOb4rThorbqJQahgpMtB+ZMJlJpjVFb7SsskQm8bzV3C+maRMwRlqakw4yh6uNbZtXyIje/Ya0fDi+90d9g9Whk+b6kJxOTK7Q/xBGFnbxrNMaIo4x2MCYCKG+Zw5k+W+Xx6dyCue674vNYpbh7GD3Ia0j2VCwO3MfKZAKPU5vQ5iymyV1Q82Va/iSmGFSQZBSZ5Br+sRFBOAMWQpnUzWsslb1zN7EbD5tIFgrqpSSoHiHJJUwF9+AzR/Fxm1onncIBTeHdQVliHXnrOW1UlTEbHZO8JXURtxgI44YXFWNuxP45v50iC7GKkBJBfDvpK0J+qNPT5S10eX72VFk8ll3jkDpD3JhqleyejKG7l+sQF2Zlruw++CWQrX8q1SSUak5UNu5EtIkQImlO27DiQEzqkI5rp25V69+GMgvHNf7/VooEQwZ0EFqQHi0puQ+WuZKokpbKblmam27JYPsKnkBHgN0T8WFrCOlg7csNEInRzYYdbodbLAxE6xQ1CkEiqsyTDVTMPnkEk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 159e841b-5910-4f09-b22a-08dcf4d3a33a X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 09:01:39.5733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JogNj8vcQzSlBPr58waAL7ckfAqWzKHDOhkLc0++Vj3PJF1eSFlfFW6mHAZcycDo3mZw5ouXsTw8B+oRvNVj1d2fvPG68fZyO+cvV5NOO7E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5586 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-25_06,2024-10-25_02,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=720 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410250068 X-Proofpoint-GUID: iz15F5I7TeV5eKmwYiLBXtAdAtfegqLq X-Proofpoint-ORIG-GUID: iz15F5I7TeV5eKmwYiLBXtAdAtfegqLq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 868E51C0023 X-Stat-Signature: gfjsru7k1xgzbaijoarqwn9go93xg9b7 X-Rspam-User: X-HE-Tag: 1729846883-962165 X-HE-Meta: U2FsdGVkX1/sJQadJ20WEu/PULvWDc0YTafyS6dF1eTjpkeDjmUqxkbgda7LVvnEXSPPgnxTbmi0/MpOU01jFGpfqYX8cJYS2COGsGYLdbHdj5WBaVlgY1D3pe/h6lokJ+Xwc19xNo3ANjPgm5lF7XrFCxnsEsJzfjf6uZ6iYvakSJXabivcaVUKKlpuS+sh/Hzi2L5PrsF2zifiNiYSr1mVRvpkF6FQ6m7W1Wz6C8YvbXXvUuFdiJlQoGRd4f6CGJsW35n0cM1yIq864MxAYHx1jjU+IrjAt6h3FEFWar/n27VQulfSa/5RdXTasIO7omRl4Yfr9JgMTPvaYYHPHcpElaTW7nJZUL8sTvuTVa4yavbdEkxbJzHW+EiML/uk4VzX2Mb8LA0Y6T26rcE00UF9diuIaKRjGOc0Wkv0PR9JTub9+4OlWEINl+jB91ucTUl6gcJ/HaXVUuPWWV1hiP49VwpZC/9zVhyTUXje9v26nY/y2rjdUomTEo/JK44LbvEb7cwU1llvuW250p07cZr6Vi1+lotntw+DK20jybKXhvQjfzYFoPLDVrdIirjzg/DFtIIhwvp1bNP2ZbsRCerruGbhBLX4FPm86oJak1jzyE5fIKhVOZ5Un3V5n2kTJmxYMEjY8i/rBfh3dOS4r8F/NSBsFAwXFjIKAHyemd5d0NF05NUoJtGGu8PLByQ+PDBKINPm2YZL3THxJmDoSAehHHFceZE/aNS5gx8KJdfNUbr0krpZFv9KESEwqTk9CpTNsbvkuem2gP2FoN5IAW2qBYpSjK1PpD2f/JOdtynh2f9tl4REiwDFCoj4WsBC3U/NuvukAiQcQrfbBQD/J114mqLsGPN6ncf2P6ujTEYh+IR5/pUhkzKMqzCBbGT6seb+VvCOh1JVffujKDwn0hUohLCz3svYdUEh3NaZQTuhL3vwSzQA2D7Kg+3kci+cGjQKyZDOST0z+jIs7Xb tePqA9ge GA4vdNc4haHk8qZ5lIABuwDr7lBKqT1Yb3wS1w3nQbvHoKTY6yRmIo3sr48cN9FGsBdgtcJdO394tziLTrp/qG4wkT8hEZXGx0lFVsF15R9SI7fms1kcFVM494ElfKKdKGRSW/Zsw6K7YpbZR4xlodx0OD+/cx4KcjaAXYiBTSaX8efQixkhRRzQHt5D3F3/rlNSvhibkIHgAQSgob+Nz1G8vnQJh1rw6doiOenRlPHl+Dw3lr3nadcnJ55YUTA3TNxDPFQ/9It7w2gxoJ8L8pA1/WT/fAySAh21sSa9fHkwta0BThdDvWZO62NGUC3XFBgkbY/KZegh4hHWr98QIg7PZpJ1obLxNb1+iz4noxI1D2mRhmBCQ5l2pokehZO1vYqwJizHSmtym4MR07M+IC1qN+zdEBL47jhsDE79GN+w0o4Tv2QY1VYtqcyOXu5W6yVIqPxvqMIAhQQ+uC6XypswNq3+P+w++/h6Ecxrp4Lugy8ZyRkestMQ1aRuKiDTnGqSzLt8E0OPSXJlKIKX/HbZGTGrs8An1pVZsWRG9+umx51+Nb3r+uaBBY9rPV4c2krLC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 08:54:09AM +0000, Wei Yang wrote: > On Fri, Oct 25, 2024 at 09:51:12AM +0100, Lorenzo Stoakes wrote: > >On Fri, Oct 25, 2024 at 08:49:19AM +0000, Wei Yang wrote: > >> On Fri, Oct 25, 2024 at 09:40:25AM +0100, Lorenzo Stoakes wrote: > >> >On Fri, Oct 25, 2024 at 08:32:27AM +0000, Wei Yang wrote: > >> > > >> >> > >> >> But I have a question on your introduction of VMG_FLAG_JUST_EXPAND. > >> >> > >> >> Lets say just_expand is true and can_merge_left is true. Now we will adjust > >> >> vmg->start/vma/pgoff in if (can_merge_left). If we fail expansion, we won't > >> >> restore vmg->vma/start/pgoff, since just_expand is true. > >> >> > >> >> Is this what you expect? > >> > > >> >Yes, I explicitly wrote it to do that so it'd be a bit odd if I didn't > >> >realise :) > >> > > >> >Actually at this point, I don't think we need a follow up patch, sorry. > >> > > >> >As I think perhaps I will make this change as part of an existing series > >> >where I am reworking mmap_region(), since this is the only place where it > >> >matters, and it would make everything a hell of a lot clearer. > >> > > >> >Thanks for pointing this out, it's very useful (and an embarrassing > >> >oversight on my part...!), but I think it'd be better reworked this way. > >> > > >> >Thanks! > >> > >> Ok, for now I would just remove these two lines with the change log you > >> suggested. > > > >NO! Sorry I've not been clear - don't send any series. > > > >I am going to make a change that eliminates the need for your change (sorry, but > >in discussing this I've realised that's the best way forward). > > > > Sure, go ahead. Thanks, apologies I know it sucks, to be clear I very much appreciate your input here! For more detail - we are refactoring how the '2nd attempt' at a merge works, also avoiding any abuse of vmg-> fields to keep track of start/end of a range, so it becomes better to just open-code 'reset' of these fields precisely at the point we need them. Do please let us know if you notice any other silly mistakes like this :>) Thanks, Lorenzo > > >> > >> -- > >> Wei Yang > >> Help you, Help me > >> > > -- > Wei Yang > Help you, Help me >