From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93930C64E90 for ; Tue, 1 Dec 2020 00:27:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6F8520809 for ; Tue, 1 Dec 2020 00:27:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6F8520809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E9C256B0036; Mon, 30 Nov 2020 19:27:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E4BE98D0002; Mon, 30 Nov 2020 19:27:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D638F8D0001; Mon, 30 Nov 2020 19:27:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id BDD986B0036 for ; Mon, 30 Nov 2020 19:27:50 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 85A6E181AC1E9 for ; Tue, 1 Dec 2020 00:27:50 +0000 (UTC) X-FDA: 77542825500.05.brick61_19177cf273a6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 666B8180278A6 for ; Tue, 1 Dec 2020 00:27:50 +0000 (UTC) X-HE-Tag: brick61_19177cf273a6 X-Filterd-Recvd-Size: 3238 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Dec 2020 00:27:48 +0000 (UTC) IronPort-SDR: YF1uXoVjHdBduuRNky0OA/QIv4oEebPwlQ/Y8TQlowJTudnuk/zmyZiQC0xiCgRusWBXU0aE3l /szECgSpZ/ag== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="152566940" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="152566940" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 16:27:47 -0800 IronPort-SDR: yj4LV58XLzO268tAWATMfYPQ0jKvINmzRsB/h2Q/p5ZAfNM73gOp5tYLgWAKrXlg8LkmukzX/8 Q4mrBZKEgV9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="364459780" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.159.50]) by fmsmga004.fm.intel.com with ESMTP; 30 Nov 2020 16:27:44 -0800 From: "Huang\, Ying" To: Dave Hansen Cc: Peter Zijlstra , , , "Matthew Wilcox \(Oracle\)" , Rafael Aquini , "Andrew Morton" , Ingo Molnar , "Mel Gorman" , Rik van Riel , Johannes Weiner , Andi Kleen , Michal Hocko , David Rientjes , Subject: Re: [PATCH -v6 2/3] NOT kernel/man-pages man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING References: <20201126053219.234793-1-ying.huang@intel.com> <20201126053219.234793-3-ying.huang@intel.com> Date: Tue, 01 Dec 2020 08:27:43 +0800 In-Reply-To: (Dave Hansen's message of "Mon, 30 Nov 2020 09:48:56 -0800") Message-ID: <87a6uyqsjk.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Dave Hansen writes: > On 11/25/20 9:32 PM, Huang Ying wrote: >> --- a/man2/set_mempolicy.2 >> +++ b/man2/set_mempolicy.2 >> @@ -113,6 +113,11 @@ A nonempty >> .I nodemask >> specifies node IDs that are relative to the set of >> node IDs allowed by the process's current cpuset. >> +.TP >> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)" >> +Enable the Linux kernel NUMA balancing for the task if it is supported >> +by kernel. If the flag isn't supported by Linux kernel, return -1 and >> +errno is set to EINVAL. > > The one thing I learned about manpage CodingStyle is that new sentences > go on new lines. I think this needs to be: > > .TP > .BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)" > Enable the Linux kernel NUMA balancing for the task if it is supported > by kernel. > If the flag isn't supported by Linux kernel, return -1 and errno is set > to EINVAL. Thanks a lot for your information! I will revise this in the next version. Best Regards, Huang, Ying