From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC4B2C19F2A for ; Fri, 29 Jul 2022 05:30:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 400EA6B0071; Fri, 29 Jul 2022 01:30:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3898B940008; Fri, 29 Jul 2022 01:30:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 202C3940007; Fri, 29 Jul 2022 01:30:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0BD586B0071 for ; Fri, 29 Jul 2022 01:30:25 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 82A551415D0 for ; Fri, 29 Jul 2022 05:30:24 +0000 (UTC) X-FDA: 79739011968.19.6F5020E Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf03.hostedemail.com (Postfix) with ESMTP id D17A5200AE for ; Fri, 29 Jul 2022 05:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659072623; x=1690608623; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=ercbijlouhtyzIM3o1wUqu+SodLfktbd6L58SWuUJoI=; b=e7Px9x79VedLPpcVJDFfQSvUAYyYbYbCS7/2NfIu39FMnHYvSvemsqiE ML57hfJL+vgXXjNa6tZXjqRT7vWh9JiQwQ+xudwRol/tqVFMjEDZi2mlx lMZ8bigjOQi9hz9jg/jh/W4qNliYS1WYUQWFu79s4kPTWk2OdJ9m3V+Lq eHOY/M9Xck/05qv318TygwouNsgQDasxMcwTDaFAh2o2BxIYIwCq0nTNp MXYxjCNXe1PnJTvdgQ+taXG+mtWewpaqWkp9oANeZlB870Ji3je+V8wI0 toxFR0eVtEJtMz43aLg9ASQgYKUvVpheaL7yG+dN/cWWCjScAOJByBRT1 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="268458802" X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="268458802" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 22:30:22 -0700 X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="928616797" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.13.94]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 22:30:19 -0700 From: "Huang, Ying" To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Wei Xu , Yang Shi , Davidlohr Bueso , Tim C Chen , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Johannes Weiner , jvgediya.oss@gmail.com Subject: Re: [PATCH v11 0/8] mm/demotion: Memory tiers and demotion References: <20220728190436.858458-1-aneesh.kumar@linux.ibm.com> Date: Fri, 29 Jul 2022 13:30:08 +0800 In-Reply-To: <20220728190436.858458-1-aneesh.kumar@linux.ibm.com> (Aneesh Kumar K. V.'s message of "Fri, 29 Jul 2022 00:34:28 +0530") Message-ID: <87a68smqov.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659072624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b+4YjWEpEIW2txyQAO+YQyDCslU3+3LkioMEicJ2rnE=; b=Rdq/+5l2T+TUVvPn69Qt5CYBv/MFQ629Me1aNAecwnNOm6jGejXa1HGwNt42TOKkvDOo0u JKX+wCAX5em1tpU1NQNASP6qStpy6UegQDUEb3ehKq9134beM6alu6kzW3ZZ1HSo5+KBMq +/Fu+qJWc1CeHR+v4ANf1b6897cOHos= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=e7Px9x79; spf=pass (imf03.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659072624; a=rsa-sha256; cv=none; b=vw1HkQMKyPXA/69O7HgMLJ12BkzLrEM2n4c9BKnWoKmc3A8WFIOQz1a6UE3ZBSF9YsG8zf CV7jz4Eo5MED3IRUJ3oxK5AeorowfgvqtQbXza6z4Vqk0WVmaTxSHTsHIHn35d5RJAoDiB azDBtH6oPHkoO3+mdUNgJxXAkEVXzb8= X-Stat-Signature: gpd9t1gs7mb1r91wzxtgz97hptk93s5p X-Rspamd-Queue-Id: D17A5200AE X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=e7Px9x79; spf=pass (imf03.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam06 X-HE-Tag: 1659072623-430718 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Aneesh Kumar K.V" writes: > The current kernel has the basic memory tiering support: Inactive pages on a > higher tier NUMA node can be migrated (demoted) to a lower tier NUMA node to > make room for new allocations on the higher tier NUMA node. Frequently accessed > pages on a lower tier NUMA node can be migrated (promoted) to a higher tier NUMA > node to improve the performance. > > In the current kernel, memory tiers are defined implicitly via a demotion path > relationship between NUMA nodes, which is created during the kernel > initialization and updated when a NUMA node is hot-added or hot-removed. The > current implementation puts all nodes with CPU into the top tier, and builds the > tier hierarchy tier-by-tier by establishing the per-node demotion targets based > on the distances between nodes. > > This current memory tier kernel interface needs to be improved for several > important use cases: > > * The current tier initialization code always initializes each memory-only NUMA > node into a lower tier. But a memory-only NUMA node may have a high > performance memory device (e.g. a DRAM device attached via CXL.mem or a > DRAM-backed memory-only node on a virtual machine) and should be put into a > higher tier. > > * The current tier hierarchy always puts CPU nodes into the top tier. But on a > system with HBM (e.g. GPU memory) devices, these memory-only HBM NUMA nodes > should be in the top tier, and DRAM nodes with CPUs are better to be placed > into the next lower tier. > > * Also because the current tier hierarchy always puts CPU nodes into the top > tier, when a CPU is hot-added (or hot-removed) and triggers a memory node from > CPU-less into a CPU node (or vice versa), the memory tier hierarchy gets > changed, even though no memory node is added or removed. This can make the > tier hierarchy unstable and make it difficult to support tier-based memory > accounting. > > * A higher tier node can only be demoted to selected nodes on the next lower > tier as defined by the demotion path, not any other node from any lower tier. > This strict, hard-coded demotion order does not work in all use cases (e.g. > some use cases may want to allow cross-socket demotion to another node in the > same demotion tier as a fallback when the preferred demotion node is out of > space), and has resulted in the feature request for an interface to override > the system-wide, per-node demotion order from the userspace. This demotion > order is also inconsistent with the page allocation fallback order when all > the nodes in a higher tier are out of space: The page allocation can fall back > to any node from any lower tier, whereas the demotion order doesn't allow > that. > > This patch series make the creation of memory tiers explicit under > the control of device driver. > > Memory Tier Initialization > ========================== > > Linux kernel presents memory devices as NUMA nodes and each memory device is of > a specific type. The memory type of a device is represented by its abstract > distance. A memory tier corresponds to a range of abstract distance. This allows > for classifying memory devices with a specific performance range into a memory > tier. > > By default, all memory nodes are assigned to the default tier with > abstract distance 512. > > A device driver can move its memory nodes from the default tier. For example, > PMEM can move its memory nodes below the default tier, whereas GPU can move its > memory nodes above the default tier. > > The kernel initialization code makes the decision on which exact tier a memory > node should be assigned to based on the requests from the device drivers as well > as the memory device hardware information provided by the firmware. > > Hot-adding/removing CPUs doesn't affect memory tier hierarchy. Some patch description of [0/8] is same as that of [1/8] originally. It appears that you revised [1/8], but forget to revise [0/8] too. Please do that. Best Regards, Huang, Ying > Changes from v10: > * rename performance level to abstract distance > * Thanks to all the good feedback from Huang, Ying . > Updated the patchset to cover most of the review feedback. > > Changes from v9: > * Use performance level for initializing memory tiers. > > Changes from v8: > * Drop the sysfs interface patches and related documentation changes. > > Changes from v7: > * Fix kernel crash with demotion. > * Improve documentation. > > Changes from v6: > * Drop the usage of rank. > * Address other review feedback. > > Changes from v5: > * Remove patch supporting N_MEMORY node removal from memory tiers. memory tiers > are going to be used for features other than demotion. Hence keep all N_MEMORY > nodes in memory tiers irrespective of whether they want to participate in promotion or demotion. > * Add NODE_DATA->memtier > * Rearrage patches to add sysfs files later. > * Add support to create memory tiers from userspace. > * Address other review feedback. > > > Changes from v4: > * Address review feedback. > * Reverse the meaning of "rank": higher rank value means higher tier. > * Add "/sys/devices/system/memtier/default_tier". > * Add node_is_toptier > > v4: > Add support for explicit memory tiers and ranks. > > v3: > - Modify patch 1 subject to make it more specific > - Remove /sys/kernel/mm/numa/demotion_targets interface, use > /sys/devices/system/node/demotion_targets instead and make > it writable to override node_states[N_DEMOTION_TARGETS]. > - Add support to view per node demotion targets via sysfs > > v2: > In v1, only 1st patch of this patch series was sent, which was > implemented to avoid some of the limitations on the demotion > target sharing, however for certain numa topology, the demotion > targets found by that patch was not most optimal, so 1st patch > in this series is modified according to suggestions from Huang > and Baolin. Different examples of demotion list comparasion > between existing implementation and changed implementation can > be found in the commit message of 1st patch. > > > > Aneesh Kumar K.V (7): > mm/demotion: Add support for explicit memory tiers > mm/demotion: Move memory demotion related code > mm/demotion: Add hotplug callbacks to handle new numa node onlined > mm/demotion/dax/kmem: Set node's abstract distance to > MEMTIER_ADISTANCE_PMEM > mm/demotion: Build demotion targets based on explicit memory tiers > mm/demotion: Add pg_data_t member to track node memory tier details > mm/demotion: Update node_is_toptier to work with memory tiers > > Jagdish Gediya (1): > mm/demotion: Demote pages according to allocation fallback order > > drivers/dax/kmem.c | 9 + > include/linux/memory-tiers.h | 79 +++++ > include/linux/migrate.h | 15 - > include/linux/mmzone.h | 3 + > include/linux/node.h | 5 - > mm/Makefile | 1 + > mm/huge_memory.c | 1 + > mm/memory-tiers.c | 586 +++++++++++++++++++++++++++++++++++ > mm/migrate.c | 453 +-------------------------- > mm/mprotect.c | 1 + > mm/vmscan.c | 59 +++- > mm/vmstat.c | 4 - > 12 files changed, 725 insertions(+), 491 deletions(-) > create mode 100644 include/linux/memory-tiers.h > create mode 100644 mm/memory-tiers.c