From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D52CFC636D4 for ; Thu, 2 Feb 2023 18:02:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 438296B0071; Thu, 2 Feb 2023 13:02:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40F576B0073; Thu, 2 Feb 2023 13:02:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D77F6B0074; Thu, 2 Feb 2023 13:02:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1AAD66B0071 for ; Thu, 2 Feb 2023 13:02:17 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E8EC5A0FB5 for ; Thu, 2 Feb 2023 18:02:16 +0000 (UTC) X-FDA: 80423121072.10.3053662 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by imf06.hostedemail.com (Postfix) with ESMTP id 296FC180036 for ; Thu, 2 Feb 2023 18:02:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=kJbd0F2r; dmarc=none; spf=pass (imf06.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675360934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=foQ1/0HwCNQSpMC2ZhJON6OX1wyhGGFLINaHnphz3mQ=; b=xaiNeXDvW0YW+ecxhPxTKrNy9lw0mMAQA3tSU+fgPJu1JJWzT3yKjE34wI0seJ/sqZGwO9 sF65Z5TijNkyhT7KELAjJhVghEtiDnpvzc1IGzwiMnz4fknrCVfKzgVItRfLJFWsOsx3EQ CCQfafYpvuBy/4aA2PkB06PQ7JamNmI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=kJbd0F2r; dmarc=none; spf=pass (imf06.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675360934; a=rsa-sha256; cv=none; b=F5r4b6jgJKYcn29EPN8r0KhcQxAvPPKwplxWsJaXlBdd5sJ78wf6OB897T6mPCfiLde3Uz rgzHVUHuIhLQQpsIEto5H2vIqfE7fspKcSk/CSNNvTAJSFDYOQvlJdcfgzrcmZXbEu6gmh DrOBhzjpvN9sgpPp2ES6t8srx1G8C7M= Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 3D4A87DE; Thu, 2 Feb 2023 18:02:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 3D4A87DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1675360932; bh=foQ1/0HwCNQSpMC2ZhJON6OX1wyhGGFLINaHnphz3mQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kJbd0F2rWnluPzLgK38TMaqiIycpVlQWVPBxv1Ywm6Iy3i8ABcGXnwWj/VtHUyGXu TJJDRYuZiiaPKwc7O/ldvE1/aerbMkVu42adh0LD4ub4MR18FloBX9uSDPEm/6+Agm 4CWfaYGafUqqIdFHDLbr6eoeEzoJgvPmzb0HDwH9BL2cT0Nw0KuPLf9keCwHw5k/SH DDj2GgsZ1o+/r9V1mFT7GBBjv2K67z03FoEz1UY7/izsPxHSjeVTQ0hzLNMGWk0Emq c1fXgOxS4gRZZHoFkTBh9Yd31cXHfl4F1fb8qR74Xrl7qTrj5amsNpULEy135z99CY y7R01tI/HjX/Q== From: Jonathan Corbet To: Kuan-Ying Lee , Matthias Brugger Cc: chinwen.chang@mediatek.com, andrew.yang@mediatek.com, Kuan-Ying Lee , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/doc: Replace isolate_lru_page with folio_isolate_lru In-Reply-To: <20230131062853.28449-1-Kuan-Ying.Lee@mediatek.com> References: <20230131062853.28449-1-Kuan-Ying.Lee@mediatek.com> Date: Thu, 02 Feb 2023 11:02:11 -0700 Message-ID: <87a61wvtcs.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 296FC180036 X-Stat-Signature: ue38ipxwq6odowk5fowtygjgaiu1fht7 X-HE-Tag: 1675360933-913571 X-HE-Meta: U2FsdGVkX1+CWOHlJWRKo19lPVYjQBAN6xJGs+An08LpZzb849IERIaEiBdlOMD5LvMaxMBbBnEnCTtyNrz5N94Y/erXWgQoHjFBWf+NPZesl/10mLsAvfwqKGHl5yyLU1w9hsetPJPQS0/zNMIr/ACZJTC5oTafPx4LvNoidCCBpmYO/D7Edk3UJFro1S1uH0qORL8ya05YW21YWQWVwdgrhlFQiqeKh6OlRhJ9a8YzuONOFELN9/gTeuYIGG1qj0cUc9BSRtg7faf4VPIJxrivg9izao291VrSGBkVGclCICKvgHFtNuOibouXJj01HmFpyXe7L3bPN5v+YFeFeSy82YzXskheEwKWGAJu7UGCjzLL8sfnBF3kNqX2f+3RSxQuvW0Wi4svDBjLCXAKRv3qiCrdm5wEw/U2aKTQqmsM2l81bSeNJkh8KD211rXw77qWcmmthc72mroB445EMZ8kK07s+RCCYOepbV4J2vWvNZkGve6pX1rC3+dn/3XAUlAIsM4tS68QuMoyi7442PDb3wgmubwJ3YafMx/tDxXSf8IjyImlupvm6Gw53vWG2qZmG4IiV4ZUmGep7moJ/pCtECbKNpmophEBPcNt2vZ23zEJvpsK/zESs7S7zhaz64TFqSRtkNMQ9HRDVML8A4lQZgigw8IPVbKypmrvnhX7855t8J6ObWgmEO54Wh3DOHb+zddThvXWG7ErX2X/Y+P5SOoZDIhwpLkSVhn39XWopS5Jfga1AVZP9zW9w8PjWuW6AgEOzRIMa3T1x57yDoNzBzClqvzpPEe7TiINoV7oNHQnyHgJL6H3/XZ+2AVu1mub5gXb9JA1Xk5wji40yH+hxSIGracf1Sv5FTkSXpUfLW8w+UukiFWLiIOemosJ0gPz4wTKYoH5GMTeZuEqsLvjMaK8ibYyIpfpOWqKZarYQaej98BpsskmeFNcT2/VZoDnIV1GZ8g+a0GTfNy odrMPU+2 rvG03fKJlaF7JLUhO/LFvG0xKNohzOofW5DWpnjPDImH3fihrwSOfpInh84NmomdCRsaS5IEukL2Yh9iYp2SCh1uP6aF/qLi3q2rRNnpTg1cMl8BIqUbaIFUgbwSNg5GKvpsdtwWo4UUglXatKibRDmG5hfqUXP5p801TQ6lkdeGjBQ+YIWatZiB42yUsnpi4E5ViYHdXWFTSJemKVeCbg4r0Iv3nOvSpnSk+4T0/ccxpYAywdM2fR9HXMaucpMLXJ7lyQ9riy8jqm5tQ+1W0c3goRsK65YlcSc9nimpXDgP/+j3wrBY9bsZw5qQcHKhcFLZ6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kuan-Ying Lee writes: > Since we introduce folio, replace isolate_lru_page() with > folio_isolate_lru(). > > Signed-off-by: Kuan-Ying Lee > --- > Documentation/mm/page_migration.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) This seems like a good patch to copy to linux-mm - done now. The patch perhaps is a closer match to what's in linux-next, but it seems that, if we're going to update this document, we should reflect the use folios throughout? Thanks, jon > diff --git a/Documentation/mm/page_migration.rst b/Documentation/mm/page_migration.rst > index 11493bad7112..1f8cc175d770 100644 > --- a/Documentation/mm/page_migration.rst > +++ b/Documentation/mm/page_migration.rst > @@ -69,8 +69,8 @@ In kernel use of migrate_pages() > > Lists of pages to be migrated are generated by scanning over > pages and moving them into lists. This is done by > - calling isolate_lru_page(). > - Calling isolate_lru_page() increases the references to the page > + calling folio_isolate_lru(). > + Calling folio_isolate_lru() increases the references to the page > so that it cannot vanish while the page migration occurs. > It also prevents the swapper or other scans from encountering > the page. > @@ -89,7 +89,7 @@ How migrate_pages() works > > migrate_pages() does several passes over its list of pages. A page is moved > if all references to a page are removable at the time. The page has > -already been removed from the LRU via isolate_lru_page() and the refcount > +already been removed from the LRU via folio_isolate_lru() and the refcount > is increased so that the page cannot be freed while page migration occurs. > > Steps: > -- > 2.18.0