From: Jonathan Corbet <corbet@lwn.net>
To: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: chinwen.chang@mediatek.com, andrew.yang@mediatek.com,
Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/doc: Replace isolate_lru_page with folio_isolate_lru
Date: Thu, 02 Feb 2023 11:02:11 -0700 [thread overview]
Message-ID: <87a61wvtcs.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230131062853.28449-1-Kuan-Ying.Lee@mediatek.com>
Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> writes:
> Since we introduce folio, replace isolate_lru_page() with
> folio_isolate_lru().
>
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
> ---
> Documentation/mm/page_migration.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
This seems like a good patch to copy to linux-mm - done now.
The patch perhaps is a closer match to what's in linux-next, but it
seems that, if we're going to update this document, we should reflect
the use folios throughout?
Thanks,
jon
> diff --git a/Documentation/mm/page_migration.rst b/Documentation/mm/page_migration.rst
> index 11493bad7112..1f8cc175d770 100644
> --- a/Documentation/mm/page_migration.rst
> +++ b/Documentation/mm/page_migration.rst
> @@ -69,8 +69,8 @@ In kernel use of migrate_pages()
>
> Lists of pages to be migrated are generated by scanning over
> pages and moving them into lists. This is done by
> - calling isolate_lru_page().
> - Calling isolate_lru_page() increases the references to the page
> + calling folio_isolate_lru().
> + Calling folio_isolate_lru() increases the references to the page
> so that it cannot vanish while the page migration occurs.
> It also prevents the swapper or other scans from encountering
> the page.
> @@ -89,7 +89,7 @@ How migrate_pages() works
>
> migrate_pages() does several passes over its list of pages. A page is moved
> if all references to a page are removable at the time. The page has
> -already been removed from the LRU via isolate_lru_page() and the refcount
> +already been removed from the LRU via folio_isolate_lru() and the refcount
> is increased so that the page cannot be freed while page migration occurs.
>
> Steps:
> --
> 2.18.0
next parent reply other threads:[~2023-02-02 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230131062853.28449-1-Kuan-Ying.Lee@mediatek.com>
2023-02-02 18:02 ` Jonathan Corbet [this message]
2023-02-09 13:10 ` Mike Rapoport
2023-02-09 13:58 ` Matthew Wilcox
2023-02-09 14:31 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a61wvtcs.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=Kuan-Ying.Lee@mediatek.com \
--cc=andrew.yang@mediatek.com \
--cc=chinwen.chang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox