From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17A6C61DA4 for ; Sat, 18 Feb 2023 08:29:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BABE6B0071; Sat, 18 Feb 2023 03:29:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16B756B0072; Sat, 18 Feb 2023 03:29:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00B596B0073; Sat, 18 Feb 2023 03:29:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E72716B0071 for ; Sat, 18 Feb 2023 03:29:33 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B3681120600 for ; Sat, 18 Feb 2023 08:29:33 +0000 (UTC) X-FDA: 80479738626.17.719A75B Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf28.hostedemail.com (Postfix) with ESMTP id 21CF0C001B for ; Sat, 18 Feb 2023 08:29:30 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=fail ("headers rsa verify failed") header.d=ibm.com header.s=pp1 header.b="Cakpu6X/"; spf=pass (imf28.hostedemail.com: domain of egorenar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=egorenar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676708971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:in-reply-to:references:references:dkim-signature; bh=/B1KfengwjDqZ4DY5Ku7JHkRAZJEEkM50wW+rCq75yY=; b=C7AOECysmH8fQCwguWiRmWODytr+EpGqxsUpMgOG4lvygmJhd75SMJIIoFOICrh64s+ZyI sibYHlL8VmP7oaKoY8jT5VDdeRDUJrISOJPJ+tfAcGDeVPCbHkAI4emKv9fVKkOlpRUOE2 3hfUJZ+LnJ4dqLWPqslJKAktLXys20k= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=fail ("headers rsa verify failed") header.d=ibm.com header.s=pp1 header.b="Cakpu6X/"; spf=pass (imf28.hostedemail.com: domain of egorenar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=egorenar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676708971; a=rsa-sha256; cv=none; b=ds1lFn+vuBYd/NG3L7R9T0qARc1QnUccZGmpv7PT5fXcxnJyAQTatwZGP1QhSuIuSozfo3 rXJv2O5Yj+7aM3K2MCGQ8lfmjAp8PrFQzSv1NGEP8uGHgAGZhON+wEeNMdmCTAyx7gfWbM wCstwCcAXROHt0Bbez9dnYjOGP12jXM= Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31I7l15E013923; Sat, 18 Feb 2023 08:29:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : cc : subject : in-reply-to : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=/B1KfengwjDqZ4DY5Ku7JHkRAZJEEkM50wW+rCq75yY=; b=Cakpu6X/2DFnNf7hvDmOCSoX2Kk6LqT5fkJ1gBgrfR6dSu/EyEDeg0nrRQRmY5zXowjf EUYChvgTxdpk13pk4KIH6k0bLRuhQXqKw3UFXjHf+7qNE+se6mvOmNeuzKL/aj1VPOj3 VmXP1HjZ09uAua4DFs8nHqH4mnsmcrdILsOeChK6gDkmI5+DnhGX1G42xh+1yFaTcHpi 1d2YfBWbeL9nmfhrNY0/E+HJq0t2IRCLStTGCrxYevz4Nu40FdyW3+Z5h3WpaTw7kHO8 w4QYPg2tpauSeyfZxENO/1XfXfHWwaoat59kY/fi6+kXRqDRn5/2dXGLIcoKh+fW8h72 AA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nttkc8gy4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Feb 2023 08:29:16 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31I8S2rV002930; Sat, 18 Feb 2023 08:29:16 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nttkc8gxr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Feb 2023 08:29:16 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31I2t4nT031088; Sat, 18 Feb 2023 08:29:14 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma01fra.de.ibm.com (PPS) with ESMTPS id 3ntpa68611-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Feb 2023 08:29:14 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31I8TBxs50004352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Feb 2023 08:29:11 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C3BCA2004D; Sat, 18 Feb 2023 08:29:11 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C45620040; Sat, 18 Feb 2023 08:29:11 +0000 (GMT) Received: from localhost (unknown [9.171.4.125]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Sat, 18 Feb 2023 08:29:11 +0000 (GMT) From: Alexander Egorenkov To: David Howells Cc: dhowells@redhat.com, axboe@kernel.dk, david@redhat.com, hch@infradead.org, hch@lst.de, hdanton@sina.com, jack@suse.cz, jgg@nvidia.com, jhubbard@nvidia.com, jlayton@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, logang@deltatee.com, viro@zeniv.linux.org.uk, willy@infradead.org, Marc Hartmayer Cc: Subject: Re: [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE In-Reply-To: <732891.1676670463@warthog.procyon.org.uk> In-Reply-To: References: <87a61ckowk.fsf@oc8242746057.ibm.com> <732891.1676670463@warthog.procyon.org.uk> Date: Sat, 18 Feb 2023 09:29:11 +0100 Message-ID: <87a61b9y20.fsf@oc8242746057.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 6U8DH4_SJ9EcGSWRq94cisg3kdYaZ3TG X-Proofpoint-GUID: j-cDcyU2EI6447zlfftD4sjkH6r12ZRB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-18_03,2023-02-17_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 impostorscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302180070 X-Stat-Signature: ozd7zbkotft3y1wgcxc7qd8pu77h8ikt X-Rspam-User: X-Rspamd-Queue-Id: 21CF0C001B X-Rspamd-Server: rspam06 X-HE-Tag: 1676708970-750583 X-HE-Meta: U2FsdGVkX1/n4r2YS58d6CPIKatdEro/ngNYZAOX7KORt1dgVlIJWo6zv6BeqrhBIYpXOW27oKSSyTmc0IUVbzMYZ5MtTS8rZUiFXOoB5loaKEUT3muo3VITKW9gxKkLgNRBjJZJyU9ynj2XmGw5GU/ox+7gjJhZZsKelQLmjwUswZzFHBD6OvfN46Dxi1vLk7lihwF8k108Ie+Hyi245BxXoO/ViTSHGMEIlEMeXWqQTsjw3dGtjUSeT5Njb2562eTOLbtrYfrAHujuv25JIj/TwuFJ3j6TZCMJxWFHEl31Uj9UXBqAWU/y1ofZ5W43ds5jguIEyGweRCZZvehbLWP/Ry1QuMq6vARuYCdkfmOrcWqY6Ejjs9aFBCEOCm5cHi0Tkpdlegw4/lNGZxr8XvvmpTf8AJ7rb2Mek7Q4uV6vxtn5vhy1SAlzMuw4foK32IMBGSQjWRDZR2EzZT48rB99pXA5Gg8JYVF94s5beiIP/D0XskmNfDeatPMP3sxkuRfUGsOraf/2gn9SSUWl6tacVhwNdLn3dPO0jldTnN2xZTAV0wxBxIW1vmn9dl2L2YIa+0qfv+9k7ZX4J08/acFhkowyEllAMnO1bcB1rEPxssY/7XOfVB7wA+cSzOb9OfHxPeuoAQedBXsB1of8PP4qTkAsOwwtrN7mhIdDshjF3YATFBgrvHLVzX7NmXnbfZ7jXF13tgTROCi+4xnTFtxhbIKnWN7nTQp2dOpJeMamKOsWYDbyFtQCD8ZC/prYRFXblo28Oq/j/40vCP6lB8kVOgJnEsIxWaiQcHRa37A/+CNOPrVNoko32ias/mUGJ5j0Qt/MvEcUyYHhh7kqUvAID7KRK5kqJduOiYyYeY2DQeXaOaJuk1xwDWbHEvPZ0fp3JbeB6Ib76KneeRrs54ENi/Obkt/kIZQN8GWWRRypIsAps1NvK/+bLhV1mCYv3vqo9VyUPGw0AJUBuya Pz/jtz24 JpOm/1lRgQaDo9mmZyKgjrwBnIK7v+tLVb+p1SntzJVUUwfGohnHDci1+KtYgfUa1n5YCT2ocb8+pAOny9+BhWuZ2qEAoaCmJng4Jsh1LuBjcVJOz2VxmHprhAuk2XFessvYgiajiHZhvnztWz3hjHX5tStUsS+FftnrZWcjcouCRCej5bAIJ7KbMNUfWaYm1nubx9ZYk3aBNK5KuMTIjM9BeQ0orfExbe7b4K92ivPmGaQSRDCV6d2UZzalSFpHhXVgU/37+EtZ+5lAoVRURZUEiR1dgtoM6ksxm4gyPJsawtHj5mJBIq8CfEYpxGjJQRVCoocOX2oL2rVend0CwEQ12ahkeFeuQazx1jcQjBTgLB5A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi David, David Howells writes: > Does the attached fix the problem for you? The data being written into the > pipe needs to be limited to the size of the file. > > David > > diff --git a/mm/filemap.c b/mm/filemap.c > index c01bbcb9fa92..6362ac697a70 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2948,7 +2948,8 @@ ssize_t filemap_splice_read(struct file *in, loff_t *ppos, > if (writably_mapped) > flush_dcache_folio(folio); > > - n = splice_folio_into_pipe(pipe, folio, *ppos, len); > + n = min_t(loff_t, len, isize - *ppos); > + n = splice_folio_into_pipe(pipe, folio, *ppos, n); > if (!n) > goto out; > len -= n; Yes, this change fixed the problem. Thanks Regards Alex