From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52BCC77B61 for ; Mon, 17 Apr 2023 02:28:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AD438E0002; Sun, 16 Apr 2023 22:28:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 435AF8E0001; Sun, 16 Apr 2023 22:28:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7038E0002; Sun, 16 Apr 2023 22:28:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1F0DF8E0001 for ; Sun, 16 Apr 2023 22:28:45 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EA121C032B for ; Mon, 17 Apr 2023 02:28:44 +0000 (UTC) X-FDA: 80689299768.30.C4F47FC Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 5A127180016 for ; Mon, 17 Apr 2023 02:28:42 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QRwDgPrw; spf=pass (imf16.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681698523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AS9iD0/eNxhvScrJb/QuAJnCmMK/FCdje6Mt7nLnDG0=; b=GFrHJdvAW3veY0o9j8D+EjkUFWFMnVvn0ecZq66CxB0pLmMU3SYPtFLMj11d9t1ha+EqwN jbz0PAHsbmGXkNwvzJViV52E2pxv9C0QT1+0PTao+RgiDea87g+tHhZKfV+DhKawIiElex jAay8CBqTCf+P1nzRMV9oj6LRJSvkpM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QRwDgPrw; spf=pass (imf16.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681698523; a=rsa-sha256; cv=none; b=gvfg1xjyoRc1eOGYOaRmQtM7ix/4JnjRsn1LlLcGXxEWHOyXr6h5NWs/JAiggMLDS/kw4l dEhvbEAsNaWOsNYM+F6P1M4zg5MgTHyfe78vmXezcusZEoqr7a3W2ouTythviuVXym5T6o ixmjZ5jdmphkRRzF0phXNXt8OL7Cako= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681698522; x=1713234522; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=k4gAZozd+Yrw3Ljl8MgCxDpqzd2X7xRSXq1bELURyF8=; b=QRwDgPrwSDDiQFBZic1su2bIyS9r9jcfYmJrwE2yaOS0jmIpfU+hgT28 pZoGxdIb9r3RslI0reiPJp3lTZXlR60NgBBt1WvB14mXb0gjDDNubwjds M6XQgCGTBTgUbDsD6J074LNwAtNrC+erLPeizBxE2SxDTH1mtVrfuWLdY vH29fDiooBtdvekeB8lzfkqaKDhzdTAkMfF9Hh5393TJ3jQDfRh+YDuNJ rjpAzRwx/zLqM+0hb+tEaf3TLVd23mim1KyLFgTmA8ALZ1dWmGyNcf6KG HlSnwo6jeZfqaPCZvKYSC86MYQVr2dpizPLq2xGKWhzcO85lvUAb+EiUs g==; X-IronPort-AV: E=McAfee;i="6600,9927,10682"; a="431079193" X-IronPort-AV: E=Sophos;i="5.99,203,1677571200"; d="scan'208";a="431079193" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2023 19:28:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10682"; a="667954169" X-IronPort-AV: E=Sophos;i="5.99,203,1677571200"; d="scan'208";a="667954169" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2023 19:28:18 -0700 From: "Huang, Ying" To: Matthew Wilcox Cc: Kefeng Wang , Andrew Morton , linux-mm@kvack.org, SeongJae Park , Hugh Dickins , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: rename reclaim_pages() to reclaim_folios() References: <20230415092716.61970-1-wangkefeng.wang@huawei.com> Date: Mon, 17 Apr 2023 10:27:12 +0800 In-Reply-To: (Matthew Wilcox's message of "Sat, 15 Apr 2023 17:04:05 +0100") Message-ID: <87a5z7w8e7.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: ymk7gq3t3mtbjyzhuk816w78q4pj6txq X-Rspam-User: X-Rspamd-Queue-Id: 5A127180016 X-Rspamd-Server: rspam06 X-HE-Tag: 1681698522-733518 X-HE-Meta: U2FsdGVkX1+vAbzqZckbJF1gLtqxYkqoalpUdgn4xlUtu87HvzkKD7C+F3ckbH+4DS0lQK1fR/Co8709QYBcy9oInRWC/Q4TI19Kc6jR+Kg/oM0RB2klXOYOVXq+4e4Hq3DY9Rs5UJDHjMne+ptv7XdKYoSjl8+30sxN1v6aPWUg8UW0O4OwCNpwwCnHqwyS2mg9+dKwKTodpstpgMRkpgmXdGdTjjEMgG1rajAjmCL4BhKIo/HvnYqMn9cYcYJVh2MHErvcOg4s76KGGffuYxrmTGFSZLvgE6GwLoz0rzwONzJlswXWT9pLi7rwIOAanrYyBtg2QuZzewrkB8u0eAfyTGdYa9e3r9dqnoszqfe2nE/juVF9fvymbVZUb0mwli4n52eZ8Pp23iB16EJYAOj3QCLAgjjww5twB5X1l6BD/2HmMTRrpapih/MIzoatVkGQFQebpuT1DEQJuYRu69Vhi0j5GjNWB5QKjG1huUZ13LJXzWNzaGRvVvKVWrAH2bCaGckvXxqZv9uG2PI9kZKBbJt9o3QwqMQmRARqIf5+iGB3/Ld09LXrGgGKWbGyKeGRkroZEtsqIoLScCGtJZSu0z4XMvJRfkqlpGPPQgksUR4ZnX3ZGR331a7sOWLkuJf1jdLPXqvI3IkFwKwb9+gqpj5P4NdnduUpgy+7L8JihXSpBHK7OgFI/JsJKuSyOM3vtufccW7yvTfpYM32a9TKlaLv227ylNq+Mq13EdFnTvcnI1gTZkhXB0g9MZ485KSQKFPoS6BEy6V4m/y1jVwgmuWslPvx8RHiF+A8xhRmrvBAehGVrSm9H7oN1I0RxN9myanACfLLiiTuj/SjO1jTrz+lLwYWRUG9QGMc8YY2m076/lFVh+x+8PKrl/hprVn9CPQJg4WOAlNgwSqt21WzAWSy8YeTs8IzyepxUYdn0d+ztIa7Wnu8U7aO2Mkd2Pjf1YJvixmPkaFkfjt 0n80E8Og VT6uNcuW3Q1SCl+MDEKpv4iT5/3u2MTqUivGcIQJbR9N9/eSOQjo5lHYIZDbwHr7M+x6inIY/gj5E9s7ohiCtgco+xbPeG8gCR08VBG5gMatyYN+Scb9SwcqGhw40dEBXA0GegDIjYppZIgz/982yz0bVlV6cFlmV2ky89XejRfcKP5HBXJeSRJ1Vasi+LzUP+2DDEn9yvIkNebQBzmURS+evPszYK7Y+cApP9rkUZ6tBmAWD/GfXRjXtbzFV6AtxtnXtZquYCbHELEc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox writes: > On Sat, Apr 15, 2023 at 05:27:16PM +0800, Kefeng Wang wrote: >> As commit a83f0551f496 ("mm/vmscan: convert reclaim_pages() to use >> a folio") changes the arg from page_list to folio_list, but not >> the defination, let's correct it and rename it to reclaim_folios too. > > I didn't bother. It's not inaccurate; we're reclaiming the pages > in the folios. What's the general rule about renaming "pages" to "folios" in function names? I am thinking whether it's necessary to rename migrate_pages() to migrate_folios(). It's unnecessary? Best Regards, Huang, Ying