From: "Huang, Ying" <ying.huang@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, SeongJae Park <sj@kernel.org>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: rename reclaim_pages() to reclaim_folios()
Date: Mon, 17 Apr 2023 10:27:12 +0800 [thread overview]
Message-ID: <87a5z7w8e7.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <ZDrK9R9wLlfrUWMZ@casper.infradead.org> (Matthew Wilcox's message of "Sat, 15 Apr 2023 17:04:05 +0100")
Matthew Wilcox <willy@infradead.org> writes:
> On Sat, Apr 15, 2023 at 05:27:16PM +0800, Kefeng Wang wrote:
>> As commit a83f0551f496 ("mm/vmscan: convert reclaim_pages() to use
>> a folio") changes the arg from page_list to folio_list, but not
>> the defination, let's correct it and rename it to reclaim_folios too.
>
> I didn't bother. It's not inaccurate; we're reclaiming the pages
> in the folios.
What's the general rule about renaming "pages" to "folios" in function
names? I am thinking whether it's necessary to rename migrate_pages()
to migrate_folios(). It's unnecessary?
Best Regards,
Huang, Ying
prev parent reply other threads:[~2023-04-17 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 9:27 Kefeng Wang
2023-04-15 16:04 ` Matthew Wilcox
2023-04-17 1:51 ` Kefeng Wang
2023-04-17 2:27 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5z7w8e7.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox