From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6D7C77B75 for ; Tue, 18 Apr 2023 03:19:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BABC96B0071; Mon, 17 Apr 2023 23:19:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5C6F900002; Mon, 17 Apr 2023 23:19:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A248D8E0002; Mon, 17 Apr 2023 23:19:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9425E6B0071 for ; Mon, 17 Apr 2023 23:19:03 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 61B2A405A7 for ; Tue, 18 Apr 2023 03:19:03 +0000 (UTC) X-FDA: 80693055366.08.5E04D74 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf06.hostedemail.com (Postfix) with ESMTP id 3FDEB180019 for ; Tue, 18 Apr 2023 03:19:00 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Rkq1qZlA; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681787941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9dfC7zbTWbsz8OJZn2UtS2p7a7tW0dSte/mzDVRlY+E=; b=XKD2doNRsMQFEGMsTGWl1/UdVIUj6QaTGzW0OBrQpgMepZWKilmEEiYyK642omnHx683yF /rl0B5ag+aCltt9uUZrFHAGCctA/KtmHc9vBKZoa1IymBtFQ257Uz/x3Ji52KKCKI/tDD8 4K8BRjCsrxkB/SMO+hUkiTmaopRIhpY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Rkq1qZlA; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681787941; a=rsa-sha256; cv=none; b=1MjD1pOenvXZX7t/VFTLWvlSgxksQjbAQXbko9ZlddObc8LJsU3ByWM8X136tM3OisIz0/ Zuysg/NFdGmwc/WhI/JdWxQip6hXUSOomEXoR+16I11EtkPH9oQIimgs1UiXgw2+AxUKlu rHF2JZJdD2lrTJEsY7Aj7lPHx8ocGfQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681787941; x=1713323941; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=gT+D5YtuQoJ6bOdWxtXhnLJmmnVqK24v1D+Tt8JeRnY=; b=Rkq1qZlAjEUl9FKWk2O5znSCGGmGqSzYdXMXyVOsqAUOBDlRv2WExOaa yV1se6jmmCYXC9bERhdRlRRMKGyL+J6KzNxkdqwer+8+UYUpZW9yyY21z PVGvRkQ1L+wD5P0Ihr+giqsx4XBtU2TsnlSZRlqFnwn+8X3iQBMLnUHG8 W0ehN70AZR3ysVAc7DEgEU2F7TF34d8f8TcJMLLAGKuJUahSY9hNYlY4F 1iVniS1mNy3QoSF1DxyklQcfvCB06v7IQiNRr0dsn7++Js/hbsC03pfxW 0XPm5yy/V8wRQr2tJiUE/qdNoRkG9IsRnGGe8Bf8lrnaN+XV5RhaomPRD w==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="345061345" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="345061345" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 20:18:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="780352365" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="780352365" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 20:18:56 -0700 From: "Huang, Ying" To: Nadav Amit Cc: Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , kernel test robot , "Mel Gorman" , Hugh Dickins , Matthew Wilcox , David Hildenbrand Subject: Re: [PATCH] mm,unmap: avoid flushing TLB in batch if PTE is inaccessible References: <20230410075224.827740-1-ying.huang@intel.com> <402A3E9D-5136-4747-91FF-C3AA2D557784@vmware.com> <87zg7f19xu.fsf@yhuang6-desk2.ccr.corp.intel.com> <87sfd5zx5b.fsf@yhuang6-desk2.ccr.corp.intel.com> <03BCE979-33B1-486F-A969-0475A35DEBB5@vmware.com> Date: Tue, 18 Apr 2023 11:17:52 +0800 In-Reply-To: <03BCE979-33B1-486F-A969-0475A35DEBB5@vmware.com> (Nadav Amit's message of "Wed, 12 Apr 2023 17:00:49 +0000") Message-ID: <87a5z5vpy7.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: mkjxku4yps31draay7twydcdxin35dfj X-Rspamd-Queue-Id: 3FDEB180019 X-HE-Tag: 1681787940-345361 X-HE-Meta: U2FsdGVkX1+8yb85c8u//DWdOD/lXMF3pOCatF9qNCtOejiyjoHh1wkNnlT2b40jrqTGx4y7duL2R5OuM5UND34B6GnjrxTkerrIlpyMD4PZn42Tx0MjTvfrXnJOSa3TMYU93VOxrxPxu/W5TrrMqgfIEMULcXFqPlmzkubr8Rz++Lf3e4BY+W9ynqpl7jEvK40XOUVpAol37U/Uin4JI4dD+Y57RH1jpltmfClomeevl9Ec3e+ES6CPeyjtuL1SKga+GmopbO/Mfcyx4na1VsUw4S/R9ERqO6xmUXIFzgsTepqEa/t3uBcA/pPGynlR8NkXXYdT+/tHiQMM3fiUYU4dPGdsiinnVzK89QXHVWauoyBHQfE06NFadqyZIQt4FoJZPoaxeX3uTUk5NiybLHBv6eWXahCObiUhBi8B0iS18DHBRmtonyPB2hyDyjTOsy5aCVu2yby5xoZKgaancLzLI8cmrlLqXlZlWBFwADFoXrnN8yRPaP0qPcHu3f/pdVGWwyUc9mvUv6pmHlZWbd8EMT1SeVC9jyCVjgwFUtWgdn7aLRpq5SJhJOiy/QcndBqAfDksH8/2LJSp+XuGzT9ChWJMXyTrzpNGzI/EBt7/SrtEOxTsv73nU1bIl/1uX183gt1Mk+bGiFX6M1SE7Lf4512WOZxgbm61AYMRhAmZNYE+t6F0apGzCBMAX/wYNwxDfHmanOJyXsMnxGCQCdbRNFnRvEs5EV8mX70J5Trv/HGbPwUBrr+64tao0xWtKWXeeSuTI7bq7/7jfz18eGNjmM86NEJVqM5ul7tsjXqeYQ1HGxQkf2pizhorcTDfFfOkyWEWtFBqd/MU2kCTPBQ+VuO8PRkgc2YSJWWv1gK+hG+HqxNlFyhyGbH1U6KbLZbUBS3Lo609LruFDzfug+33HcWUaXW/ghtGs0zk7y0TU1R5rvyK5lWsAMNVB3MJSUxjtMKx3NixX50spAu i8Q8U/Wl 3m1l5XQr1mc6SS/1xbgGNrW32CLan/gz+a3rwLzNnGsjxSnhaiaybfXaACSWkvm48B6HgvTv8O+Eo9kclecLCZIjYxpC6sCeK0uT9eWi67Rn3tdKsMSCngAfPyQmLjytkitjJLRTzepI8Pz7gB3T4javQ/JH7zKhVjizBFN0tIrU8lqgJRTzemusNNx4ldMLBtvErVgBAyrngIF2IkIYZOj9QTBgAo76/A0iC8fkWsVxl2Ms5EOmyzIqEzDmJn6t7thYtr61yXFMxn9E/wFf33xn1D2VK6ltKiQs56pXFoeSgxVM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Nadav Amit writes: >> On Apr 11, 2023, at 6:50 PM, Huang, Ying wrote: >>=20 >> !! External Email >>=20 >> Nadav Amit writes: >>=20 >>>> On Apr 10, 2023, at 6:31 PM, Huang, Ying wrote: >>>>=20 >>>> !! External Email >>>>=20 >>>> Hi, Amit, >>>>=20 >>>> Thank you very much for review! >>>>=20 >>>> Nadav Amit writes: >>>>=20 >>>>>> On Apr 10, 2023, at 12:52 AM, Huang Ying wrot= e: >>>>>>=20 >>>>>> 0Day/LKP reported a performance regression for commit >>>>>> 7e12beb8ca2a ("migrate_pages: batch flushing TLB"). In the commit, t= he >>>>>> TLB flushing during page migration is batched. So, in >>>>>> try_to_migrate_one(), ptep_clear_flush() is replaced with >>>>>> set_tlb_ubc_flush_pending(). In further investigation, it is found >>>>>> that the TLB flushing can be avoided in ptep_clear_flush() if the PTE >>>>>> is inaccessible. In fact, we can optimize in similar way for the >>>>>> batched TLB flushing too to improve the performance. >>>>>>=20 >>>>>> So in this patch, we check pte_accessible() before >>>>>> set_tlb_ubc_flush_pending() in try_to_unmap/migrate_one(). Tests sh= ow >>>>>> that the benchmark score of the anon-cow-rand-mt test case of >>>>>> vm-scalability test suite can improve up to 2.1% with the patch on a >>>>>> Intel server machine. The TLB flushing IPI can reduce up to 44.3%. >>>>>=20 >>>>> LGTM. >>>>=20 >>>> Thanks! >>>>=20 >>>>> I know it=E2=80=99s meaningless for x86 (but perhaps ARM would use th= is infra >>>>> too): do we need smp_mb__after_atomic() after ptep_get_and_clear() and >>>>> before pte_accessible()? >>>>=20 >>>> Why do we need the memory barrier? IIUC, the PTL is locked, so PTE >>>> value will not be changed under us. Anything else? >>>=20 >>> I was thinking about the ordering with respect to >>> atomic_read(&mm->tlb_flush_pending), which is not protected by the PTL. >>> I guess you can correctly argue that because of other control-flow >>> dependencies, the barrier is not necessary. >>=20 >> For ordering between ptep_get_and_clear() and >> atomic_read(&mm->tlb_flush_pending), I think PTL has provided the >> necessary protection already. The code path to write >> mm->tlb_flush_pending is, >>=20 >> tlb_gather_mmu >> inc_tlb_flush_pending a) >> lock PTL >> change PTE b) >> unlock PTL >> tlb_finish_mmu >> dec_tlb_flush_pending c) >>=20 >> While code path of try_to_unmap/migrate_one is, >>=20 >> lock PTL >> read and change PTE d) >> read mm->tlb_flush_pending e) >> unlock PTL >>=20 >> Even if e) occurs before d), they cannot occur at the same time of b). >> Do I miss anything? > > You didn=E2=80=99t miss anything. I went over the comment on > inc_tlb_flush_pending() and you follow the scheme. Thanks! Can I get your acked-by or reviewed-by for this patch? Best Regards, Huang, Ying