From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F816C77B73 for ; Wed, 24 May 2023 12:56:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8700F900003; Wed, 24 May 2023 08:56:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82076900002; Wed, 24 May 2023 08:56:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E8F2900003; Wed, 24 May 2023 08:56:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 533EA900002 for ; Wed, 24 May 2023 08:56:00 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2166216026F for ; Wed, 24 May 2023 12:56:00 +0000 (UTC) X-FDA: 80825146080.21.79D065E Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf15.hostedemail.com (Postfix) with ESMTP id 4CBF4A000E for ; Wed, 24 May 2023 12:55:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=xJyNpkoh; dkim=pass header.d=linutronix.de header.s=2020e header.b=WAAM8Sl2; spf=pass (imf15.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684932958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cjBbmqCtQ0rQrGc8hZTZzidR+FIywD+hRroL0+8rcPA=; b=4+61JzUhrZHrUv4/hQpPj0TdzAss/Pdt8pVQyU0QRrzsrZdiPCeolY3VrwztprSNkGaHb+ RnglPn9n+8XFs+ljtIRlOdGNKcV/PWOISjRh1lA3MUQNpapWTDdXqsFECaHNeeWvx8zNzm +a/Y3p1ZF6pfsH8IgDg51g5YwWDCYJM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684932958; a=rsa-sha256; cv=none; b=8mQfOsc6CqhJStsacUV6w9Pco15yRwkrBjFh2DLm5+ugXTm4qTYspFWIWcFSp6+jXbtGkj 5lQ98SkcLx/MQmTeaeX7wdDdSCxB0DR7V/CcaPlV//FQ49vtC7XDcFktADwV8L6KWrTuDB dc/IM5NVZBNm7dutZmK8sNxgpW2B6vg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=xJyNpkoh; dkim=pass header.d=linutronix.de header.s=2020e header.b=WAAM8Sl2; spf=pass (imf15.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684932956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cjBbmqCtQ0rQrGc8hZTZzidR+FIywD+hRroL0+8rcPA=; b=xJyNpkohRhRxs2p8fWMGI28YhYQAk5/SmQ/E7wnvtTCvuMumCMpXo1LIGiQPmSfDKopcJv s58Mwsn12Kv5r+4sCGbvCmwTf/QHy0iS/YUwcc3GlW/o8ceuFuc8crdI9OGpWQWqYxWztK kAGACkq5t2rECUn5t4YSbjGdtqMI2I2OLznhnT+O5hhM90e4hSGhKITavxLJHCOACUeNEv 6nelKX/acLuhXPUrH4YmaU87UpfP8T8IYalz2M0D8mkU9uLQxYcJBRIPCMiemqHmZsyVh8 6whfcJYxTNgd986kexkmm9SZsLFTqLcT19NT1QknseYD5D4Z1r8VcBeKGcIPQg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684932956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cjBbmqCtQ0rQrGc8hZTZzidR+FIywD+hRroL0+8rcPA=; b=WAAM8Sl2iJZLUGgyf0aRdR4s0Bbvl9ETFXut3gLbGhqUNboFdQcCg+SLjowJN8ZEh5kSXo Q/oPUmZDwJ0K/fBw== To: Baoquan He Cc: linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra Subject: Re: [patch 6/6] mm/vmalloc: Dont purge usable blocks unnecessarily In-Reply-To: References: <20230523135902.517032811@linutronix.de> <20230523140002.852175941@linutronix.de> Date: Wed, 24 May 2023 14:55:56 +0200 Message-ID: <87a5xtnb1f.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4CBF4A000E X-Rspam-User: X-Stat-Signature: oy8cu7q3e64awie9waoup6a6skh8tcpr X-Rspamd-Server: rspam03 X-HE-Tag: 1684932957-158179 X-HE-Meta: U2FsdGVkX1/AdGiYFCDCLTBLqXJHa4n30ZxP9gHHGEwLeH2EyxnGvG07jVf44RFV5MHQgUQDxapP6AWlNtf+TGr2hg2XXkOgS31bl0XHp4+LQgCKx5wOmrWneS3x/TVfw4H18onLqkDiob4cV1gVhKwkCUSmpL05TyCHLFxDHyONbZ0/SZVll6yLs0lMgqciyq9lZlj3SPeD6iP5/ibpdNjytpcaswZJkNxPpuibmt3GeCep5PVPzzFj6WS+gOdDG4gjI46cfAQ5lvgBYDQXfJ0EpWs+yXNB+dp40luc7Ef7/WS3KQZw83IssqwTEwBXIoC7PZxnvKClNXJtrAe8O7u1k64EcvH1usljct9qsW3IGsVLI6hQAlwc5/mQ7JEkpd95v5sjjWx9uex3C+xIRs5ksCjcfnkEFyIA+OHce+9JAXQCBzA8EhtETKhCKGqnKZ95ygo+EeR3SEdH79edU1DOd0mXnLyzUHqqcdLEdUkS9DB6ICIvRC75mTtM+yVnQlWoCtevjYs4uCYaoAo5S2aD9wUjkCjC78Ty5jztgGjEzhYaewM+FzDYQONpay2hFNZuwyuWpoihdqkGCpfWo4B4jaV9MdRy2A8kj4RGBkELTG+hSS7CI5QU3Bo8JxYqAG2Ww3AKqLG3/rahAn0RbSNmPRucF0zil54BOCceTbgdM+Va4H5ngf7m2Bq+Pdhlycp93IHF85kzpugwZfpUmi3VpHj8oc/aFSfmOOeVBrCSkKBl2zNG6876XUn/G13rsxKvPpwJWK4meJjlcX92mipbMZqdg/vjSk7zjjnPhx+V19J+TCaKL9BcBhzcDSMAXpCwOGzTscRSWVv04jcLLGOQ7TIIHzf+2RfY1ZCf5E7Mk/GDv7iq6WZPof5cyhcdhrz9QdYHFPVw3T4wuKSYlh/4W3SImtQi8idFxdcGpmRCmxCUE+uvw33f2Tdrbs8UCAkndum70cf7jfX4NPA WVVmFN3X vp4/00QYWa1KKKylWgPOK3OMedr8w3y3AAd6CvjlMvKG0qdU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 24 2023 at 18:34, Baoquan He wrote: > On 05/23/23 at 04:02pm, Thomas Gleixner wrote: Can you please trim your replies? It's a pain to find them. >> static void *vb_alloc(unsigned long size, gfp_t gfp_mask) >> @@ -4173,7 +4183,7 @@ struct vm_struct **pcpu_get_vm_areas(con >> overflow: >> spin_unlock(&free_vmap_area_lock); >> if (!purged) { >> - purge_vmap_area_lazy(); >> + purge_vmap_area_lazy(true); >> purged = true; >> >> /* Before "retry", check if we recover. */ > > Wondering why bothering to add 'force_purge' to purge_vmap_area_lazy(), > purge_fragmented_blocks_allcpus() if they are all true. Can't we set > 'force_purge' as true for purge_fragmented_block() in > purge_fragmented_blocks()? > > alloc_vmap_area() > pcpu_get_vm_areas() > -->purge_vmap_area_lazy(true) > -->purge_fragmented_blocks_allcpus(force_purge=true) > -->purge_fragmented_block(force_purge=true) Yes. purge_fragmented_blocks_allcpus() has only the purge_vmap_area_lazy() caller left. > And one place of change is missing, it will fail building. Already reported by Uladzislau and I sent a fix in reply.