From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DACB6C77B7A for ; Tue, 6 Jun 2023 23:23:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67D4A8E0002; Tue, 6 Jun 2023 19:23:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62D428E0001; Tue, 6 Jun 2023 19:23:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51BCC8E0002; Tue, 6 Jun 2023 19:23:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 42FB98E0001 for ; Tue, 6 Jun 2023 19:23:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1E7461601A1 for ; Tue, 6 Jun 2023 23:23:40 +0000 (UTC) X-FDA: 80873902200.24.B23D5F7 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf10.hostedemail.com (Postfix) with ESMTP id 698F4C000D for ; Tue, 6 Jun 2023 23:23:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=AXZoxQDw; spf=pass (imf10.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686093818; a=rsa-sha256; cv=none; b=8rnKuIin1QkiHPj12k6nmZORdRf4zcnD/65X7HXrtOT4scG0I0W1iGb00axE+mQwC5gXCM bVFMwWoeDxkr+pv3ygSG/AcKkyfwZBhyXmYC04LS59cZWUsL7sCsHaI3wPs9aEj/87wL+K X5E8sow8qFlYhgSdrROne/yiQKIOi24= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=AXZoxQDw; spf=pass (imf10.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686093818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B9rC28pDVp3JnlueCNsKy/WRFzMnmaVeBbX2EHevunw=; b=Tbfx4D5QqWSOJ+zV/tUCwV/XB4mlee1ZjXoo/SYEHh1FLy7jv0ZZ+1O/XsxDPVoFq2nXUn DNUsEpidE0DMQH78nAWtn45GmdT4a+0le9G1P4DrhBnwxjR5fEnd3G1YO+x0D1Al+mU0aR wjhRR/5y6jMRMckp2pcMF2heIXZCNI8= Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QbRP24tbZz4x1R; Wed, 7 Jun 2023 09:23:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1686093814; bh=B9rC28pDVp3JnlueCNsKy/WRFzMnmaVeBbX2EHevunw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AXZoxQDwqSMKCAYWKROI0Ak6EPJTjMlSRmZI78oE9iPxlQ68kJ72tR+YgOlCHXAUm wf+mSlkkXBn//CAWbGevsbdq6WYnUbFS5YiD47Gzk4JzVySmgk1F2W9W+zXQj1RQHq 4mbFD34tRAMXlTyCOAYNFZFJHFLAEw5DTqriZdjObBh72x4Wlk4ODKxMdq0RatTkdR IF9DNXGRoBw77vEHoA7YVhgNdqYc0d7zg/KcCp+izku259RlhBfDXkalnAxFN4jomU d03/K/40ffyHttQm3MQy+cI/Zzt6cqJozG5BxKUlZ3/tbmSu3Eh3SeB+52NJI0z1C9 lzwyVhvc6sFHw== From: Michael Ellerman To: Nicholas Piggin , Sachin Sant , linuxppc-dev Cc: linux-mm@kvack.org Subject: Re: WARN at kernel/sched/core.c:5358 (kthread_end_lazy_tlb_mm) In-Reply-To: References: Date: Wed, 07 Jun 2023 09:23:27 +1000 Message-ID: <87a5xcgopc.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 698F4C000D X-Stat-Signature: en4p57y8csret3is39czyp89hjtp8wfo X-Rspam-User: X-HE-Tag: 1686093816-255258 X-HE-Meta: U2FsdGVkX19Oyz4612A5dowE+bAtWVeqUWOXM21Ai1NOBYY1cAvi1P1kwRJG0O71B2xTIdpnqUtERg5IWXlmRy/RXYpALvsPIBnjgMqHdkZhbntmGJ3/TZJIyEjc/g1TDz/Sq89pikLddyAVBuKXVmUdMcZOhKkUSCnl28CR+hk/27+551I0L8A1GvR/5yRFVqKy4Z/s3AoZc2vylhk7RHZjj5jpQAMb2q+XcUSq01BylKKx94MGYt0l6sCj7O3oa3s5658krU3YVOFsXp5yEc8MrBeHkh1Ol6xLw1H6sbyw0AgTd/AF8/05cwzggdQsOEo2wlWGos84l/+SM6j8DudId7Ucs6aUVU1Gl0llK5psh0dtKHbXQMGlFOJobjfKyceWIqq2vhCjldKPNRY+vSK+WZJO1bYY/1RYhH8cIgkRz0IgUFgaalOy4JcrpljXe+G5qIDuEiDcwarArmH7UJUpO4FGZsl8MtkzNnLNIQ93bxPFXloPVHlA8BSUEMOCNK0xDfqhhO1VRBH8G8KMqKUq5sX+vQS/r9cf/A+wwAspenEL+MTC3yy2MipAhaEXofhHslRnO6qu9/oVbzLBPw9CX7ySDg5jKy0c13QzbciYQCmdENfGcxYMZPagXKuLUz11RfzTLY/gwWbJDF1+f/mQAY4bMzUMiNvE2ForjXzgB5fkhRWmG0R3bFlfJBkHg+Dk58omXXITZzEiSIcPVg/4EYDDx0OeDWCLisu2MfyFDES5LS0Ms7ghf2lWXw+xgv3gr2f3zX7y0lRi3hadu/8YOxI02kIhaJ0IFmSlr0DsHbeiI00f8+L2GUOlO4mbq628GZ4wXJ0iRoYLbMrFFuIJQeHhJFXzMinf7/3NkOmINbBcuptRY5T+hLtejJsdJh52zFNhG4h0OxsiL3K9ciUThg/rURAv8mVYL4NRuSAzRMdDWx6rSbTDeCyoKCIvE6Fq3lKmrd8ReTyOHlF j6mo+iro t7TRvdv9Yz5jMP29H47MydYfXdEh5UL03HRmVJRshqMdXvj97fsyVKQ+Ywcq+9699n9cZqAqiomTBeIF3ucLq4ZGFsekCykNMkaV3hPEh9tkoQLJ+H2JCWEusRt7rVjdp26ygVDtaYJdygOHGt04Hemp8Iw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Nicholas Piggin" writes: > On Thu Jun 1, 2023 at 8:46 PM AEST, Sachin Sant wrote: >> While compiling a kernel on a IBM Power system booted with >> 6.4.0-rc4-next-20230601 following warning is observed >> >> [ 276.351697] ------------[ cut here ]------------ >> [ 276.351709] WARNING: CPU: 27 PID: 9237 at kernel/sched/core.c:5358 kthread_end_lazy_tlb_mm+0x90/0xa0 >> [ 276.351719] Modules linked in: dm_mod nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 bonding tls rfkill ip_set nf_tables nfnetlink sunrpc pseries_rng aes_gcm_p10_crypto xfs libcrc32c sd_mod sr_mod t10_pi crc64_rocksoft_generic cdrom crc64_rocksoft crc64 sg ibmvscsi scsi_transport_srp ibmveth vmx_crypto fuse >> [ 276.351752] CPU: 27 PID: 9237 Comm: cc1 Kdump: loaded Not tainted 6.4.0-rc4-next-20230601 #1 >> [ 276.351756] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200 0xf000006 of:IBM,FW1030.20 (NH1030_058) hv:phyp pSeries >> [ 276.351759] NIP: c0000000001b8c10 LR: c0000000000a8d54 CTR: c00000000046ec00 >> [ 276.351763] REGS: c0000000dce337d0 TRAP: 0700 Not tainted (6.4.0-rc4-next-20230601) >> [ 276.351766] MSR: 8000000000029033 CR: 24002228 XER: 00000000 >> [ 276.351774] CFAR: c0000000001b8ba0 IRQMASK: 0 [ 276.351774] GPR00: c0000000000a8d54 c0000000dce33a70 c0000000014a1800 c000000007852a00 [ 276.351774] GPR04: 0000000000000001 ffffffffffffffff 0000000000000000 c000000007852f78 [ 276.351774] GPR08: 0000000000000000 0000000000000000 0000000000000000 0000000024002428 [ 276.351774] GPR12: c0000000a032b608 c00000135faa5b00 0000000000000000 0000000000000000 [ 276.351774] GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 [ 276.351774] GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 [ 276.351774] GPR24: 0000000000000000 0000000000000000 0000000000000000 c000000007852a70 [ 276.351774] GPR28: 0000000000000000 0000000000000000 000000000000001b c000000007852a00 [ 276.351810] NIP [c0000000001b8c10] kthread_end_lazy_tlb_mm+0x90/0xa0 >> [ 276.351814] LR [c0000000000a8d54] exit_lazy_flush_tlb+0xf4/0x110 >> [ 276.351818] Call Trace: >> [ 276.351820] [c0000000dce33a70] [0000000000000001] 0x1 (unreliable) >> [ 276.351825] [c0000000dce33ab0] [c0000000000a8fbc] flush_type_needed+0x24c/0x260 >> [ 276.351829] [c0000000dce33af0] [c0000000000a91a8] __flush_all_mm+0x48/0x2c0 >> [ 276.351833] [c0000000dce33b40] [c0000000004d6dcc] tlb_finish_mmu+0x16c/0x230 >> [ 276.351839] [c0000000dce33b70] [c0000000004d2a2c] exit_mmap+0x17c/0x4c0 > > Thanks for the report. IRQs aren't diabled where I'd they would be. Fix > should be just add a local_irq_disable somewhere, but this looks like it > is exposing an upstream bug of mine so I'll work out a fix for that > first. No big deal for this series, it can stay in -next for now, it > might just require a rebase. Can we drop the newly added WARN_ON_ONCE() in the interim? It blows up a bunch of my tests, because they fail on seeing any WARN. cheers