From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D0AC001DF for ; Thu, 3 Aug 2023 08:06:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB6DB280214; Thu, 3 Aug 2023 04:06:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A662C2801EB; Thu, 3 Aug 2023 04:06:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92E1E280214; Thu, 3 Aug 2023 04:06:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 839D52801EB for ; Thu, 3 Aug 2023 04:06:08 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 420E5161041 for ; Thu, 3 Aug 2023 08:06:08 +0000 (UTC) X-FDA: 81082060416.15.5422188 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf28.hostedemail.com (Postfix) with ESMTP id 688CCC0008 for ; Thu, 3 Aug 2023 08:06:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of lienze@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=lienze@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691049966; a=rsa-sha256; cv=none; b=3SI9GxUkqRPY7hNvXzW5C2K7Wu7Lz0mQhjRaqoa+5+8RlSbchMJVyr5S0qFCvzvJjMzz8i BKRr4+mwmKbg9kCHJNKszoHgGF+Q76ypghsJgwYC/aMbND0WHoZfDxkExGvdugWL3AmfhH Zb70sVkGmdvq9M5juaxFlX6zRbnjxkE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of lienze@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=lienze@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691049966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MK5LYRbFtsUe3oM/I42XrNz9zfKU6z9T17StV29UIes=; b=Li66Y04RuOoV9DdTCN5oO6vimk3CgQsfRPZWnen2BqUV6HIR6NoKq/YznLVByNaMvBW0c9 NhlORLP6qdlK3Evy73yk0xXCCCKXPz2pGL4lW8j0z+XhK08C29UbhMk0ZacovH6ZPbHZn4 vJPqDNENaCJTVf35XcW2tF4clkau+TY= X-UUID: 31d6717c58ef4209b175782d51f77270-20230803 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.28,REQID:6068e0c5-4592-4c2a-864d-cdc44bfed288,IP:25, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:10 X-CID-INFO: VERSION:1.1.28,REQID:6068e0c5-4592-4c2a-864d-cdc44bfed288,IP:25,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:10 X-CID-META: VersionHash:176cd25,CLOUDID:2f581ab4-a467-4aa9-9e04-f584452e3794,B ulkID:230802231252IHNI1SQW,BulkQuantity:1,Recheck:0,SF:19|44|24|17|102,TC: nil,Content:0,EDM:-3,IP:-2,URL:1,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0,OSI :0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI, TF_CID_SPAM_ULS X-UUID: 31d6717c58ef4209b175782d51f77270-20230803 Received: from ubuntu [(39.156.73.12)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 166434915; Thu, 03 Aug 2023 16:05:58 +0800 From: Enze Li To: Huacai Chen Cc: kernel@xen0n.name, loongarch@lists.linux.dev, glider@google.com, elver@google.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, zhangqing@loongson.cn, yangtiezhu@loongson.cn, dvyukov@google.com Subject: Re: [PATCH 0/4 v3] Add KFENCE support for LoongArch In-Reply-To: (Huacai Chen's message of "Wed, 2 Aug 2023 23:12:23 +0800") References: <20230801025815.2436293-1-lienze@kylinos.cn> Date: Thu, 03 Aug 2023 16:05:45 +0800 Message-ID: <87a5v83606.fsf@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 688CCC0008 X-Stat-Signature: i9jpwugwkfktfohs91goibfjd8hz9ece X-HE-Tag: 1691049965-346852 X-HE-Meta: U2FsdGVkX1/vUbhV45hMr9w5jHut07yjNKxJpBCJQUtDMblI4Mjf5Hqm68GzLPDmUJwUSxOdgFosb9C3J9rvw0warxfKxzIau5cgPO9LwQwV3YQbdrhzfmCL1jF4hGKGAI2ZvQVEUWypkG/GM3OwIS82aC1tPQf4DomCuRT/bGH8K8OxefwKXjDiZzcPkI2SWudQyfI8YGpCueGBxoWBGfsXBknvG2602Hh44IDfUmAJ4SvrqWpQosYOamSKjKd28AbpRHnD7/bLyCcOPWTV4qfO6xtIdXURiDk66dw3zAtC0TR5GHT3yFGUf2ywUaSaM1N/UeJNXoR3KV7HMxSnr31LHtYLvmgcVXql3qhnI9V9bvf8YQMB50hbN/mEExAhJHweFfKqH+UA+Fz9mnPwzxgL1XikP0p+Kya+j9KCRLO1WPXq5YsmfttR4MBorHASeaB6FUYiatF8FtqPOGORyOoX+6HLLCPmjQncBsr9MuwGEHoaGnuQoQjE9dzHirAJJUuatitozlY8i39GIw8mzjliCT788vnRez1Qhr43oBYWoab5spkJbZDT1ACzXK8e0HFjdvNzbNvyqD89iRGzYTnMWqyhFHeUSKD6nEu+Dbwbk+/2pW62yufHjTsAiya4sBSa8VuOaqjqDIJfD6/sOm8eS0AnOFa3JO3iua3GeQubuveAYidJpAlq0+pukQEd1/lbwXcnj7hIJjhkde7U1zuouPqHHMdibsls5qD39/Ek7w4Ela3DXB3XbsmTz0m/Jz+0TJ14wIhwurY6N8RDVguk6hcBO+MrDqx1WtlJiMF3L2H8o1a2JeWzDkyMCSFsYOmjD2HLYViB5TqBLku89Qmt6mpmi6HILdpFPtl3wVTerLC46FZmZkEY2Am0GM3EH9fMP0iKdWugC1eyEh8TXSwshUGlr6Ijybcu+b7iEImJOA9zgtddmBZMCWXt+4gEDcr0tfJJ0BHSPpwKAD9 wgtU16eN /syBRLOyjNrxof0E2DdeTo2X2KH899wLzjPv8KfZ5oj+mncDBI7y9BnpKPrctoYELQF13QTMfTwOA3fI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 02 2023 at 11:12:23 PM +0800, Huacai Chen wrote: > Hi, Enze, > > I applied this series (with some small modifications) together with KASAN= at: > https://github.com/chenhuacai/linux/commits/loongarch-next > > Please confirm everything works well for you. Hi Huacai, Thanks for your patience these days. I've tested this on both a physical machine and a qemu VM. It works well. BTW, if there're any modifications, bugs or improvments to KFENCE on LoongArch in the future, feel free to Cc me. I'll appreciate it. :) Best Regards, Enze > > Huacai > > On Tue, Aug 1, 2023 at 10:59=E2=80=AFAM Enze Li wrote: >> >> Hi all, >> >> This patchset adds KFENCE support on LoongArch. >> >> To run the testcases, you will need to enable the following options, >> >> -> Kernel hacking >> [*] Tracers >> [*] Support for tracing block IO actions (NEW) >> -> Kernel Testing and Coverage >> <*> KUnit - Enable support for unit tests >> >> and then, >> >> -> Kernel hacking >> -> Memory Debugging >> [*] KFENCE: low-overhead sampling-based memory safety error detect= or (NEW) >> <*> KFENCE integration test suite (NEW) >> >> With these options enabled, KFENCE will be tested during kernel startup. >> And normally, you might get the following feedback, >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >> [ 35.326363 ] # kfence: pass:23 fail:0 skip:2 total:25 >> [ 35.326486 ] # Totals: pass:23 fail:0 skip:2 total:25 >> [ 35.326621 ] ok 1 kfence >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >> >> you might notice that 2 testcases have been skipped. If you tend to run >> all testcases, please enable CONFIG_INIT_ON_FREE_DEFAULT_ON, you can >> find it here, >> >> -> Security options >> -> Kernel hardening options >> -> Memory initialization >> [*] Enable heap memory zeroing on free by default >> >> and you might get all testcases passed. >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >> [ 35.531860 ] # kfence: pass:25 fail:0 skip:0 total:25 >> [ 35.531999 ] # Totals: pass:25 fail:0 skip:0 total:25 >> [ 35.532135 ] ok 1 kfence >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >> >> v3: >> * Address Huacai's comments. >> * Fix a bug that Jackie Liu pointed out. >> * Rewrite arch_stack_walk() with the suggestion of Jinyang He. >> >> v2: >> * Address Huacai's comments. >> * Fix typos in commit message. >> >> Thanks, >> Enze >> >> Enze Li (4): >> KFENCE: Defer the assignment of the local variable addr >> LoongArch: mm: Add page table mapped mode support >> LoongArch: Get stack without NMI when providing regs parameter >> LoongArch: Add KFENCE support >> >> arch/loongarch/Kconfig | 1 + >> arch/loongarch/include/asm/kfence.h | 66 ++++++++++++++++++++++++++++ >> arch/loongarch/include/asm/page.h | 8 +++- >> arch/loongarch/include/asm/pgtable.h | 16 ++++++- >> arch/loongarch/kernel/stacktrace.c | 18 ++++---- >> arch/loongarch/mm/fault.c | 22 ++++++---- >> arch/loongarch/mm/pgtable.c | 7 +++ >> mm/kfence/core.c | 5 ++- >> 8 files changed, 123 insertions(+), 20 deletions(-) >> create mode 100644 arch/loongarch/include/asm/kfence.h >> >> -- >> 2.34.1 >>