From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F8DC05051 for ; Wed, 9 Aug 2023 20:14:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A06C6B0071; Wed, 9 Aug 2023 16:14:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 929E56B0074; Wed, 9 Aug 2023 16:14:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77BD48E0001; Wed, 9 Aug 2023 16:14:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 652496B0071 for ; Wed, 9 Aug 2023 16:14:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 39B8FB28B8 for ; Wed, 9 Aug 2023 20:14:41 +0000 (UTC) X-FDA: 81105669162.29.A9F949E Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by imf24.hostedemail.com (Postfix) with ESMTP id B5C19180011 for ; Wed, 9 Aug 2023 20:14:38 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691612079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=coZ6ulv7PeTT3ENpAYsqPZL/64NrN1NUvf045vqCEaE=; b=idEvMEigY63KI6Cn0ECxCc7+49ENiyDCuFC30UEK2WjDaldgBM/dCRE1kuNcGaHUNP7sP0 fDX3XiZgXM7GPB4Lo1q+5YaVn7LkFb5Z471qldXNkkwpgywHxYLJn6GfXYmw54YhpfV6Rz EGpel7TLIjPLAmJ12NocvxCOmUuKNIs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691612079; a=rsa-sha256; cv=none; b=YS4ZPKYQoEbIMXpd9Dp+FJEqzg6FNUdj9jjOiGU772FSRO0Wq0P6JUTYEOSZudgwlgiAmH i6PXQEIVuYhF5UedNFyXyqqFyJK4fBWZn9xvoT3eRRgTIPZvb4IfNP0la+kc1qrRVuuRTQ e1BXXYKljdwt80v/pcfEefCHaLe3TCU= Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 0B7972055FA7; Thu, 10 Aug 2023 05:14:36 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 379KEYfO226784 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 05:14:35 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 379KEYHK237230 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 05:14:34 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.17.2/8.17.2/Submit) id 379KESDU237221; Thu, 10 Aug 2023 05:14:28 +0900 From: OGAWA Hirofumi To: Jeff Layton Cc: Jan Kara , Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp In-Reply-To: (Jeff Layton's message of "Wed, 09 Aug 2023 15:04:42 -0400") References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-5-d1dec143a704@kernel.org> <87msz08vc7.fsf@mail.parknet.co.jp> <52bead1d6a33fec89944b96e2ec20d1ea8747a9a.camel@kernel.org> <878rak8hia.fsf@mail.parknet.co.jp> <20230809150041.452w7gucjmvjnvbg@quack3> <87v8do6y8q.fsf@mail.parknet.co.jp> <2cb998ff14ace352a9dd553e82cfa0aa92ec09ce.camel@kernel.org> <87leek6rh1.fsf@mail.parknet.co.jp> <87h6p86p9z.fsf@mail.parknet.co.jp> Date: Thu, 10 Aug 2023 05:14:28 +0900 Message-ID: <87a5v06kij.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B5C19180011 X-Stat-Signature: gnp7rs37cn3jq6sijx5zuh5n5usfhqrb X-Rspam-User: X-HE-Tag: 1691612078-299891 X-HE-Meta: U2FsdGVkX1+i1gOmO6XuawfhQNUhVq4p7P0ysQSXJV0y4bnuj9BJdh9u4r5f8C7NtlPy4mmKE9czK0wOvwGPqoOztCD2D1BEPqHMDxXD5KYz98SYgQw0jzyGWIhsUv+/xEpqbXG2C20T21cDzy5X+5QPzTbBEwQR1hsxoZFomkWmVvSuOA8MZm9QjG0VT2ELOdHSMpUFSDtqM9SyCmdbmqlQs8R8TYbIZoDVnZLsGakkuoeRNBi/WxDHLC8wRNNHfUP+bJoziJWnyrLAmrPcSClEpXm/p/6iqiIgckcjoU3VoSBKNPxpIpG1RXf6OydpXRV2llE6GGP0HAwZaq9RThWJ2FpRxu8vUg9ggv0qPs0ZXBfAxOjig1DhhUT3TkrSsg5Pr0nj30V7v6j7uYaRpfnYjDn/JKQENrO/L4jj5WK3HGpH4+2cCCf7lJqsgu/TpHfC84qgQAB+MI+PJYTPd3BBufuN0t7SBypHr7YEx0RtuzbJskafPWuzgi+2zDTMfk3ge+XIYeZUGTjAujLfBr7r9VbVQPpr9jApBvr4BFFLOSzdj/WAvQFbXP17YqKZpRAAR4wH+flcymvRSH1weApfGhMLFabCdqs9z/Lpni1+rKJu7NljmNKmwEH/k+dWB5J1NsUhnP+GcgZegDo4Akdu5XDTMMg7J1jYKTO/8+eRfuUb1LUSXCJdmzQPO1dCYyDEXC5ytMYATo6oC7kmkqRa22wlj5tBpcEGNc7DE8FJ+rYgAaOHJyJTKGW4U5WOwwpmLMtnsbQe34XuEuIlVJH4Ouo1UuSO0958JOfmVjvbJowkggbovrcpCxRfql6IYdZP6uj54WDYnez59UY3sQcfbKN7gPFO5vWj9xx1dhNEg3oYR1Xpq+UYy8wl5rCMquip+OJsu2zhxKKolEHfIIqmFT9TpemVWAEuONGvkr6pYPzJFR/c7CQDvhfG8pKkg7s7icBAYhMMKn8EQaP 4fujjliq 5RcTKXIjRwcay4YgAM6KBX40kajCMtj5F+h2W+Qv47qIJEbHTgcdF2U3SnkF4uJi1RhByna0YGlxEgYVRe8QnErdnmfInnMunzfZNXJO5DXEKJiWkZmOrI3HQnuD5omRFuM4UCWvGHQEdkbdkUY6AKbahbSHoGCkCjK66qULW6oLkPovlVRy6FFrtYDy4l4nDQ9vAhNtERiqyVn+YVlZNkoOTnDMr4Vj8crzBS9mjxGwEvXbXW6MKvw1GsPjH7PHwkXMIOg54Z/yVwfcyxiECM3L/8h/O20PhotXgu+vc+VHYwtE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jeff Layton writes: > When you say it "doesn't work the same", what do you mean, specifically? > I had to make some allowances for the fact that FAT is substantially > different in its timestamp handling, and I tried to preserve existing > behavior as best I could. Ah, ok. I was misreading some. inode_update_timestamps() checks IS_I_VERSION() now, not S_VERSION. So, if adding the check of IS_I_VERSION() and (S_MTIME|S_CTIME|S_VERSION) to FAT? With it, IS_I_VERSION() would be false on FAT, and I'm fine. I.e. something like if ((flags & (S_VERSION|S_CTIME|S_MTIME)) && IS_I_VERSION(inode) && inode_maybe_inc_iversion(inode, false)) dirty_flags |= I_DIRTY_SYNC; Thanks. -- OGAWA Hirofumi