From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA81EE4997 for ; Fri, 18 Aug 2023 21:00:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3A84940065; Fri, 18 Aug 2023 17:00:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEB64940012; Fri, 18 Aug 2023 17:00:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8A70940065; Fri, 18 Aug 2023 17:00:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A682C940012 for ; Fri, 18 Aug 2023 17:00:25 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 77C0DA120F for ; Fri, 18 Aug 2023 21:00:25 +0000 (UTC) X-FDA: 81138443610.13.6FB28D8 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by imf24.hostedemail.com (Postfix) with ESMTP id 00A8418003A for ; Fri, 18 Aug 2023 21:00:22 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.232 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692392423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c2HNIZlJkw+5fhfv+glzCmzVWYPxCsHKEZHFrWUnQpg=; b=CNIIGoy0MvoymrSdUXvlt+oFpQE/JjjnekWgR/bnfsYdD5FlM1AXQPTzGv6LnVlVi+8Rut Qo5tJFGvKAA5pp+bggN/Cb5rzySEa8dtWLB+Y13eeDHwhVfacVw4/y1RKMGo0J1OO3LWRi jdczmgEEjdWkIJgs4bEq0J/caUEdkrY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692392423; a=rsa-sha256; cv=none; b=hBo4QRcSFEOltH1XOy6N6nJoLuNr09TWZg+WyZaVc9r4eNCQrfKtbaAk3T1dDVr6M3fQhS I8cPMXICAqSnSsavKia6oABUDePm5fSJY/vnI9cEGvJuP0vChzdi9S8nTQMYMKZ0ddbkS0 XVbGlKkzE/UnpADNakCvbecnkWkjOME= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.232 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com Received: from in01.mta.xmission.com ([166.70.13.51]:45472) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1qX6Zw-005O8N-KN; Fri, 18 Aug 2023 15:00:20 -0600 Received: from ip68-227-168-167.om.om.cox.net ([68.227.168.167]:50332 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1qX6Zt-00540T-Ve; Fri, 18 Aug 2023 15:00:20 -0600 From: "Eric W. Biederman" To: Mateusz Guzik Cc: syzbot , anton@tuxera.com, brauner@kernel.org, keescook@chromium.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ntfs-dev@lists.sourceforge.net, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk References: <000000000000c74d44060334d476@google.com> <87o7j471v8.fsf@email.froward.int.ebiederm.org> <20230818173625.by6bud4u7uz2k4be@f> Date: Fri, 18 Aug 2023 15:59:39 -0500 In-Reply-To: <20230818173625.by6bud4u7uz2k4be@f> (Mateusz Guzik's message of "Fri, 18 Aug 2023 19:36:25 +0200") Message-ID: <87a5uo6p8k.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1qX6Zt-00540T-Ve;;;mid=<87a5uo6p8k.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.168.167;;;frm=ebiederm@xmission.com;;;spf=pass X-XM-AID: U2FsdGVkX1/ofGYnSpXkgEFr1C7tIJqjxck0R7gNKbE= X-SA-Exim-Connect-IP: 68.227.168.167 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [syzbot] [ntfs?] WARNING in do_open_execat X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) X-Stat-Signature: qz7ruhkaqmwnb4k783f6dwghcmq64it9 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 00A8418003A X-Rspam-User: X-HE-Tag: 1692392422-642313 X-HE-Meta: U2FsdGVkX1+FMhNtoafeXTbuRMc980UlEGqxwFkRvA2UQ2Mp0ktUKre5hxAJbVJBivZGHLXjeJZ7zHN/1WWcejwl2rQfME9QRmd/qi0/7WMFT4INXiJLip8InGUrUS9u5/r+y8uEWh4Yb20blqpwItResFFG2nNPOnmcREPvMR/b7DDTNTPmzCsxFkdpROfh6NLt0JIYwqv4SK5gQcwvw09fcRcqpz+8EA/LZCkOCzYxbMxQ/CLThHCU/mX7obbCsVIXeVt8S5ZLNREg7w6SySMdskek05HClSo6AHc1Y/62AdVDbB1FgIDORNvvbaKPb3AtMFaHJpX8F7yfI5fmh6fL6rPWUvNVkXaiDs8ETvj26oeqtv0dDl9s1R4o57M8lIsMANqHlw9UrQpsLMrEB0zw9G0CTKdjxSSbA2zjvbw2CIFkK3dlM04BX7shD2Nhd42iOuCUX7hlrYfQtMbzOcE/Z+cxz6omDWe6hHhOe4hj4XznJ6GYaCHeJTLbBbBFSoeeqH5pVkWsp8f2nYwMXXgnhU5HORkjjFs9ppUaJvx5wM5hLoMDV3UccfzQx2sEEg+//ViyGj//Z7e7Wb/kYDzxkbWoxXhTRanhuzdwieTnBj6fzdUR4JPW4O5xnzomtkQCjkaH+kuxrlmp7yYQFyJf4rsqYjLPeaBpU9KKRZDzc5p6TcTLqzAMQICNCHF+f1GGMA5Gsekz+bjOWJLsgKoRWcqMyg7kJwPOXZV/bASB6/MzYu/Wl7LPIYKFD7HZNqgztrLdOHlLH/A/hDfuJbBsT7Mh9MoqB1A8v/NxrqmeMnNIIvGaM5PbwLiKge+M7AwDljIXVCLCwGqEZMtHAxud7dZ7WfkIJq3dR7dpg/DM61evLsfGM525PmkRuKi9gfImAsefpPiAJwha92b8VkMcz8F7O5SayW66Xn+K/NOcRCSXzPFNM1csUyvjYG1PNUbi1DEYif+mJ2KGcaB ZpavoT3Z pm10LnQ2klS1sb8/obswkZfsahutIQ7xYvUCvhRizZOLuoN1ESHwptcUesLK6i3XFxitQhLtaVVjNKgUMIVi0ShAH0aU5tsYfF5mZbNoJlemVzz30rwIeAKtaiQpDAY/K8+whHcZ05CLP6l4RW8plxCws7sgt+nMT/JcnS4W+M/J/e8cXoqDnBiaxzAcaK5rhuMlgRxkCn+TcBeJ0RjTyB+omjWpCnkqFItT4NHFjPcSPUu4MyF5squUWpkM/87VGyt9DeXTEJA2Tw3mzW/5xUnhh6yihuPwvk7JUUAktxaI9bL4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Mateusz Guzik writes: > On Fri, Aug 18, 2023 at 11:26:51AM -0500, Eric W. Biederman wrote: >> syzbot writes: >> >> > Hello, >> > >> > syzbot found the following issue on: >> >> Not an issue. >> Nothing to do with ntfs. >> >> The code is working as designed and intended. >> >> syzbot generated a malformed exec and the kernel made it >> well formed and warned about it. >> > > There is definitely an issue here. > > The warn on comes from: > /* > * may_open() has already checked for this, so it should be > * impossible to trip now. But we need to be extra cautious > * and check again at the very end too. > */ > err = -EACCES; > if (WARN_ON_ONCE(!S_ISREG(file_inode(file)->i_mode) || > path_noexec(&file->f_path))) > goto exit; > > Where path_noexec is: > return (path->mnt->mnt_flags & MNT_NOEXEC) || > (path->mnt->mnt_sb->s_iflags & SB_I_NOEXEC); My confusion. I was seeing the message from if (retval == 0) pr_warn_once("process '%s' launched '%s' with NULL argv: empty string added\n", current->comm, bprm->filename); I made the mistake of assuming that that was generating the backtrace. The lack of args to execveat appears to be working fine. I see you tracked this down to a non-exhaustive check in may_open. Apologies for the noise. Eric