linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Huang, Ying" <ying.huang@intel.com>
To: Gregory Price <gregory.price@memverge.com>
Cc: Gregory Price <gourry.memverge@gmail.com>,  <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>,  <linux-cxl@vger.kernel.org>,
	<akpm@linux-foundation.org>,  <sthanneeru@micron.com>,
	 Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>,
	 Wei Xu <weixugc@google.com>,
	 Alistair Popple <apopple@nvidia.com>,
	 Dan Williams <dan.j.williams@intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	 Johannes Weiner <hannes@cmpxchg.org>,
	 "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	Michal Hocko <mhocko@kernel.org>,
	 "Tim Chen" <tim.c.chen@intel.com>,
	Yang Shi <shy828301@gmail.com>
Subject: Re: [RFC PATCH v2 0/3] mm: mempolicy: Multi-tier weighted interleaving
Date: Mon, 30 Oct 2023 10:20:14 +0800	[thread overview]
Message-ID: <87a5s0df6p.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <ZTlxxR0ntEzBPwre@memverge.com> (Gregory Price's message of "Wed, 25 Oct 2023 15:51:33 -0400")

Gregory Price <gregory.price@memverge.com> writes:

> On Wed, Oct 25, 2023 at 09:13:01AM +0800, Huang, Ying wrote:
>> Gregory Price <gregory.price@memverge.com> writes:
>> 
>> > On Mon, Oct 23, 2023 at 10:09:56AM +0800, Huang, Ying wrote:
>> >> Gregory Price <gregory.price@memverge.com> writes:
>> >> 
>> >> > Depends.  if a user explicitly launches with `numactl --cpunodebind=0`
>> >> > then yes, you can force a task (and all its children) to run on node0.
>> >> 
>> >> IIUC, in your example, the `numactl` command line will be
>> >> 
>> >>   numactl --cpunodebind=0 --weighted-interleave=0,1,2,3
>> >> 
>> >> That is, the CPU is restricted to node 0, while memory is distributed to
>> >> all nodes.  This doesn't sound like reasonable for me.
>> >> 
>> >
>> > It being reasonable isn't really relevant. You can do this today with
>> > normal interleave:
>> >
>> > numactl --cpunodebind=0 --interleave=0,1,2,3
>> >
>> > The only difference between this method and that is the application of
>> > weights.  Doesn't seem reasonable to lock users out of doing it.
>> 
>> Do you have some real use case?
>> 
>
> I don't, but this is how mempolicy and numactl presently work.  You can
> do this today with the current kernel.  I'm simply extending it to
> include weights.

The extending adds complexity to the kernel code and changes the kernel
ABI.  So, IMHO, we need some real life use case to prove the added
complexity is necessary.

For example, in [1], Johannes showed the use case to support to add
per-memory-tier interleave weight.

[1] https://lore.kernel.org/all/20220607171949.85796-1-hannes@cmpxchg.org/

--
Best Regards,
Huang, Ying


  reply	other threads:[~2023-10-30  2:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 20:42 Gregory Price
2023-10-09 20:42 ` [RFC PATCH v2 1/3] mm/memory-tiers: change mutex to rw semaphore Gregory Price
2023-10-09 20:42 ` [RFC PATCH v2 2/3] mm/memory-tiers: Introduce sysfs for tier interleave weights Gregory Price
2023-10-09 20:42 ` [RFC PATCH v2 3/3] mm/mempolicy: modify interleave mempolicy to use memtier weights Gregory Price
2023-10-11 21:15 ` [RFC PATCH v2 0/3] mm: mempolicy: Multi-tier weighted interleaving Matthew Wilcox
2023-10-10  1:07   ` Gregory Price
2023-10-16  7:57 ` Huang, Ying
2023-10-17  1:28   ` Gregory Price
2023-10-18  8:29     ` Huang, Ying
2023-10-17  2:52       ` Gregory Price
2023-10-19  6:28         ` Huang, Ying
2023-10-18  2:47           ` Gregory Price
2023-10-20  6:11             ` Huang, Ying
2023-10-19 13:26               ` Gregory Price
2023-10-23  2:09                 ` Huang, Ying
2023-10-24 15:32                   ` Gregory Price
2023-10-25  1:13                     ` Huang, Ying
2023-10-25 19:51                       ` Gregory Price
2023-10-30  2:20                         ` Huang, Ying [this message]
2023-10-30  4:19                           ` Gregory Price
2023-10-30  5:23                             ` Huang, Ying
2023-10-18  8:31       ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5s0df6p.fsf@yhuang6-desk2.ccr.corp.intel.com \
    --to=ying.huang@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=apopple@nvidia.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=gourry.memverge@gmail.com \
    --cc=gregory.price@memverge.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shy828301@gmail.com \
    --cc=sthanneeru@micron.com \
    --cc=tim.c.chen@intel.com \
    --cc=weixugc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox