From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7346FC3271E for ; Thu, 4 Jul 2024 16:27:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAC4D6B0082; Thu, 4 Jul 2024 12:27:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5D1E6B0083; Thu, 4 Jul 2024 12:27:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFCD36B0085; Thu, 4 Jul 2024 12:27:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A1E3A6B0082 for ; Thu, 4 Jul 2024 12:27:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2378E14130A for ; Thu, 4 Jul 2024 16:27:44 +0000 (UTC) X-FDA: 82302601248.19.78AF54D Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf04.hostedemail.com (Postfix) with ESMTP id 9F1E240002 for ; Thu, 4 Jul 2024 16:27:41 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FtAmTwv0; spf=pass (imf04.hostedemail.com: domain of maz@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720110449; a=rsa-sha256; cv=none; b=XaKYo0+n42Ub0nlXoYXncLf5bvq1rQfz2BJpkjIZsq8ItcMEFyNx+mc/wTd7OgxqKmTtSX cQj6wl+NUCdV/ApdqxIJt+JQzBfcd5z5wDJ8wHgmroBoRfl2RDO0oLMOxfnHJ3fZlSLZOY f136FgeRf98Yp31CNKCTbUAm62uqOMM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FtAmTwv0; spf=pass (imf04.hostedemail.com: domain of maz@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720110449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Ap6I9CKUroZ46J0q60AIZr/OYJ+d+4W+n/cxCv2x54=; b=fpT2NVV4HeHm1zRdT4/vYAMmpVWy9eSEWYyihU0zHm3M+CeXyTlJTQlBobGwbFO+EbV10j AMU0ijSaZf+Qz1lzK9d6tfnhU9gST87gNNNgyzSPUGgheDtIL5IAc6Xn4QewgOW9qOyIeJ l8JrXXxWc05QffN1CqeldzXZnTBXZzY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 18133CE384F; Thu, 4 Jul 2024 16:27:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D008C3277B; Thu, 4 Jul 2024 16:27:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720110456; bh=cLbax7w8hCqvVgykek/avE2LE7rUynfVykQnAlriJRw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FtAmTwv0BhpOAgNuf2xM0PMOCI5jJVC3qbUtNtcqZgw0ZATa2ue7zH01yxHMpO3qs Z4ddXbwPNDuM/69bt2vAlgBCx6I/QzkOrLQuHvHtz0is7lEV6efBphdtYfl7gb9xxK aDCTY7Dpo7bYvYOP6ZZAi8KJoGudUd4VF+rCB7Vho0ekYNUntsn1lol7BuIJSS4Hc6 lN183LNldf9WlPrnr2pOM7riQnzulQGIIAWNl36GMkpIuZGi2reHRzTcZIRJE19QzN /USbN67o5BEcTVRRJAENlfMG55SWnsgL4Mhz6JYrmky7SNvR03b10TH6RlEDJfNpO/ oVgQwAWLNgwOw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sPPIz-009okh-Jl; Thu, 04 Jul 2024 17:27:33 +0100 Date: Thu, 04 Jul 2024 17:27:33 +0100 Message-ID: <87a5ixp1fu.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: kernel test robot , James Morse , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Russell King (Oracle)" , Jonathan Cameron Subject: Re: [linux-next:master 9019/10049] drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used In-Reply-To: References: <202407021807.cBuWVBVa-lkp@intel.com> <86cynt4jem.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, lkp@intel.com, james.morse@arm.com, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, rmk+kernel@armlinux.org.uk, Jonathan.Cameron@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Stat-Signature: d13a3fufaz887zrrqpwo5sgiq6kyh6zz X-Rspamd-Queue-Id: 9F1E240002 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720110461-406405 X-HE-Meta: U2FsdGVkX1/MxWr2sRyJXRoIaF531nQUf8hCpMkAkdp24+1pPwRx7Yw3AuBSO+F97BQxEwjM3tLKuvkvm4ujjVbSABxt8pwW5XD0nk4nFqO9Eep7WLGRtKj2jCcA6HtnfyHpTY/zPwX3cVvMTxYf7hvJW7X8PAznKdWh3aXhK3txANTL4pPfaFN/e/ggW96OXCP+vmXNlievTvx+hTyHk7HYIwTpaNoZCsiKv/iiP8E38Tg6YUOvUQZqnXrG52Rfs91q5AATfffCs+AErzB+mq/Yusd9FB2vXPa6KRGcIvaL32HvciZZI1PCBEfXsL9qA2nEc21z3OYT86x5TuRJf3ET8lmCsnt5VWUEUKxTTbZPe5xnAkpel29JdIbWzzY2+rarTdhdZP8zVVros6NzC6IsMWYCbFaUA24+p/vD2Kf/c7TAdMQcQzMDkdDqKzNDmsZnm+koC9TI4FQit81HJTXt7LF7Q9o33LqLWLLS8ZA6ZIy6QK3RCHw1nrqAcKKZdX1Lf8Mz4gEqE4I3nneuAmbaYOKUBy59wTqWzpppY9idI6Yuh9FbF746tpdq0DuPCKoRAOHLUTfEsQNBKWQZjwDa/YdY2/Op8EQKkX6WcE8TMydBZOxEeNZSZaT66UDP1nMn7Y1nQonpwvkqd+hHf2DZGKNu0l46mJmVWa3SKffqRq0jnS4iQs7mVE1JPBm0s+lDZWesJedVa9krSUL0kg5nrtTyzr6iHBj/NkA7iTr1u511rfiZe+j3rqXemU7owMWOh1sV5GpJf6IIR33YG4EVNPi/VL6AJKOAAFGPFPC+7zmGIohUJgGSyffjJIdBvhY0oHLFT5Knc/ipuZp+IzDjsekgO+q8V7PdSH5iRlfs0sAUGWXN8VDYNcFl1tqx9PYw/TdnsZRHB6zcdHtHY8y5KXwYR2I9S5DeJ8S/upgdU54tUjdzRyA7/UcFZJbQnhMt3C4kWkasW4Iyaz4 lrSXa4K2 i99GiMKSLVqY1YrL+GT/jGnPIAg0L4PcT9ZBdvu9E14xWDnU+s5y4GMFKrfY2p68wSFYoWdwCN644J1ackjDIb5roQeWFo9Xv6roYj6ry2TEOafg1tMbfNSLcGEm/NzwD6jQLcaeqo+ubnEAvflrhp04IdLObhGF3V0H7OIQqLwJ3T+qoE+zSBCOGqoYmPckcTWWsSSRMAHv5qRt3EMIaeWSq6Wxhw07aiKWUxppTxaJrq61XEswBePAZSh5OU//r+o6/ztcsMV14Yaq3b7AdiPpFDE3QWhgSdem0/sZ/hocKlE/2P2AAEMPd54Gbz6c1YjsSxjC5OwoCRiYAEPcrtz0Nh/Agi1fdPlLNnUZpWSxfmVoK572QfG48IUK4LJxNE5dm8++Zf9gB9UwDgW9Ky2KEHzyBu4pkK7wPDyG71CaSjuSD8XaAXQv/7N/azvqJeyiV8LduBpAehruZznbM26HmJv4hydDsiTwxQ4JP7eYNvFleQuBfOVAIY/BjwCHM1ZgRisUzY8MjYtk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 04 Jul 2024 11:27:28 +0100, Catalin Marinas wrote: > > On Thu, Jul 04, 2024 at 10:05:05AM +0100, Marc Zyngier wrote: > > On Thu, 04 Jul 2024 09:52:16 +0100, > > Catalin Marinas wrote: > > > > > > On Tue, Jul 02, 2024 at 06:40:12PM +0800, kernel test robot wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > > head: 82e4255305c554b0bb18b7ccf2db86041b4c8b6e > > > > commit: d633da5d3ab1a0eb26a2213d65da1e189e82f8ab [9019/10049] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs > > > > config: arm-randconfig-r034-20220810 (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/config) > > > > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 > > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/reproduce) > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > > the same patch/commit), kindly add following tags > > > > | Reported-by: kernel test robot > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202407021807.cBuWVBVa-lkp@intel.com/ > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > >> drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used [-Wunused-variable] > > > > 47 | static struct cpumask broken_rdists __read_mostly; > > > > | ^~~~~~~~~~~~~ > > > > > > > > > > > > vim +/broken_rdists +47 drivers/irqchip/irq-gic-v3.c > > > > > > This can happen when building on arm32 with SMP disabled. So we either > > > add a __maybe_unused annotation or we move the variable further down in > > > the CONFIG_SMP block. Marc, what's your preference? > > > > > > -----------8<---------------------- > > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > > index c29b424d1d0c..6393f3d780e9 100644 > > > --- a/drivers/irqchip/irq-gic-v3.c > > > +++ b/drivers/irqchip/irq-gic-v3.c > > > @@ -47,7 +47,7 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > > > > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > > > > > -static struct cpumask broken_rdists __read_mostly; > > > +static struct cpumask broken_rdists __read_mostly __maybe_unused; > > > > > > struct redist_region { > > > void __iomem *redist_base; > > > -----------8<---------------------- > > > > > > or, > > > > > > -----------8<---------------------- > > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > > index c29b424d1d0c..187948f41bb3 100644 > > > --- a/drivers/irqchip/irq-gic-v3.c > > > +++ b/drivers/irqchip/irq-gic-v3.c > > > @@ -47,8 +47,6 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > > > > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > > > > > -static struct cpumask broken_rdists __read_mostly; > > > - > > > struct redist_region { > > > void __iomem *redist_base; > > > phys_addr_t phys_base; > > > @@ -1316,6 +1314,8 @@ static void gic_cpu_init(void) > > > > > > #ifdef CONFIG_SMP > > > > > > +static struct cpumask broken_rdists __read_mostly; > > > + > > > #define MPIDR_TO_SGI_RS(mpidr) (MPIDR_RS(mpidr) << ICC_SGI1R_RS_SHIFT) > > > #define MPIDR_TO_SGI_CLUSTER_ID(mpidr) ((mpidr) & ~0xFUL) > > > > The second version seems to be the most logical one, since we already > > have this SMP-only block (note to self: constraint GICv3 support to > > SMP only at the earliest opportunity). > > > > Feel free to add my > > > > Acked-by: Marc Zyngier > > > > if you decide to push a fix on top of this branch. > > Ah, it's also used in the CONFIG_ACPI block further down. So > __maybe_unused may be easier. Or add some #if defined(CONFIG_SMP) || > defined(CONFIG_ACPI) but it seems too verbose. Ah, of course. Go for the __maybe_unused then, it's not a big deal. My Ack still stands. Thanks, M. -- Without deviation from the norm, progress is not possible.