From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA4EC3DA4A for ; Thu, 8 Aug 2024 16:12:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E2996B007B; Thu, 8 Aug 2024 12:12:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4919E6B0099; Thu, 8 Aug 2024 12:12:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 380AF6B009A; Thu, 8 Aug 2024 12:12:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 19CA46B007B for ; Thu, 8 Aug 2024 12:12:11 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7B38B141504 for ; Thu, 8 Aug 2024 16:12:10 +0000 (UTC) X-FDA: 82429570020.16.6ED6E91 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 5765D180014 for ; Thu, 8 Aug 2024 16:12:08 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=QBah4X24; dkim=pass header.d=linutronix.de header.s=2020e header.b=bKgKnf0X; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf24.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723133519; a=rsa-sha256; cv=none; b=xCg8dlldKqYYPJTHR/S7fbSWJ7pLCzLdeq61ntBmONSHO1WBe/hD/mYFCI4mSNsNYW12iP z3bPR9DsRlbgYtgPOqyJTCWCzwdGUtYkVTkUWNCkZmnEgMs9n13s85rZOHIV//OPWNJcD4 uhFZpzC0iOu4AHOtthnV3lKggMYNTQ8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=QBah4X24; dkim=pass header.d=linutronix.de header.s=2020e header.b=bKgKnf0X; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf24.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723133519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rbK1kwOMlzSlhFlVjG+CRVMzNiTCxjOS9hUbnipGmdo=; b=8ZuSku5yN5OVV2qKoJ3knkd8XJbKoxx388q4nuLxYYnWFfWHIIJk1CvbhJxZd4tOLW83wW QTYV8IJslQOeNYlfNRXhpUUkx/J/jVNPzAQ4DxbRUfwn+OoikDzqdDP66oXkwml9RlT5ru CnIoa9u4ptPDPXEHof1FrXDZmmcAclM= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1723133525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rbK1kwOMlzSlhFlVjG+CRVMzNiTCxjOS9hUbnipGmdo=; b=QBah4X243vmf/D1560ypXArNinqDTFJcnqMuKQQxQLAtNK0yQh3WrNjRNe84QFqLu4iW25 bOVgqcleOOWm9RPUcFfXhO3JuOR7YMR2Ydq+mBm+AlVceevQpQ16NBr0btw09FCyCMK2P7 QOgfwpxqLgBrEuvBDVeAV7b0nJJ+cGDzVcUISm7NqVW1DDRJmwNAuk9340KlRcPFdrPBUd aKTtcvUdWo+wS91hlqnCroVOaQ/spdxusG0GY567a3WPMN0gM6vYpJl2M4vakW7TUF60Hs TJd5onynjl2X7pelfBjY1I62qz5ynp7rqZ7UMwZxCmBXqvrcxReI3kB8WSb/rA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1723133525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rbK1kwOMlzSlhFlVjG+CRVMzNiTCxjOS9hUbnipGmdo=; b=bKgKnf0XUFwW6ZAvvBYIPk8zC6dvtPVqkOyOoVKmXPtDHmwoGA38WJqwoqqzqwQ0Ba+/ni zFY84uSmrFVwHkDQ== To: Linus Torvalds Cc: Guenter Roeck , Vlastimil Babka , linux-kernel@vger.kernel.org, Linux-MM , Helge Deller , linux-parisc@vger.kernel.org Subject: Re: [PATCH 6.10 000/809] 6.10.3-rc3 review In-Reply-To: References: <20240731095022.970699670@linuxfoundation.org> <718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net> <53b2e1f2-4291-48e5-a668-7cf57d900ecd@suse.cz> <87le194kuq.ffs@tglx> <90e02d99-37a2-437e-ad42-44b80c4e94f6@suse.cz> <87frrh44mf.ffs@tglx> <76c643ee-17d6-463b-8ee1-4e30b0133671@roeck-us.net> <87plqjz6aa.ffs@tglx> Date: Thu, 08 Aug 2024 18:12:05 +0200 Message-ID: <87a5hnyox6.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Queue-Id: 5765D180014 X-Rspamd-Server: rspam01 X-Stat-Signature: bxc59caaz1w1da151xey9hz3d5fhn9q9 X-HE-Tag: 1723133528-619057 X-HE-Meta: U2FsdGVkX18byW5nHNo5dkf8Si328hUG7XWnLSCL8BL969H0HJbsLwtH14fW+fvJW/T5FhzwcGrTnFtYN3Z5Gs6gWs1QNGEoIEg5YYqFxByp2XDDlN189j3eTfELvZLEA8meKYrZuC15XC6DUed3ZWbl8MAZHbfWoD0VWkjcSL9kYjCcGLBMU8/jdoWKlOjZnNHmmQofDOkNThFQDZhzSOcP2vcdBtgjKaISYCZM8/DUPg+grszhgWTPUG5PP1zovbkoaDgAGupZd49gYJjlnt6yBYps+PGNJlKY+95Ifu/ZIAFYv3iQ/GYNy/kf1R39y0OZFmftW9yG9xNUA9t2/YHMo9bME+ym59r+GTsa6RAFFKR+va/GuVe3PzKoEnPoMmoiJBQTpX3kuGojGTFvpB3Way/oWbH9zT/p0WOocvtMH9LYKBDeH+jEMM7+xAiXl4529bwDMU5zA5cvrx0leXxzlcS4sPzOHxmQIYALB717XEKNb5j6rEhUz2MuXzYyIG0LFvDQPEq4RBqYayAVFFUth8EPpmaWEuu+wE5RQmo01Siyl/ccMvi3RdWOrCQ0/KpiWnac+q6qNcqIUXnh0iJaOXd5S8HWxcSCvLyx4l/m2hZ6heh0ty1vqDUv3vpJcxnAN/FWrVqZidb1QfGzUqlg3GAR5UBp7wQocrnIzbwNdqw3j8ker6LEOvBeoDvFFm6FnoSXEK102L0c1KO2EtLPBmYc1eBYd4iMhNmBR+1reATB+1n/XdqSZOIJgAqzmiLSsQNVAeUzq0CY30r9MnR7gH2BGQlIL6pKwy1SVgLym24iB4FCGiElSFiwUw/26DFO3wzfZvDKODZPPcof3gYuas6IZDHdvRT/Eh2qep5pnUVvcaSw2ytiox8lu0EgxTci9cbpSuFis/tQ4KCdLcvQaDEe+t6zkHLf2IwJTsxUFsIDUUqq1oupeJTPWKY+lQx/LRb6Hw9geyp/+su 1ICQW/3a 913/AIOCSkzbUG6vYp2Zd/q8Y2tFHtnL57XtJCgPWdw8SvVfa0Cwfd29IyqXmFnOsTK3qC0O3a1w9hN30AcFWaC9VQuHsKJwGPfOAgKzIVE2lgP59jb8Tbm4Qn9Z6JdIhrp4uQ1sZWdw3En/DbVs0FM6jGEgve7wcyHGf5ej3YeKRNPw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 08 2024 at 08:53, Linus Torvalds wrote: > On Thu, 8 Aug 2024 at 02:57, Thomas Gleixner wrote: > Hmm. There's a few patterns there: > > - the incorrect Maxobj is always 16, with wildly different sizes. Which means that the size value is rounded up to the next power of 2 >> [ 0.000000] Order: 1 Size: 384 Nobj: 21 Maxobj: 16 21 Inuse: 14 8192/16 = 512 >> [ 0.000000] Order: 0 Size: 168 Nobj: 24 Maxobj: 16 24 Inuse: 1 4096/16 = 256 >> [ 0.000000] Order: 3 Size: 1536 Nobj: 21 Maxobj: 16 21 Inuse: 1 32768/16 = 2048 >> The maxobj column shows the failed result and the result from the second >> invocation inside of the printk(). > I actually went into the gcc sources to look at the libgcc routines > for the hppa $$divU routine, but apart from checking for trivial > powers-of-two and for divisions with small divisor values (<=17), all > it is ends up being a series of "ds" (divide step) and "addc" > instructions. I don't see how that could possibly mess up. It does end > up with the final addc in the delay slot of the return, but that's > normal parisc behavior (and here by "normal" I mean "it's a really > messed up instruction set that did everything wrong, including branch > delay slots") > > I do note that the $$divU function (which is what this all should use) > oddly doesn't show up as defined in 'nm' for me when I look at > Guenter's vmlinux file. So there's some odd linker thing going on, and > it *only* affects the $$div* functions. > > Thomas' System.map shows some of the same effects, ie it shows $$divoI > (signed integer divide with overflow checking), but doesn't show > $$divU that is right after it. The reason I was looking was exactly > because this should be using $$divU, and clearly code alignment is > implicated somehow, but the exact alignment of $$divU wasn't obvious. > > But it looks like "$$divU" should be somewhere between $$divoI and > $$divl_2, and in Guenter's bad case that's > > 0000000041218c70 T $$divoI > 00000000412190d0 T $$divI_2 > > so *maybe* $$divU is around a page boundary? 0000000041218xxx turning > into 0000000041219000? It uses $$divU which is at $$divoI + 0x250. I validated that in the disassembly. Thanks, tglx