linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Huang, Ying" <ying.huang@intel.com>
To: Wupeng Ma <mawupeng1@huawei.com>
Cc: <akpm@linux-foundation.org>,  <mgorman@techsingularity.net>,
	<mhocko@suse.com>,  <dmaluka@chromium.org>,
	 <liushixin2@huawei.com>, <wangkefeng.wang@huawei.com>,
	 <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm, proc: collect percpu free pages into the free pages
Date: Fri, 30 Aug 2024 15:53:28 +0800	[thread overview]
Message-ID: <87a5guh2fb.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <20240830014453.3070909-1-mawupeng1@huawei.com> (Wupeng Ma's message of "Fri, 30 Aug 2024 09:44:53 +0800")

Hi, Wupeng,

Wupeng Ma <mawupeng1@huawei.com> writes:

> From: Ma Wupeng <mawupeng1@huawei.com>
>
> The introduction of Per-CPU-Pageset (PCP) per zone aims to enhance the
> performance of the page allocator by enabling page allocation without
> requiring the zone lock. This kind of memory is free memory however is
> not included in Memfree or MemAvailable.
>
> With the support of higt-order pcp and pcp auto-tuning, the size of the
> pages in this list has become a matter of concern due to the following
> patches:
>
>   1. Introduction of Order 1~3 and PMD level PCP in commit 44042b449872
>   ("mm/page_alloc: allow high-order pages to be stored on the per-cpu
>   lists").
>   2. Introduction of PCP auto-tuning in commit 90b41691b988 ("mm: add
>   framework for PCP high auto-tuning").

With PCP auto-tuning, the idle pages in PCP will be freed to buddy after
some time (may be as long as tens seconds in some cases).

> Which lead to the total amount of the pcp can not be ignored just after
> booting without any real tasks for as the result show below:
>
> 		   w/o patch	  with patch	      diff	diff/total
> MemTotal:	525424652 kB	525424652 kB	      0 kB	        0%
> MemFree:	517030396 kB	520134136 kB	3103740 kB	      0.6%
> MemAvailable:	515837152 kB	518941080 kB	3103928 kB	      0.6%
>
> On a machine with 16 zones and 600+ CPUs, prior to these commits, the PCP
> list contained 274368 pages (1097M) immediately after booting. In the
> mainline, this number has increased to 3003M, marking a 173% increase.
>
> Since available memory is used by numerous services to determine memory
> pressure. A substantial PCP memory volume leads to an inaccurate estimation
> of available memory size, significantly impacting the service logic.
>
> Remove the useless CONFIG_HIGMEM in si_meminfo_node since it will always
> false in is_highmem_idx if config is not enabled.
>
> Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>

This has been discussed before in the thread of the previous version,
better to refer to it and summarize it.

[1] https://lore.kernel.org/linux-mm/YwSGqtEICW5AlhWr@dhcp22.suse.cz/

--
Best Regards,
Huang, Ying


  reply	other threads:[~2024-08-30  7:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  1:44 Wupeng Ma
2024-08-30  7:53 ` Huang, Ying [this message]
2024-09-02  1:11   ` mawupeng
2024-09-02  1:29     ` Huang, Ying
2024-09-03  1:50       ` mawupeng
2024-09-03  8:09         ` Michal Hocko
2024-09-04  6:49           ` mawupeng
2024-09-04  7:28             ` Michal Hocko
2024-09-10 12:11               ` mawupeng
2024-09-10 13:11                 ` Michal Hocko
2024-09-11  5:37                 ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5guh2fb.fsf@yhuang6-desk2.ccr.corp.intel.com \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dmaluka@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liushixin2@huawei.com \
    --cc=mawupeng1@huawei.com \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox