From: "Will Newton" <will.newton@gmail.com>
To: Nitin Gupta <nitingupta910@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/6] compcache: block device - internal defs
Date: Mon, 24 Mar 2008 20:36:02 +0000 [thread overview]
Message-ID: <87a5b0800803241336u547e0f39j277a8857ce674403@mail.gmail.com> (raw)
In-Reply-To: <4cefeab80803241050y1ee7c22fi73234f24e65f958a@mail.gmail.com>
On Mon, Mar 24, 2008 at 5:50 PM, Nitin Gupta <nitingupta910@gmail.com> wrote:
> > > +
> > > +/* Create /proc/compcache? */
> > > +/* If STATS is disabled, this will give minimal compcache info */
> > > +#define CONFIG_COMPCACHE_PROC
> > > +
> > > +#if DEBUG
> > > +#define CC_DEBUG(fmt,arg...) \
> > > + printk(KERN_DEBUG C fmt,##arg)
> > > +#else
> > > +#define CC_DEBUG(fmt,arg...) NOP
> > > +#endif
> >
> > Have you thought about using pr_debug() for this? It looks like it
> > would simplify this file at the cost of a little flexibility.
> >
>
> I want to enable/disable this debugging based on DEBUG_COMPCACHE flag.
> Thats why I added these macros. I will do 'printk(KERN_DEBUG' ->
> pr_debug
The definition of pr_debug (kernel.h) is already surrounded by #ifdef
DEBUG so it may give you the same behaviour as the CC_DEBUG macro.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-24 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 15:03 Nitin Gupta
2008-03-24 16:05 ` Will Newton
2008-03-24 17:50 ` Nitin Gupta
2008-03-24 20:36 ` Will Newton [this message]
2008-03-24 20:39 ` Nitin Gupta
2008-03-24 16:25 ` Mariusz Kozlowski
2008-03-24 17:39 ` Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5b0800803241336u547e0f39j277a8857ce674403@mail.gmail.com \
--to=will.newton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nitingupta910@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox