Re: [PATCH] mm/damon/Kconfig: enforce DAMON_STAT when DAMON_STAT_ENABLED_DEFAULT is selected

[Enze Li <lienze@kylinos.cn>]

Hi SJ,

On Thu, Aug 14 2025 at 09:24:46 AM -0700, SeongJae Park wrote:

> Hi Enze,
>
> On Thu, 14 Aug 2025 20:17:03 +0800 Enze Li <lienze@kylinos.cn> wrote:
>
>> The DAMON_STAT_ENABLED_DEFAULT option is strongly tied to
>> DAMON_STAT -- enabling it alone is meaningless.
>
> Nice catch, thank you Enze!
>
>> This patch modifies the
>> logic to automatically enable DAMON_STAT whenever
>> DAMON_STAT_ENABLED_DEFAULT is selected, ensuring functional consistency.
>> 
>> Signed-off-by: Enze Li <lienze@kylinos.cn>
>> ---
>>  mm/damon/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
>> index b3171f9406c1..5bc71354e6f3 100644
>> --- a/mm/damon/Kconfig
>> +++ b/mm/damon/Kconfig
>> @@ -105,7 +105,7 @@ config DAMON_STAT
>>  config DAMON_STAT_ENABLED_DEFAULT
>>  	bool "Enable DAMON_STAT by default"
>>  	depends on DAMON_PADDR
>> -	default DAMON_STAT
>> +	select DAMON_STAT

Thanks for your review.  I've updated the patch addressing all your
comments below.  And I'll send the new version to the list shortly.

>
> I don't think we need to drop 'default DAMON_STAT', though.
>
> To me, it seems the problem is the wrong dependency.  What about making
> DAMON_STAT_ENABLED_DEFAULT depends on DAMON_STAT, like below?
>
> """
> diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
> index ecbdb3e2ae58..d5f8db812dd3 100644
> --- a/mm/damon/Kconfig
> +++ b/mm/damon/Kconfig
> @@ -104,7 +104,7 @@ config DAMON_STAT
>
>  config DAMON_STAT_ENABLED_DEFAULT
>         bool "Enable DAMON_STAT by default"
> -       depends on DAMON_PADDR
> +       depends on DAMON_STAT
>         default DAMON_STAT
>         help
>           Whether to enable DAMON_STAT by default.  Users can disable it in
> """
>
> Also, the subject sounds like a bit strong tone ("enforce").  How about
>
> "mm/damon/Kconfig: make DAMON_STAT_ENABLED_DEFAULT depends on DAMON_STAT" ?
>

Best Regards,
Enze