Re: Sashiko.dev for Rust for Linux

Roman Gushchin
2026-03-20T21:09:45Z

"Gary Guo" <gary@garyguo.net> writes:

> On Fri Mar 20, 2026 at 8:24 PM GMT, Roman Gushchin wrote:
>> John Hubbard <jhubbard@nvidia.com> writes:
>>
>>> Hi Roman, Miguel,
>>
>> Hi John!
>>
>>> I was delighted with sashiko.dev after just a very quick peek at a
>>> few of its linux-mm reviews. Up until now, the AI code reviewers
>>> have often fixated on trivia, but this one goes right to real
>>> issues that actually matter. Sweeeet!
>>
>> Thank you!
>>
>>> So what would it take to get similar results for Rust for Linux?
>>> (A bunch of us are working on drivers/gpu/nova-core and
>>> drivers/gpu/drm/nova, which are written in Rust.)
>>>
>>> I'm guessing a combination of "add rust-for-linux to the list
>>> of mailing lists", and a whole bunch of new Rules/Skills?
>>
>> Yes, I'm going to add rust-for-linux (will appear ~tomorrow), but a
>> bunch of patchsets which cc'ed lkml have already been reviewed, please,
>> take a look.
>>
>> We don't need any rules/skills to get *some* reviews, but we certainly
>> might need some prompts to get *better* reviews, both in terms of bug
>> discovery and false positives. If you'll master something, I'm more than
>> happy to give it a try.
>>
>> Thanks,
>> Roman
>
> Hi Roman,
>
> First of all, great work. It has already produced useful review on my
> patchsets.

Thanks!

> I've seen a few false positives on Sashiko which seems to be that it understands
> the Rust code from an userspace Rust perspective and doesn't know some of our
> unique constructs (most notably, the way we handling bindings/FFI).

Yeah, I'd imagine that adding some rust-for-kernel prompts should help a lot.
>
> I'm preparing some prompt changes locally and am testing these out, to see if it
> reduces false positives. It appears to me that the prompt for Sashiko is from
> https://github.com/masoncl/review-prompts? If I made a PR there it would
> eventually land in Sashiko, too, right?

Yes, I'm using some prompts from Chris's repository, but not all of
them. We're in touch with Chris and thinking how to better share them.
As of now, anything works, send them either way, we'll figure out the
syncing part.

Thanks,
Roman