From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F54C433EF for ; Mon, 11 Apr 2022 22:18:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 918F66B0071; Mon, 11 Apr 2022 18:18:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C8746B0073; Mon, 11 Apr 2022 18:18:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 741506B0074; Mon, 11 Apr 2022 18:18:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 622AD6B0071 for ; Mon, 11 Apr 2022 18:18:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 3488980F78 for ; Mon, 11 Apr 2022 22:18:39 +0000 (UTC) X-FDA: 79346013558.11.065A8BD Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf13.hostedemail.com (Postfix) with ESMTP id 7FD2020005 for ; Mon, 11 Apr 2022 22:18:38 +0000 (UTC) Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23BI8fXZ000466; Mon, 11 Apr 2022 15:18:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=WcUTxrxha43kJhDymiMzE1PN7/6V9fSOSV9r5dVmwLY=; b=VCKGm7n6/dxJgsipZ45aSeVFGAd7wVQwS/Cv9TWG/jDqZ/hQszDt5xDiQNQuOVeOLLac ATwCEooczsSSP5P8FKSADf+B6Rng9r+3fBXHbixPXizz9kQUmVRyf+yaHYaXZy0ZDejh JrljlTp5Rs7ODSrktV7JxedjPk/mbjsV2+o= Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2045.outbound.protection.outlook.com [104.47.51.45]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3fb5fr4uu6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Apr 2022 15:18:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ydj9r9lt+eUUqBqLaY+LRWWXqRMNWn5KsOdzydZCEX0raq1sjFlexqME2S7g0y4t+4vTEOzOlY9+6pQf7lvCI6klUN+hIOoctjb1njQvEyxpB8Zj3daj4KAGbtmhymLV0N0ki7lCV+XE6ZUsr+9kLRzzaR523ahAJZklddQTjk3bOolu4YcUNjdJYvS2g35EnXp+WMeuZjP8mj0+F1xzRfTRlQA7I9H9kCecvlGL5NX8ykS4jAhYnDCgWMU3WPyoyl3aATsRTsErzgr2DVMAMShMo+sTsm5pE/Fu7YOk8FZb9tMG82Pte8DPUh0zPCLjPALaSWyUJv0aVzQgjrbfWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WcUTxrxha43kJhDymiMzE1PN7/6V9fSOSV9r5dVmwLY=; b=KGTbtibrSt0jWvoSXJPMesIJAEtdMzi6elMVxWJk+ZhVyn59Ub8hGKrc7usSqKMYhmUPjFTnO+2sukhLFF5tM49Itpf2/JV1I1TuXzYxVzIC98++clnKrfNI0ldXhAxMKNHq2VNAxqB9cenNz6Ea8QcwOp3sX7xckYvBpmoOBURldC2bjlFpmn3I7otFmPg5w0vBr3kJm74pFmcuamlvCVylzh5XqERt0p4+VXqJ1uUCUqkhPpWMIcTzSU47LMlmg/qCiY6CS51x+HzPXRNZrsE/J+74q/tK8VapBRZTpT9C9/8sxH0fj37kpmJQ28gDjunStebbbrlcR3ofrP9LFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none Received: from SA1PR15MB5109.namprd15.prod.outlook.com (2603:10b6:806:1dc::10) by MWHPR15MB1790.namprd15.prod.outlook.com (2603:10b6:301:53::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr 2022 22:18:18 +0000 Received: from SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::20d2:26a2:6cb1:3c4b]) by SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::20d2:26a2:6cb1:3c4b%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022 22:18:17 +0000 From: Song Liu To: Christoph Hellwig CC: Song Liu , "bpf@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-mm@kvack.org" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , Kernel Team , "akpm@linux-foundation.org" , "rick.p.edgecombe@intel.com" , "imbrenda@linux.ibm.com" Subject: Re: [PATCH bpf 2/2] bpf: use vmalloc with VM_ALLOW_HUGE_VMAP for bpf_prog_pack Thread-Topic: [PATCH bpf 2/2] bpf: use vmalloc with VM_ALLOW_HUGE_VMAP for bpf_prog_pack Thread-Index: AQHYS5mtQh1GNVF2tku0imT819YdPaznDoGAgAFQoYCAAexPAIABAW4A Date: Mon, 11 Apr 2022 22:18:17 +0000 Message-ID: <87C3A212-AC47-4AC2-9A85-FD11F61715C0@fb.com> References: <20220408223443.3303509-1-song@kernel.org> <20220408223443.3303509-3-song@kernel.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 212ff510-fb69-45a7-a620-08da1c092dd7 x-ms-traffictypediagnostic: MWHPR15MB1790:EE_ x-microsoft-antispam-prvs: x-fb-source: Internal x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rNo8T86zl8SRX8dwTkuKR8XkgtJUWacsru1Te6czl21gN3g3tKH47ioZXS41GdKdzt32AF+kD4VLjIYZmsxJX9g0TerfYu39w54XXrCq2tLzDWXc0d/949woteliiiFiK+N2r1LqppMPFk2cORh15m/YZ3FbA8SJXsA9z+KYbUONc8yZQcQ76ohk+N3d055UfxQ4MizTnDJ93RINZZVROUCNeaQ8bx4c0WTSrcMZKtF7zwVgiFPdtWvz4RtgiqeShwMw94FIXzA7E05UATB+P9tK1xrPzErUgZw3WXYH8yf8kisousxUtis7oIBiFCmIodmFZ+mh1I2K4xA9MPSbLPwfn42SLF6KVYQszF6io3JoFahEq4kfj2FJYu5amAsYTHtTfcEevaMk+sqQmtclKKWsgnJtkBjUul8iEdUIQ/YGewfyiz37GngV+keL7YNvHFfMehNqLTrPPp0gfAu6L+pVtsZPcLPd3sAsi9R8xxIVFr4VG/yu2PCK1HJ/c317j7/KTyE83WYjWTwjffxs76Vt2tqdI6ytU9XOPDwZ18VL1N3x+bdScb6lO/zCNQKMtqY7lhwB0quiyXR1emvSNghvrG7LIxaXDsWxhPNK7EOTMuXcdyNrGkulfe8wC0sqOeaUF8eLMhbrZUYkLHFSDRZQrewxd8oyU5YlBYHxaOjE9dYiBqbDQdp1JLmPOVkoya0W94nlOvZ2ZJ4bIv4U7A647V08S+0lOANre2Q7LTvnc3RBmeJSQb80xAQVxc//we8O21kS0Vude1K5V3GKXA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR15MB5109.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(76116006)(91956017)(64756008)(66476007)(66946007)(66446008)(4744005)(6506007)(316002)(6512007)(38100700002)(2906002)(4326008)(6486002)(508600001)(86362001)(8676002)(6916009)(38070700005)(7416002)(33656002)(186003)(122000001)(5660300002)(53546011)(36756003)(8936002)(2616005)(54906003)(71200400001)(14583001)(45980500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5LcumMQtnrZymZIPZFmz77QQ/x1Z2UUJoJxSF0BqSkSWpNB4Gj5KxhWAU2cc?= =?us-ascii?Q?mrM5SE78z+t+NtdqNVxD8puAgCH9KorJ2mvudcNZtCY1nuA+vS2xrKKzPTFj?= =?us-ascii?Q?Xu5hhP4EnurrqwpZHXw5qI6OZasCiHbDu0c/ckyoxlDeuFWVU1z1d1FqHXAb?= =?us-ascii?Q?thE/U0BgIAqEkRdYrbAplS3Cm/xRhOO275Z470qBYuVVWM8t2V+kcyPJz/Dm?= =?us-ascii?Q?AFPo3/M9S8FPr1ywJUvABRcdyl6cLtCBQz/UaBBSiDpoeuRR4nLF3FyUuzPY?= =?us-ascii?Q?tnUjXzTgNeq/HO3CSMCarQNsUUuZXUUwBKgoUmhPT+tCSmAyikgDd6bNFSGN?= =?us-ascii?Q?P8IVplIfvsEIXutBO54m2gAhZAbHcpxmQMlZ6sFeINkJ3kcPeM6Whpy8HlPa?= =?us-ascii?Q?6XB9eEDNGpLd2gmft8sIWOnc1/sOpwMduM+26bvedn+cWFHZkIzlbKzpjq50?= =?us-ascii?Q?5IkFIg8S33GsTAsN4MExNk+soSQhsPssKfqz42UwXwsd/cLurWy5maWeFN/e?= =?us-ascii?Q?zPnoG7UwRMN8657opnQAhzl68TLTlF3OMNVdI6oYH/M+qe8Khh9jkbF0lq6z?= =?us-ascii?Q?ZZ0Oh1gXOpbJt1bBThYjGok2dHW8Eejd3LsJwtRqzgD1qqPwiIhOMXkCFYpK?= =?us-ascii?Q?1/08uuBNHunTGFAD1nfdowhpXBP2avFTGawPVFdJW/sAXe+ppBFEn+rk8P1c?= =?us-ascii?Q?Uk54hl9ol50hwEWXFKW/g8QZLRrCZzNRx7J8qoacGcArNZPwTjMzeaqqNnG8?= =?us-ascii?Q?RMlsy72W3IaFDKfbcDBWbb1yPtcj9VS24d4kRHgiUnA950eQHigXaTRh6O3Q?= =?us-ascii?Q?z5qGXoxJZFQz9DyCXZP20vub97yx/deS//n58FjAU2OMVvCRmp31+vQ6/XO7?= =?us-ascii?Q?Nx/U4MtuQXAKMMUZ13alN06RsEjHgUE+QpQIfIpgLfB6POfF3v0MFxJvJXRV?= =?us-ascii?Q?SQInAWscRNFWX3RynRGAU35IHVw407pvPrTBqF8Y0z+EFEutyoxcTHT2M2F/?= =?us-ascii?Q?9sZ9Z0cX1+j2hcM9eCb0gPDOlkmEfn7NdmrewM3pUL52LvSOOIHnXjS5VaYr?= =?us-ascii?Q?NyMOdEaCJJmA5V4bmwwNgFn9+27Emk9uYiN6IysTcWyLFzRscHI/cDNjoUzR?= =?us-ascii?Q?2Qjkoa/EWOEHchvAosjfVXLsBkMGaWPn0g9vEb75rbVmnCUEeYhYMatP652C?= =?us-ascii?Q?1CiA4otEfdFwtEL5uHFh9/69U1x/HRdcepaBgPbH3SB/wN6rubEDe7Hs5czh?= =?us-ascii?Q?UUCletZlB9Df3G+M92mLxiElZ7+S9x01Z6wpVvWnx85ZEx0XTEVpVFTLZGLJ?= =?us-ascii?Q?5AktMy8vTWkHdthNNb2ecXiAZpFtowusjc5A62/RxKSTqp+0crgcwNMRhDu5?= =?us-ascii?Q?4sLJ7FNME6BHOSkAJ0GU0ovy5tO6jRrBDf+U8VCxfBQiLhUEYA5tEGxW/skw?= =?us-ascii?Q?abCubp+rCz09qjBOLgvQpA2gATbB45NtYM86smXkAKW9hZveRHYNpE3ZIeKQ?= =?us-ascii?Q?UHRGOAP9vpExmVPVUt/kyNVvExZ4L6PqoodAkX2it8llcrYruCMEiOTk1YmK?= =?us-ascii?Q?f6TKUQ4LiJ+DVBqZXbaMEkL3VuZzLAKSvf22c/yAXAzj25c+W74vh6p0MeSz?= =?us-ascii?Q?+7CbEzkXbslEHF44akpqsQ0IOEIx8QBjwTiFS01XYZz+vIijf8DblXmOGmA3?= =?us-ascii?Q?DXayKF6ui3v2t+uQQYLOEgGXqOeql/HiQsEdWk3AW2H9b3rsgr3cnc5s94ZR?= =?us-ascii?Q?DHGHK4bQe6A701azGdBODPRs63si6C5JPkVqZ1Dz6zP+H1WMNfZx?= Content-Type: text/plain; charset="us-ascii" Content-ID: <3DA050C381207D48BB8955C75A30C2BB@namprd15.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fb.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 212ff510-fb69-45a7-a620-08da1c092dd7 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 22:18:17.4956 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: agmx2HNqYq8iOLz2J0yaOlA1mcPZMiUtAmKH8uIft76nm0QHBCl2Ir4iBKhXnJ8rBV8zcWmLqEmnOkV2h13pHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1790 X-Proofpoint-GUID: _8MY4vzPezoAAdwP0odyBV63Y48IiCev X-Proofpoint-ORIG-GUID: _8MY4vzPezoAAdwP0odyBV63Y48IiCev X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-11_09,2022-04-11_01,2022-02-23_01 X-Stat-Signature: pzpeszz9hzwcm5o563pbksrmecuxwi4a Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=VCKGm7n6; dmarc=pass (policy=reject) header.from=fb.com; spf=none (imf13.hostedemail.com: domain of "prvs=51006abe8f=songliubraving@fb.com" has no SPF policy when checking 67.231.145.42) smtp.mailfrom="prvs=51006abe8f=songliubraving@fb.com" X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7FD2020005 X-HE-Tag: 1649715518-223904 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Apr 10, 2022, at 11:56 PM, Christoph Hellwig wrote= : >=20 > On Sun, Apr 10, 2022 at 01:34:50AM +0000, Song Liu wrote: >> OTOH, it is probably beneficial for the modules to use something=20 >> similar to bpf_prog_pack, i.e., put text from multiple modules to a=20 >> single huge page. Of course, this requires non-trivial work in both=20 >> mm code and module code. >>=20 >> Given that 1) modules cannot use huge pages yet, and 2) module may >> use differently (with sharing), I think adding module_alloc_large() >> doesn't add much value at the moment. So we can just keep this logic >> in BPF for now.=20 >>=20 >> Does this make sense? >=20 > I'm not intending to say modules should use the new helper. But I'd much > prefer to keep all the MODULES_VADDR related bits self-contained in the > modules code and not splatter it over random other subsystems. Got it. Will add that in v2.=20 Thanks, Song=0D