From: <boxerapp@aol.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
Vladimir Davydov <vdavydov@parallels.com>,
mhocko@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] memcg: fix mutex not unlocked on memcg_create_kmem_cache fail path
Date: Fri, 31 Jan 2014 09:39:25 -0600 [thread overview]
Message-ID: <87BDA3C8-659F-4D58-9923-CEF441DDDAEF@aol.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
I've added this to my to-do list. On January 30, 2014 at 4:09:02 PM CST, Andrew Morton wrote:On Thu, 30 Jan 2014 14:04:12 -0800 (PST) David Rientjes wrote:> On Thu, 30 Jan 2014, Andrew Morton wrote:> > > > Yeah, it shouldn't be temporary it should be the one and only allocation. > > > We should construct the name in memcg_create_kmem_cache() and be done with > > > it.> > > > Could. That would require converting memcg_create_kmem_cache() to take > > a va_list and call kasprintf() on it.> > > > Why? We already construct the name in memcg_create_kmem_cache() > appropriately, we just want to avoid the kstrdup() in > kmem_cache_create_memcg() since it's pointless like my patch does.oh, OK, missed that.The problem now is that the string at kmem_cache.name is PATH_MAXbytes, and PATH_MAX is huuuuuuuge.--To unsubscribe from this list: send the line "unsubscribe linux-kernel" inthe body of a message to majordomo@vger.kernel.orgMore majordomo info at http://vger.kernel.org/majordomo-info.htmlPlease read the FAQ at http://www.tux.org/lkml/
[-- Attachment #2: Type: text/html, Size: 1462 bytes --]
next reply other threads:[~2014-01-31 15:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 15:39 boxerapp [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-30 16:01 Vladimir Davydov
2014-01-30 21:01 ` Andrew Morton
2014-01-30 21:14 ` David Rientjes
2014-01-30 21:29 ` Andrew Morton
2014-01-30 21:38 ` David Rientjes
2014-01-30 21:50 ` Andrew Morton
2014-01-30 22:04 ` David Rientjes
2014-01-30 22:09 ` Andrew Morton
2014-01-30 22:13 ` David Rientjes
2014-01-30 22:15 ` Andrew Morton
2014-01-30 22:39 ` David Rientjes
2014-01-31 6:53 ` Vladimir Davydov
2014-01-31 10:42 ` David Rientjes
2014-01-31 11:29 ` Vladimir Davydov
2014-01-30 21:36 ` David Rientjes
2014-01-30 21:09 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87BDA3C8-659F-4D58-9923-CEF441DDDAEF@aol.com \
--to=boxerapp@aol.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox