From: Punit Agrawal <punit.agrawal@arm.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com, n-horiguchi@ah.jp.nec.com,
kirill.shutemov@linux.intel.com, mike.kravetz@oracle.com,
steve.capper@arm.com, mark.rutland@arm.com,
linux-arch@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3.1 4/6] mm/hugetlb: Allow architectures to override huge_pte_clear()
Date: Tue, 23 May 2017 15:53:48 +0100 [thread overview]
Message-ID: <878tlnhber.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <20170523072629.06163fa6@mschwideX1> (Martin Schwidefsky's message of "Tue, 23 May 2017 07:26:29 +0200")
Martin Schwidefsky <schwidefsky@de.ibm.com> writes:
> On Mon, 22 May 2017 17:25:55 +0100
> Punit Agrawal <punit.agrawal@arm.com> wrote:
>
>> When unmapping a hugepage range, huge_pte_clear() is used to clear the
>> page table entries that are marked as not present. huge_pte_clear()
>> internally just ends up calling pte_clear() which does not correctly
>> deal with hugepages consisting of contiguous page table entries.
>>
>> Add a size argument to address this issue and allow architectures to
>> override huge_pte_clear() by wrapping it in a #ifndef block.
>>
>> Update s390 implementation with the size parameter as well.
>>
>> Note that the change only affects huge_pte_clear() - the other generic
>> hugetlb functions don't need any change.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
>> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>> Cc: Mike Kravetz <mike.kravetz@oracle.com>
>> ---
>>
>> Changes since v3
>>
>> * Drop weak function and use #ifndef block to allow architecture override
>> * Drop unnecessary move of s390 function definition
>>
>> arch/s390/include/asm/hugetlb.h | 2 +-
>> include/asm-generic/hugetlb.h | 4 +++-
>> mm/hugetlb.c | 2 +-
>> 3 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/s390/include/asm/hugetlb.h b/arch/s390/include/asm/hugetlb.h
>> index cd546a245c68..c0443500baec 100644
>> --- a/arch/s390/include/asm/hugetlb.h
>> +++ b/arch/s390/include/asm/hugetlb.h
>> @@ -39,7 +39,7 @@ static inline int prepare_hugepage_range(struct file *file,
>> #define arch_clear_hugepage_flags(page) do { } while (0)
>>
>> static inline void huge_pte_clear(struct mm_struct *mm, unsigned long addr,
>> - pte_t *ptep)
>> + pte_t *ptep, unsigned long sz)
>> {
>> if ((pte_val(*ptep) & _REGION_ENTRY_TYPE_MASK) == _REGION_ENTRY_TYPE_R3)
>> pte_val(*ptep) = _REGION3_ENTRY_EMPTY;
>
> For the nop-change for s390:
> Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Applied the tag locally. Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-05-23 14:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:35 [PATCH v3 0/6] Support for contiguous pte hugepages Punit Agrawal
2017-05-22 13:35 ` [PATCH v3 1/6] mm, gup: Remove broken VM_BUG_ON_PAGE compound check for hugepages Punit Agrawal
2017-05-23 13:09 ` Kirill A. Shutemov
2017-05-22 13:36 ` [PATCH v3 2/6] mm, gup: Ensure real head page is ref-counted when using hugepages Punit Agrawal
2017-05-23 13:13 ` Kirill A. Shutemov
2017-05-23 15:43 ` Punit Agrawal
2017-05-22 13:36 ` [PATCH v3 3/6] mm/hugetlb: add size parameter to huge_pte_offset() Punit Agrawal
2017-05-23 10:04 ` kbuild test robot
2017-05-23 16:13 ` Punit Agrawal
2017-05-22 13:36 ` [PATCH v3 4/6] mm/hugetlb: Allow architectures to override huge_pte_clear() Punit Agrawal
2017-05-22 13:59 ` Arnd Bergmann
2017-05-22 15:40 ` Punit Agrawal
2017-05-22 16:25 ` [PATCH v3.1 " Punit Agrawal
2017-05-22 20:34 ` Arnd Bergmann
2017-05-23 14:53 ` Punit Agrawal
2017-05-23 5:26 ` Martin Schwidefsky
2017-05-23 14:53 ` Punit Agrawal [this message]
2017-05-22 13:36 ` [PATCH v3 5/6] mm/hugetlb: Introduce set_huge_swap_pte_at() helper Punit Agrawal
2017-05-22 16:30 ` [PATCH v3.1 " Punit Agrawal
2017-05-22 13:36 ` [PATCH v3 6/6] mm: rmap: Use correct helper when poisoning hugepages Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tlnhber.fsf@e105922-lin.cambridge.arm.com \
--to=punit.agrawal@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=schwidefsky@de.ibm.com \
--cc=steve.capper@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox