linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Hugh Dickins <hughd@google.com>, Christoph Lameter <cl@linux.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org
Subject: Re: 4.12-rc ppc64 4k-page needs costly allocations
Date: Fri, 02 Jun 2017 13:09:54 +1000	[thread overview]
Message-ID: <878tlb2igt.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <alpine.LSU.2.11.1706011128490.3622@eggly.anvils>

Hugh Dickins <hughd@google.com> writes:

> On Thu, 1 Jun 2017, Christoph Lameter wrote:
>> 
>> Ok so debugging was off but the slab cache has a ctor callback which
>> mandates that the free pointer cannot use the free object space when
>> the object is not in use. Thus the size of the object must be increased to
>> accomodate the freepointer.
>
> Thanks a lot for working that out.  Makes sense, fully understood now,
> nothing to worry about (though makes one wonder whether it's efficient
> to use ctors on high-alignment caches; or whether an internal "zero-me"
> ctor would be useful).

Or should we just be using kmem_cache_zalloc() when we allocate from
those slabs?

Given all the ctor's do is memset to 0.

cheers

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-06-02  3:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 19:43 Hugh Dickins
2017-05-31  6:46 ` Michael Ellerman
2017-05-31 14:09   ` Christoph Lameter
2017-05-31 18:44     ` Hugh Dickins
2017-05-31 19:02       ` Mathieu Malaterre
2017-06-01 15:31       ` Christoph Lameter
2017-06-01 17:22         ` Hugh Dickins
2017-06-01 18:16           ` Christoph Lameter
2017-06-01 18:37             ` Hugh Dickins
2017-06-02  3:09               ` Michael Ellerman [this message]
2017-06-02  4:00                 ` Hugh Dickins
2017-06-02 14:33                   ` Christoph Lameter
2017-06-08  5:44                   ` Michael Ellerman
2017-06-02 14:32               ` Christoph Lameter
2017-06-08  5:52                 ` Michael Ellerman
2017-05-31 14:06 ` Christoph Lameter
2017-06-01  4:19 ` Aneesh Kumar K.V
2017-06-01 16:57   ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tlb2igt.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cl@linux.com \
    --cc=hughd@google.com \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox